fix(clickhouse): gate the compile-time downgrade on who wrote the query

The execution layer only downgrades when the caller wrote the SQL, but
the compile-time catch downgraded every ExposedTSQLError regardless. A
compile failure on TRQL we generated is our bug, and it was logging at
warn.

Whether an error is safe to show someone is a separate question from
whose mistake it is, so the same gate now applies at both layers.

Author: ericallam

internal-packages/clickhouse/src/client/tsql.ts

@@ -321,7 +321,7 @@ export async function executeTSQL<TOut extends z.ZodSchema>(
       generatedParams: generatedParams ?? {},
     };
 
-    const callerWroteABadQuery = error instanceof ExposedTSQLError;
+    const callerWroteABadQuery = options.userAuthoredQuery && error instanceof ExposedTSQLError;
 
     if (callerWroteABadQuery) {
       logger.warn("[TSQL] Invalid query", logFields);

internal-packages/clickhouse/src/tsql.test.ts

@@ -1642,6 +1642,7 @@ describe("TSQL Error Log Levels", () => {
         organization_id: { op: "eq", value: "org_tenant1" },
       },
       tableSchema: [taskRunsSchema],
+      userAuthoredQuery: true,
     });
 
     expect(error).not.toBeNull();
@@ -1663,6 +1664,7 @@ describe("TSQL Error Log Levels", () => {
         organization_id: { op: "eq", value: "org_tenant1" },
       },
       tableSchema: [taskRunsSchema],
+      userAuthoredQuery: true,
     });
 
     expect(error).not.toBeNull();
@@ -1694,6 +1696,30 @@ describe("TSQL Error Log Levels", () => {
     }
   );
 
+  clickhouseTest(
+    "keeps a compile failure on TRQL we generated at error level",
+    async ({ clickhouseContainer }) => {
+      const client = new ClickhouseClient({
+        name: "test",
+        url: clickhouseContainer.getConnectionUrl(),
+      });
+
+      const [error] = await executeTSQL(client, {
+        name: "test-internal-compile-error",
+        query: "SELECT nope FROM task_runs",
+        schema: z.object({ nope: z.string() }),
+        enforcedWhereClause: {
+          organization_id: { op: "eq", value: "org_tenant1" },
+        },
+        tableSchema: [taskRunsSchema],
+      });
+
+      expect(error).not.toBeNull();
+      expect(logged(errorSpy)).toContain("[TSQL] Query error");
+      expect(logged(warnSpy)).not.toContain("[TSQL] Invalid query");
+    }
+  );
+
   clickhouseTest(
     "logs invalid caller-written SQL as a warning",
     async ({ clickhouseContainer }) => {