Skip to content

Commit afd1b1e

Browse files
committed
fix(supervisor): distinguish invalid response outcome and drop unneeded core changeset
1 parent 5218d3d commit afd1b1e

4 files changed

Lines changed: 4 additions & 7 deletions

File tree

.changeset/supervisor-http-client-request-metrics.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.server-changes/supervisor-outbound-request-metrics.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ area: supervisor
33
type: improvement
44
---
55

6-
The supervisor now reports a Prometheus metric for its outbound HTTP requests, so failed calls to upstream services are visible for monitoring.
6+
Improved supervisor observability: it now reports metrics for its outbound requests, making failed calls to upstream services easier to monitor.

packages/core/src/v3/runEngineWorker/supervisor/http.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ export class SupervisorHttpClient {
7575

7676
if (result.success) {
7777
this.onHttpRequestComplete({ name, method, status: "2xx", outcome: "ok" });
78+
} else if (result.statusCode === 200) {
79+
this.onHttpRequestComplete({ name, method, status: "200", outcome: "invalid_response" });
7880
} else if (typeof result.statusCode === "number") {
7981
this.onHttpRequestComplete({
8082
name,

packages/core/src/v3/runEngineWorker/supervisor/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export type SupervisorHttpRequestMetric = {
44
name: string;
55
method: string;
66
status: string;
7-
outcome: "ok" | "http_error" | "network_error";
7+
outcome: "ok" | "http_error" | "invalid_response" | "network_error";
88
};
99

1010
export type SupervisorClientCommonOptions = {

0 commit comments

Comments
 (0)