Skip to content

Commit a6bd370

Browse files
authored
chore: remove end-of-life v3 execution components (#4194)
v3 (engine V1) is end-of-lifed and the v3 clusters are gone, so this removes the dead v3 execution code from the monorepo. It's the first pass of TRI-11824 - the webapp v3 code paths are deliberately left untouched and gated for a follow-up. ## Apps Deletes the three v3-only execution apps and their build wiring: - `apps/coordinator`, `apps/kubernetes-provider`, `apps/docker-provider` - `.github/workflows/publish-worker.yml` - it built only those three; the v4 worker publish is a separate workflow - Their references in `.changeset/config.json`, `.cursorignore`, `CHANGESETS.md`, `CONTRIBUTING.md`, `.server-changes/README.md` - `pnpm-lock.yaml` regenerated to prune the apps and their app-only dependencies (`socket.io`, `@kubernetes/client-node`, `p-queue`, `execa`, `prom-client`, `tinyexec`) ## Core Removes the helpers in `@trigger.dev/core` that only those apps used - `ProviderShell`, `SimpleLogger`, the `Exec`/process helpers, `isExecaChildProcess`, `getTextBody`, and `testDockerCheckpoint`. Each was verified to have no remaining consumers anywhere in the repo. Kept the helpers still used elsewhere: `ExponentialBackoff` (warm-start client), `HttpReply`/`getJsonBody` (serverOnly http server), `SimpleStructuredLogger` (widely used), and `ZodNamespace`/`ZodSocketConnection` (still referenced by legacy v3 webapp code, hence the follow-up pass). The `./v3/apps` and `./v3/serverOnly` export subpaths remain - only dead members were trimmed from their barrels, so no `package.json` exports changed. ## Verification `@trigger.dev/core` builds, and `typecheck` passes for core, supervisor, cli-v3, run-engine, redis-worker, and webapp. refs TRI-11824
1 parent e0208f3 commit a6bd370

48 files changed

Lines changed: 14 additions & 6854 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.changeset/config.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
"updateInternalDependencies": "patch",
1515
"ignore": [
1616
"webapp",
17-
"coordinator",
18-
"docker-provider",
19-
"kubernetes-provider",
2017
"supervisor"
2118
],
2219
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@trigger.dev/core": patch
3+
---
4+
5+
Removed internal helpers that were only used by the end-of-life v3 self-hosted compute providers.

.claude/rules/server-apps.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ paths:
55

66
# Server App Changes
77

8-
When modifying server apps (webapp, supervisor, coordinator, etc.) with **no package changes**, add a `.server-changes/` file instead of a changeset:
8+
When modifying server apps (webapp, supervisor, etc.) with **no package changes**, add a `.server-changes/` file instead of a changeset:
99

1010
```bash
1111
cat > .server-changes/descriptive-name.md << 'EOF'
@@ -18,6 +18,6 @@ Brief description of what changed and why.
1818
EOF
1919
```
2020

21-
- **area**: `webapp` | `supervisor` | `coordinator` | `kubernetes-provider` | `docker-provider`
21+
- **area**: `webapp` | `supervisor`
2222
- **type**: `feature` | `fix` | `improvement` | `breaking`
2323
- If the PR also touches `packages/`, just the changeset is sufficient (no `.server-changes/` needed).

.cursorignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
apps/docker-provider/
2-
apps/kubernetes-provider/
31
apps/proxy/
4-
apps/coordinator/
52
packages/rsc/
63
.changeset
74
.zed

.github/workflows/publish-worker.yml

Lines changed: 0 additions & 105 deletions
This file was deleted.

.github/workflows/publish.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ on:
3030
- ".github/workflows/unit-tests.yml"
3131
- ".github/workflows/e2e.yml"
3232
- ".github/workflows/publish-webapp.yml"
33-
- ".github/workflows/publish-worker.yml"
3433
- "packages/**"
3534
- "!packages/**/*.md"
3635
- "!packages/**/*.eslintrc"
@@ -80,19 +79,6 @@ jobs:
8079
# to its own namespace; set the IMAGE_REGISTRY repository variable to override.
8180
image_registry: ${{ vars.IMAGE_REGISTRY || format('ghcr.io/{0}', github.repository_owner) }}
8281

83-
publish-worker:
84-
needs: [typecheck]
85-
permissions:
86-
contents: read
87-
packages: write
88-
uses: ./.github/workflows/publish-worker.yml
89-
secrets:
90-
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
91-
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
92-
with:
93-
image_tag: ${{ inputs.image_tag }}
94-
image_registry: ${{ vars.IMAGE_REGISTRY || format('ghcr.io/{0}', github.repository_owner) }}
95-
9682
publish-worker-v4:
9783
needs: [typecheck]
9884
permissions:

.server-changes/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Server Changes
22

3-
This directory tracks changes to server-only components (webapp, supervisor, coordinator, etc.) that are not captured by changesets. Changesets only track published npm packages — server changes would otherwise go undocumented.
3+
This directory tracks changes to server-only components (webapp, supervisor, etc.) that are not captured by changesets. Changesets only track published npm packages — server changes would otherwise go undocumented.
44

55
## When to add a file
66

7-
**Server-only PRs**: If your PR only changes `apps/webapp/`, `apps/supervisor/`, `apps/coordinator/`, or other server components (and does NOT change anything in `packages/`), add a `.server-changes/` file.
7+
**Server-only PRs**: If your PR only changes `apps/webapp/`, `apps/supervisor/`, or other server components (and does NOT change anything in `packages/`), add a `.server-changes/` file.
88

99
**Mixed PRs** (both packages and server): Just add a changeset as usual. No `.server-changes/` file needed — the changeset covers it.
1010

@@ -31,7 +31,7 @@ Speed up batch queue processing by removing stalls and fixing retry race
3131

3232
### Fields
3333

34-
- **area** (required): `webapp` | `supervisor` | `coordinator` | `kubernetes-provider` | `docker-provider`
34+
- **area** (required): `webapp` | `supervisor`
3535
- **type** (required): `feature` | `fix` | `improvement` | `breaking`
3636

3737
### Description

CHANGESETS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Speed up batch queue processing by removing stalls and fixing retry race
2121
EOF
2222
```
2323

24-
- `area`: `webapp` | `supervisor` | `coordinator` | `kubernetes-provider` | `docker-provider`
24+
- `area`: `webapp` | `supervisor`
2525
- `type`: `feature` | `fix` | `improvement` | `breaking`
2626

2727
For **mixed PRs** (both packages and server): just add a changeset. No `.server-changes/` file needed.

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ Most of the time the changes you'll make are likely to be categorized as patch r
265265

266266
## Adding server changes
267267

268-
Changesets only track published npm packages. If your PR only changes server components (`apps/webapp/`, `apps/supervisor/`, `apps/coordinator/`, etc.) with no package changes, add a `.server-changes/` file so the change appears in release notes.
268+
Changesets only track published npm packages. If your PR only changes server components (`apps/webapp/`, `apps/supervisor/`, etc.) with no package changes, add a `.server-changes/` file so the change appears in release notes.
269269

270270
Create a markdown file with a descriptive name:
271271

@@ -281,7 +281,7 @@ EOF
281281
```
282282

283283
**Fields:**
284-
- `area` (required): `webapp` | `supervisor` | `coordinator` | `kubernetes-provider` | `docker-provider`
284+
- `area` (required): `webapp` | `supervisor`
285285
- `type` (required): `feature` | `fix` | `improvement` | `breaking`
286286

287287
The body text (below the frontmatter) is a one-line description of the change. Keep it concise — it will appear in release notes.

apps/coordinator/.env.example

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)