Skip to content

Commit 4e72dce

Browse files
committed
fix(sdk): string queue names in tasks are references, not definitions
A bare string home (alone or as a tuple's first element) no longer registers queue metadata, so module evaluation order can no longer shadow a declared queue's limits with an empty definition.
1 parent 11d93a6 commit 4e72dce

1 file changed

Lines changed: 20 additions & 2 deletions

File tree

packages/trigger-sdk/src/v3/shared.ts

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,16 @@ export function createTask<
360360

361361
const queue = normalizedQueue.queue;
362362

363-
if (queue && typeof queue.name === "string") {
363+
/**
364+
* A string queue name (bare or as a tuple's first element) is a REFERENCE to a
365+
* queue defined elsewhere; registering it would create an empty definition that
366+
* can shadow the real one depending on module evaluation order.
367+
*/
368+
const homeIsReference = Array.isArray(params.queue)
369+
? typeof params.queue[0] === "string"
370+
: typeof params.queue === "string";
371+
372+
if (queue && typeof queue.name === "string" && !homeIsReference) {
364373
resourceCatalog.registerQueueMetadata({
365374
name: queue.name,
366375
concurrencyLimit: queue.concurrencyLimit,
@@ -519,7 +528,16 @@ export function createSchemaTask<
519528

520529
const queue = normalizedQueue.queue;
521530

522-
if (queue && typeof queue.name === "string") {
531+
/**
532+
* A string queue name (bare or as a tuple's first element) is a REFERENCE to a
533+
* queue defined elsewhere; registering it would create an empty definition that
534+
* can shadow the real one depending on module evaluation order.
535+
*/
536+
const homeIsReference = Array.isArray(params.queue)
537+
? typeof params.queue[0] === "string"
538+
: typeof params.queue === "string";
539+
540+
if (queue && typeof queue.name === "string" && !homeIsReference) {
523541
resourceCatalog.registerQueueMetadata({
524542
name: queue.name,
525543
concurrencyLimit: queue.concurrencyLimit,

0 commit comments

Comments
 (0)