fix(webapp): remove overly-broad catch on ClickHouse factory resolution

As pointed out in code review: the guard on line 126 already screens out all
non-ClickHouse store values, so the only values reaching getEventRepositoryForOrganizationSync
are 'clickhouse' and 'clickhouse_v2' — both valid. The broad catch was unnecessary
and harmful: a real ClickHouse resolution failure would have been silently routed
to Postgres, writing spans where they'd be invisible on the ClickHouse read path.

Author: matt-aitken

apps/webapp/app/v3/otlpExporter.server.ts

@@ -124,21 +124,14 @@ class OTLPExporter {
           // Non-ClickHouse stores (taskEvent / taskEventPartitioned) are Postgres-backed.
           // The ClickHouse factory only handles clickhouse/clickhouse_v2 and throws otherwise.
           if (taskEventStore !== "clickhouse" && taskEventStore !== "clickhouse_v2") {
+            // Non-ClickHouse stores (taskEvent / taskEventPartitioned) are Postgres-backed.
+            // The ClickHouse factory only handles clickhouse/clickhouse_v2 and throws otherwise.
             resolved = { key: "postgres:default", repository: eventRepository };
           } else {
-            try {
-              resolved = this._clickhouseFactory.getEventRepositoryForOrganizationSync(
-                taskEventStore,
-                event.organizationId
-              );
-            } catch (error) {
-              logger.error("[OTLPExporter] Failed to resolve ClickHouse event repository", {
-                taskEventStore,
-                organizationId: event.organizationId,
-                error: error instanceof Error ? error.message : error,
-              });
-              resolved = { key: "postgres:default", repository: eventRepository };
-            }
+            resolved = this._clickhouseFactory.getEventRepositoryForOrganizationSync(
+              taskEventStore,
+              event.organizationId
+            );
           }
           routeCache.set(routeKey, resolved);
         }