Skip to content

Commit 0c71dc7

Browse files
nicktrnnicktrn
authored
feat: add node 22 and bun runtime support with version display (#2254)
* update node-22 image * update bun image * disable io_uring * fix fallback bun path * prevent duplicate warnings * add runtime and version to deployments * runtime icons * fallback to nodejs * prevent empty table cell menu * log if local build on deploy * pass io_uring env var to child * denormalize runtime and version, display on run details * add changesets * disable pr checks for changeset commits.. * add runtime data to deployed bg workers
1 parent 6ff0b92 commit 0c71dc7

File tree

38 files changed

+389
-50
lines changed

38 files changed

+389
-50
lines changed

‎.changeset/eight-ligers-help.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"trigger.dev": patch
3+
---
4+
5+
Enhance deploy command output to better distinguish between local and remote builds

‎.changeset/sixty-beers-share.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"trigger.dev": patch
3+
"@trigger.dev/core": patch
4+
---
5+
6+
Add runtime version detection for display in the dashboard

‎.changeset/soft-candles-do.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"trigger.dev": patch
3+
---
4+
5+
Update base images to latest compatible versions. The `node-22` runtime now uses v22.16.0 and `bun` uses the latest v1.2.18 release. The default `node` runtime is unchanged and points at v21.7.3.

‎.changeset/yellow-cars-tell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@trigger.dev/core": patch
3+
---
4+
5+
Fix Bun runtime path resolution fallback

‎.github/workflows/pr_checks.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
types: [opened, synchronize, reopened]
66
paths-ignore:
77
- "docs/**"
8+
- ".changeset/**"
89

910
concurrency:
1011
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}

‎apps/webapp/app/assets/icons/BunLogoIcon.tsx

Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
export function BunLogoIcon({ className }: { className?: string }) {
2+
return (
3+
<svg className={className} viewBox="0 0 80 70" xmlns="http://www.w3.org/2000/svg">
4+
<path
5+
id="Shadow"
6+
d="M71.09,20.74c-.16-.17-.33-.34-.5-.5s-.33-.34-.5-.5-.33-.34-.5-.5-.33-.34-.5-.5-.33-.34-.5-.5-.33-.34-.5-.5-.33-.34-.5-.5A26.46,26.46,0,0,1,75.5,35.7c0,16.57-16.82,30.05-37.5,30.05-11.58,0-21.94-4.23-28.83-10.86l.5.5.5.5.5.5.5.5.5.5.5.5.5.5C19.55,65.3,30.14,69.75,42,69.75c20.68,0,37.5-13.48,37.5-30C79.5,32.69,76.46,26,71.09,20.74Z"
7+
/>
8+
<g id="Body">
9+
<path
10+
id="Background"
11+
d="M73,35.7c0,15.21-15.67,27.54-35,27.54S3,50.91,3,35.7C3,26.27,9,17.94,18.22,13S33.18,3,38,3s8.94,4.13,19.78,10C67,17.94,73,26.27,73,35.7Z"
12+
style={{ fill: "#fbf0df" }}
13+
/>
14+
<path
15+
id="Bottom_Shadow"
16+
data-name="Bottom Shadow"
17+
d="M73,35.7a21.67,21.67,0,0,0-.8-5.78c-2.73,33.3-43.35,34.9-59.32,24.94A40,40,0,0,0,38,63.24C57.3,63.24,73,50.89,73,35.7Z"
18+
style={{ fill: "#f6dece" }}
19+
/>
20+
<path
21+
id="Light_Shine"
22+
data-name="Light Shine"
23+
d="M24.53,11.17C29,8.49,34.94,3.46,40.78,3.45A9.29,9.29,0,0,0,38,3c-2.42,0-5,1.25-8.25,3.13-1.13.66-2.3,1.39-3.54,2.15-2.33,1.44-5,3.07-8,4.7C8.69,18.13,3,26.62,3,35.7c0,.4,0,.8,0,1.19C9.06,15.48,20.07,13.85,24.53,11.17Z"
24+
style={{ fill: "#fffefc" }}
25+
/>
26+
<path
27+
id="Top"
28+
d="M35.12,5.53A16.41,16.41,0,0,1,29.49,18c-.28.25-.06.73.3.59,3.37-1.31,7.92-5.23,6-13.14C35.71,5,35.12,5.12,35.12,5.53Zm2.27,0A16.24,16.24,0,0,1,39,19c-.12.35.31.65.55.36C41.74,16.56,43.65,11,37.93,5,37.64,4.74,37.19,5.14,37.39,5.49Zm2.76-.17A16.42,16.42,0,0,1,47,17.12a.33.33,0,0,0,.65.11c.92-3.49.4-9.44-7.17-12.53C40.08,4.54,39.82,5.08,40.15,5.32ZM21.69,15.76a16.94,16.94,0,0,0,10.47-9c.18-.36.75-.22.66.18-1.73,8-7.52,9.67-11.12,9.45C21.32,16.4,21.33,15.87,21.69,15.76Z"
29+
style={{ fill: "#ccbea7", fillRule: "evenodd" }}
30+
/>
31+
<path
32+
id="Outline"
33+
d="M38,65.75C17.32,65.75.5,52.27.5,35.7c0-10,6.18-19.33,16.53-24.92,3-1.6,5.57-3.21,7.86-4.62,1.26-.78,2.45-1.51,3.6-2.19C32,1.89,35,.5,38,.5s5.62,1.2,8.9,3.14c1,.57,2,1.19,3.07,1.87,2.49,1.54,5.3,3.28,9,5.27C69.32,16.37,75.5,25.69,75.5,35.7,75.5,52.27,58.68,65.75,38,65.75ZM38,3c-2.42,0-5,1.25-8.25,3.13-1.13.66-2.3,1.39-3.54,2.15-2.33,1.44-5,3.07-8,4.7C8.69,18.13,3,26.62,3,35.7,3,50.89,18.7,63.25,38,63.25S73,50.89,73,35.7C73,26.62,67.31,18.13,57.78,13,54,11,51.05,9.12,48.66,7.64c-1.09-.67-2.09-1.29-3-1.84C42.63,4,40.42,3,38,3Z"
34+
/>
35+
</g>
36+
<g id="Mouth">
37+
<g id="Background-2" data-name="Background">
38+
<path
39+
d="M45.05,43a8.93,8.93,0,0,1-2.92,4.71,6.81,6.81,0,0,1-4,1.88A6.84,6.84,0,0,1,34,47.71,8.93,8.93,0,0,1,31.12,43a.72.72,0,0,1,.8-.81H44.26A.72.72,0,0,1,45.05,43Z"
40+
style={{ fill: "#b71422" }}
41+
/>
42+
</g>
43+
<g id="Tongue">
44+
<path
45+
id="Background-3"
46+
data-name="Background"
47+
d="M34,47.79a6.91,6.91,0,0,0,4.12,1.9,6.91,6.91,0,0,0,4.11-1.9,10.63,10.63,0,0,0,1-1.07,6.83,6.83,0,0,0-4.9-2.31,6.15,6.15,0,0,0-5,2.78C33.56,47.4,33.76,47.6,34,47.79Z"
48+
style={{ fill: "#ff6164" }}
49+
/>
50+
<path
51+
id="Outline-2"
52+
data-name="Outline"
53+
d="M34.16,47a5.36,5.36,0,0,1,4.19-2.08,6,6,0,0,1,4,1.69c.23-.25.45-.51.66-.77a7,7,0,0,0-4.71-1.93,6.36,6.36,0,0,0-4.89,2.36A9.53,9.53,0,0,0,34.16,47Z"
54+
/>
55+
</g>
56+
<path
57+
id="Outline-3"
58+
data-name="Outline"
59+
d="M38.09,50.19a7.42,7.42,0,0,1-4.45-2,9.52,9.52,0,0,1-3.11-5.05,1.2,1.2,0,0,1,.26-1,1.41,1.41,0,0,1,1.13-.51H44.26a1.44,1.44,0,0,1,1.13.51,1.19,1.19,0,0,1,.25,1h0a9.52,9.52,0,0,1-3.11,5.05A7.42,7.42,0,0,1,38.09,50.19Zm-6.17-7.4c-.16,0-.2.07-.21.09a8.29,8.29,0,0,0,2.73,4.37A6.23,6.23,0,0,0,38.09,49a6.28,6.28,0,0,0,3.65-1.73,8.3,8.3,0,0,0,2.72-4.37.21.21,0,0,0-.2-.09Z"
60+
/>
61+
</g>
62+
<g id="Face">
63+
<ellipse
64+
id="Right_Blush"
65+
data-name="Right Blush"
66+
cx="53.22"
67+
cy="40.18"
68+
rx="5.85"
69+
ry="3.44"
70+
style={{ fill: "#febbd0" }}
71+
/>
72+
<ellipse
73+
id="Left_Bluch"
74+
data-name="Left Bluch"
75+
cx="22.95"
76+
cy="40.18"
77+
rx="5.85"
78+
ry="3.44"
79+
style={{ fill: "#febbd0" }}
80+
/>
81+
<path
82+
id="Eyes"
83+
d="M25.7,38.8a5.51,5.51,0,1,0-5.5-5.51A5.51,5.51,0,0,0,25.7,38.8Zm24.77,0A5.51,5.51,0,1,0,45,33.29,5.5,5.5,0,0,0,50.47,38.8Z"
84+
style={{ fillRule: "evenodd" }}
85+
/>
86+
<path
87+
id="Iris"
88+
d="M24,33.64a2.07,2.07,0,1,0-2.06-2.07A2.07,2.07,0,0,0,24,33.64Zm24.77,0a2.07,2.07,0,1,0-2.06-2.07A2.07,2.07,0,0,0,48.75,33.64Z"
89+
style={{ fill: "#fff", fillRule: "evenodd" }}
90+
/>
91+
</g>
92+
</svg>
93+
);
94+
}

‎apps/webapp/app/assets/icons/NodejsLogoIcon.tsx

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
export function NodejsLogoIcon({ className }: { className?: string }) {
2+
return (
3+
<svg className={className} viewBox="0 0 71 80" fill="none" xmlns="http://www.w3.org/2000/svg">
4+
<g clipPath="url(#clip0_337_7891)" fill="#5FA04E">
5+
<path d="M35.625 79.5c-1.081 0-2.09-.288-3.028-.792l-9.59-5.686c-1.442-.792-.721-1.08-.289-1.224 1.947-.648 2.308-.792 4.327-1.944.216-.144.504-.072.72.072l7.356 4.391c.288.144.649.144.865 0l28.77-16.628c.289-.144.433-.431.433-.791V23.714c0-.36-.144-.648-.432-.792L35.986 6.366c-.288-.144-.65-.144-.865 0L6.35 22.922c-.29.144-.434.504-.434.792v33.184c0 .287.145.647.433.791l7.86 4.535c4.254 2.16 6.922-.36 6.922-2.879V26.593c0-.432.36-.864.865-.864h3.678c.432 0 .865.36.865.864v32.752c0 5.687-3.1 8.998-8.509 8.998-1.658 0-2.956 0-6.633-1.8l-7.572-4.319A6.073 6.073 0 0 1 .798 56.97V23.786a6.073 6.073 0 0 1 3.028-5.255l28.77-16.628c1.804-1.008 4.255-1.008 6.058 0l28.77 16.628a6.073 6.073 0 0 1 3.029 5.255V56.97a6.073 6.073 0 0 1-3.029 5.254l-28.77 16.628c-.865.36-1.947.648-3.029.648Z" />
6+
<path d="M44.567 56.682c-12.62 0-15.215-5.759-15.215-10.654 0-.432.36-.864.865-.864h3.75c.433 0 .793.288.793.72.577 3.815 2.235 5.687 9.879 5.687 6.057 0 8.652-1.368 8.652-4.607 0-1.871-.72-3.24-10.167-4.175-7.86-.792-12.762-2.52-12.762-8.782 0-5.83 4.903-9.285 13.123-9.285 9.23 0 13.772 3.167 14.35 10.077 0 .216-.073.432-.217.648-.144.144-.36.288-.577.288h-3.822a.844.844 0 0 1-.793-.648c-.865-3.96-3.1-5.255-9.013-5.255-6.634 0-7.427 2.304-7.427 4.031 0 2.088.937 2.736 9.879 3.887 8.869 1.152 13.05 2.808 13.05 8.998 0 6.335-5.263 9.934-14.348 9.934Z" />
7+
</g>
8+
<defs>
9+
<clipPath id="clip0_337_7891">
10+
<path fill="#fff" d="M0 .5h71v79H0z" />
11+
</clipPath>
12+
</defs>
13+
</svg>
14+
);
15+
}

‎apps/webapp/app/components/RuntimeIcon.tsx

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
import { SimpleTooltip } from "~/components/primitives/Tooltip";
2+
import { BunLogoIcon } from "~/assets/icons/BunLogoIcon";
3+
import { NodejsLogoIcon } from "~/assets/icons/NodejsLogoIcon";
4+
import { parseRuntime, formatRuntimeWithVersion, type NormalizedRuntime } from "~/utils/runtime";
5+
6+
interface RuntimeIconProps {
7+
runtime?: string | null;
8+
runtimeVersion?: string | null;
9+
className?: string;
10+
withLabel?: boolean;
11+
}
12+
13+
const getIcon = (runtime: NormalizedRuntime, className: string) => {
14+
switch (runtime) {
15+
case "bun":
16+
return <BunLogoIcon className={className} />;
17+
case "node":
18+
return <NodejsLogoIcon className={className} />;
19+
default:
20+
return <span className="text-text-dimmed">–</span>;
21+
}
22+
};
23+
24+
export function RuntimeIcon({
25+
runtime,
26+
runtimeVersion,
27+
className = "h-4 w-4",
28+
withLabel = false,
29+
}: RuntimeIconProps) {
30+
const parsedRuntime = parseRuntime(runtime);
31+
32+
// Default to Node.js if no runtime is specified
33+
const effectiveRuntime = parsedRuntime || {
34+
runtime: "node" as const,
35+
originalRuntime: "node",
36+
displayName: "Node.js",
37+
};
38+
39+
const icon = getIcon(effectiveRuntime.runtime, className);
40+
const formattedText = formatRuntimeWithVersion(effectiveRuntime.originalRuntime, runtimeVersion);
41+
42+
if (withLabel) {
43+
return (
44+
<span className="flex items-center gap-1">
45+
{icon}
46+
<span>{formattedText}</span>
47+
</span>
48+
);
49+
}
50+
51+
if (typeof icon === "object" && "type" in icon) {
52+
return (
53+
<SimpleTooltip button={icon} content={formattedText} side="top" disableHoverableContent />
54+
);
55+
}
56+
57+
return icon;
58+
}

‎apps/webapp/app/presenters/v3/DeploymentListPresenter.server.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ export class DeploymentListPresenter {
9797
id: string;
9898
shortCode: string;
9999
version: string;
100+
runtime: string | null;
101+
runtimeVersion: string | null;
100102
status: WorkerDeploymentStatus;
101103
environmentId: string;
102104
builtAt: Date | null;
@@ -114,6 +116,8 @@ export class DeploymentListPresenter {
114116
wd."id",
115117
wd."shortCode",
116118
wd."version",
119+
wd."runtime",
120+
wd."runtimeVersion",
117121
(SELECT COUNT(*) FROM ${sqlDatabaseSchema}."BackgroundWorkerTask" WHERE "BackgroundWorkerTask"."workerId" = wd."workerId") AS "tasksCount",
118122
wd."environmentId",
119123
wd."status",
@@ -148,6 +152,8 @@ LIMIT ${pageSize} OFFSET ${pageSize * (page - 1)};`;
148152
id: deployment.id,
149153
shortCode: deployment.shortCode,
150154
version: deployment.version,
155+
runtime: deployment.runtime,
156+
runtimeVersion: deployment.runtimeVersion,
151157
status: deployment.status,
152158
builtAt: deployment.builtAt,
153159
deployedAt: deployment.deployedAt,

‎apps/webapp/app/presenters/v3/DeploymentPresenter.server.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ export class DeploymentPresenter {
7272
id: true,
7373
shortCode: true,
7474
version: true,
75+
runtime: true,
76+
runtimeVersion: true,
7577
errorData: true,
7678
imageReference: true,
7779
imagePlatform: true,
@@ -157,6 +159,8 @@ export class DeploymentPresenter {
157159
deployedBy: deployment.triggeredBy,
158160
sdkVersion: deployment.worker?.sdkVersion,
159161
cliVersion: deployment.worker?.cliVersion,
162+
runtime: deployment.runtime,
163+
runtimeVersion: deployment.runtimeVersion,
160164
imageReference: deployment.imageReference,
161165
imagePlatform: deployment.imagePlatform,
162166
externalBuildData:

0 commit comments

Comments
 (0)