Skip to content

Commit 8d0a3d8

Browse files
committed
Added a comment to explain the return on null pid
1 parent e1525a8 commit 8d0a3d8

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

app/code/Magento/Deploy/Process/Queue.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,9 @@ private function isDeployed(Package $package)
336336
if ($this->isCanBeParalleled()) {
337337
if ($package->getState() === null) {
338338
$pid = $this->getPid($package);
339+
340+
// When $pid comes back as null the child process for this package has not yet started; prevents both
341+
// hanging until timeout expires (which was behaviour in 2.2.x) and the type error from strict_types
339342
if ($pid === null) {
340343
return false;
341344
}

0 commit comments

Comments
 (0)