Skip to content

Commit 53072e0

Browse files
Merge pull request magento#1487 from magento-engcom/develop-prs
[EngCom] Public Pull Requests - MAGETWO-72486: response condition order changes. magento#10826 - MAGETWO-72465: Enable livereload for watch: commands magento#10836 - MAGETWO-72428: Close PayPal popup window in case of rejected request magento#10820
2 parents 3797563 + b7ad7b2 commit 53072e0

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

app/code/Magento/Customer/view/frontend/web/js/action/login.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ define([
3838
});
3939
customerData.invalidate(['customer']);
4040

41-
if (redirectUrl) {
42-
window.location.href = redirectUrl;
43-
} else if (response.redirectUrl) {
41+
if (response.redirectUrl) {
4442
window.location.href = response.redirectUrl;
43+
} else if (redirectUrl) {
44+
window.location.href = redirectUrl;
4545
} else {
4646
location.reload();
4747
}

app/code/Magento/Paypal/view/frontend/web/js/view/payment/method-renderer/in-context/checkout-express.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ define(
7878
$('body').trigger('processStop');
7979
customerData.invalidate(['cart']);
8080
});
81-
}.bind(this));
81+
}.bind(this)).fail(function () {
82+
paypalExpressCheckout.checkout.closeFlow();
83+
});
8284
}
8385
}
8486
}

dev/tests/unit/phpunit.xml.dist

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
>
1515
<testsuite name="Magento Unit Tests">
1616
<directory suffix="Test.php">../../../app/code/*/*/Test/Unit</directory>
17-
<directory suffix="Test.php">../../../dev/tools/*/*/Test/Unit</directory>
18-
<directory suffix="Test.php">../../../dev/tools/*/*/*/Test/Unit</directory>
1917
<directory suffix="Test.php">../../../lib/internal/*/*/Test/Unit</directory>
2018
<directory suffix="Test.php">../../../lib/internal/*/*/*/Test/Unit</directory>
2119
<directory suffix="Test.php">../../../setup/src/*/*/Test/Unit</directory>

dev/tools/grunt/configs/watch.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ var themeOptions = {};
1313

1414
_.each(themes, function(theme, name) {
1515
themeOptions[name] = {
16+
'options': {
17+
livereload: true
18+
},
1619
'files': [
1720
'<%= combo.autopath(\''+name+'\', path.pub) %>/**/*.less'
1821
],

0 commit comments

Comments
 (0)