Make Swift library evolution configurable and turn it off by default.

Author: FilipDolnik

SKIE/acceptance-tests

@@ -7,6 +7,7 @@ enum class SkieConfigurationFlag {
     Feature_CoroutinesInterop,
     Feature_DefaultArgumentsInExternalLibraries,
 
+    Build_SwiftLibraryEvolution,
     Build_ParallelSwiftCompilation,
     Build_ParallelSkieCompilation,
     Build_ConcurrentSkieCompilation,

SKIE/common/configuration/declaration/src/commonMain/kotlin/co/touchlab/skie/configuration/SkieConfigurationFlag.kt

@@ -29,6 +29,7 @@ class CompileSwiftPhase(
     private val moduleDirectory = skieBuildDirectory.swiftCompiler.module
 
     private val isDebug = konanConfig.debug
+    private val isLibraryEvolutionEnabled = SkieConfigurationFlag.Build_SwiftLibraryEvolution in skieConfiguration.enabledConfigurationFlags
 
     context(SirPhase.Context)
     override suspend fun execute() {
@@ -48,6 +49,8 @@ class CompileSwiftPhase(
 
         copySwiftModuleFiles()
 
+        copySwiftLibraryEvolutionFiles()
+
         addSwiftSubmoduleToModuleMap()
 
         addSwiftSpecificLinkerArgs()
@@ -97,15 +100,17 @@ class CompileSwiftPhase(
             +cacheableKotlinFramework.parentDir.absolutePath
             +"-F"
             +skieBuildDirectory.swiftCompiler.fakeObjCFrameworks.directory.absolutePath
-            +"-enable-library-evolution"
             +"-verify-emitted-module-interface"
             +"-emit-module"
             +"-emit-module-path"
             +swiftFrameworkHeader.swiftModule
-            +"-emit-module-interface-path"
-            +swiftFrameworkHeader.swiftInterface
-            +"-emit-private-module-interface-path"
-            +swiftFrameworkHeader.privateSwiftInterface
+            if (isLibraryEvolutionEnabled) {
+                +"-enable-library-evolution"
+                +"-emit-module-interface-path"
+                +swiftFrameworkHeader.swiftInterface
+                +"-emit-private-module-interface-path"
+                +swiftFrameworkHeader.privateSwiftInterface
+            }
             +"-emit-objc-header"
             +"-emit-objc-header-path"
             +swiftFrameworkHeader.swiftHeader
@@ -168,8 +173,6 @@ class CompileSwiftPhase(
     private fun copySwiftModuleFiles() {
         val copyFiles = mapOf(
             swiftFrameworkHeader.swiftModule to framework.swiftModule(targetTriple),
-            swiftFrameworkHeader.swiftInterface to framework.swiftInterface(targetTriple),
-            swiftFrameworkHeader.privateSwiftInterface to framework.privateSwiftInterface(targetTriple),
             swiftFrameworkHeader.swiftDoc to framework.swiftDoc(targetTriple),
             swiftFrameworkHeader.abiJson to framework.abiJson(targetTriple),
             swiftFrameworkHeader.swiftSourceInfo to framework.swiftSourceInfo(targetTriple),
@@ -181,6 +184,16 @@ class CompileSwiftPhase(
         }
     }
 
+    private fun copySwiftLibraryEvolutionFiles() {
+        if (isLibraryEvolutionEnabled) {
+            swiftFrameworkHeader.swiftInterface.copyTo(framework.swiftInterface(targetTriple), overwrite = true)
+            swiftFrameworkHeader.privateSwiftInterface.copyTo(framework.privateSwiftInterface(targetTriple), overwrite = true)
+        } else {
+            framework.swiftInterface(targetTriple).delete()
+            framework.privateSwiftInterface(targetTriple).delete()
+        }
+    }
+
     private fun addSwiftSubmoduleToModuleMap() {
         framework.modulemapFile.appendText(
             """

SKIE/compiler/kotlin-plugin/src/kgp_common/kotlin/co/touchlab/skie/phases/swift/CompileSwiftPhase.kt

@@ -8,12 +8,14 @@ import javax.inject.Inject
 
 abstract class SkieBuildConfiguration @Inject constructor(objects: ObjectFactory) {
 
+    val enableSwiftLibraryEvolution: Property<Boolean> = objects.property(Boolean::class.java).convention(false)
     val enableParallelSwiftCompilation: Property<Boolean> = objects.property(Boolean::class.java).convention(true)
     val enableConcurrentSkieCompilation: Property<Boolean> = objects.property(Boolean::class.java).convention(true)
     val enableParallelSkieCompilation: Property<Boolean> = objects.property(Boolean::class.java).convention(true)
 
     internal fun buildConfigurationFlags(): Set<SkieConfigurationFlag> =
         setOfNotNull(
+            SkieConfigurationFlag.Build_SwiftLibraryEvolution takeIf enableSwiftLibraryEvolution,
             SkieConfigurationFlag.Build_ParallelSwiftCompilation takeIf enableParallelSwiftCompilation,
             SkieConfigurationFlag.Build_ConcurrentSkieCompilation takeIf enableConcurrentSkieCompilation,
             SkieConfigurationFlag.Build_ParallelSkieCompilation takeIf enableParallelSkieCompilation,