Skip to content
This repository was archived by the owner on Oct 19, 2021. It is now read-only.

Fix plugin id in README.md #2

Open
alekseychugaev opened this issue Mar 20, 2020 · 4 comments · May be fixed by #25
Open

Fix plugin id in README.md #2

alekseychugaev opened this issue Mar 20, 2020 · 4 comments · May be fixed by #25

Comments

@alekseychugaev
Copy link

Invalid plugin id in example, correct id should be

plugins {
  id("co.touchlab.native.cocoapods")
}
@alekseychugaev
Copy link
Author

Also, before I could make it work for an existing project, I had to update podspec file as in here https://github.com/touchlab/KaMPKit/pull/76/files#diff-65c1831fff220b3ed58c09539ba5f0ec:
Screen Shot 2020-03-20 at 23 31 50
and reinstall pod.

Perhaps it's worth including some of it in README.md

@shadowsheep1
Copy link

shadowsheep1 commented May 15, 2020

And here another issue in README.md

isStatic = false

must be

framework {
            isStatic = false
}

/cc @ben-whit-ley

@shadowsheep1
Copy link

@alekseychugaev you don't need to modify the podspec file, you could generate it with the gradle task provided you set

framework {
            isStatic = false
}

@russhwolf
Copy link
Contributor

Acknowledging yes we could use a docs refresh here.

@russhwolf russhwolf linked a pull request Feb 25, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants