chore: bump davinci-syntax version to 20 (#159)

* chore: bump davinci-syntax version to 20

* chore: update eslint

Author: dmaklygin

.changeset/wet-moose-whisper.md

@@ -0,0 +1,7 @@
+---
+'davinci-github-actions': patch
+---
+
+---
+
+- bump davinci-syntax version to 20

.eslintrc

@@ -1,5 +1,5 @@
 {
-  "extends": "./node_modules/@toptal/davinci-syntax/src/configs/.eslintrc",
+  "extends": "./node_modules/@toptal/davinci-syntax/src/configs/.eslintrc.cjs",
   "rules": {
     "id-length": "off",
     "@typescript-eslint/no-non-null-assertion": "off",

.prettierrc.js

@@ -1,3 +1,3 @@
 module.exports = {
-  ...require('@toptal/davinci-syntax/src/configs/.prettierrc.js')
+  ...require('@toptal/davinci-syntax/src/configs/.prettierrc.cjs')
 }

_scripts/documentation/generate.ts

@@ -2,12 +2,12 @@ import fs from 'fs'
 import { remark } from 'remark'
 import { gfmTableToMarkdown } from 'mdast-util-gfm-table'
 
-import { YMLConfiguration } from './types'
+import type { YMLConfiguration } from './types'
 import remarkGithubActionReadme from './remark-github-action-readme'
 import {
   getActionContent,
   getReadmeSourceContent,
-  updateReadmeFile
+  updateReadmeFile,
 } from './utils/files'
 import { getYMLConfiguration } from './utils/yaml'
 

_scripts/documentation/remark-github-action-readme.ts

@@ -1,18 +1,19 @@
-import { Plugin } from 'unified'
-import { headingRange, Node } from 'mdast-util-heading-range'
-import { Heading } from 'mdast'
+import type { Plugin } from 'unified'
+import type { Node } from 'mdast-util-heading-range'
+import { headingRange } from 'mdast-util-heading-range'
+import type { Heading } from 'mdast'
 import {
   heading,
   inlineCode,
   paragraph,
   table,
   tableCell,
   tableRow,
-  text
+  text,
 } from 'mdast-builder'
 import { fromMarkdown } from 'mdast-util-from-markdown'
 
-import { YMLConfiguration } from './types'
+import type { YMLConfiguration } from './types'
 import { parseActionDescription, parseInputDescription } from './utils/yaml'
 
 const buildTable = (headers: string[], rows: any[][]) => {
@@ -28,7 +29,7 @@ const buildTable = (headers: string[], rows: any[][]) => {
             )
           )
         )
-      )
+      ),
     ]
   )
 }
@@ -51,9 +52,9 @@ const injectTableToSection = (
       ? paragraph(text('Not specified'))
       : paragraph([
           paragraph(text(options.subtitle || '')),
-          buildTable(tableHeaders, rows)
+          buildTable(tableHeaders, rows),
         ]),
-    end
+    end,
   ])
 }
 
@@ -82,7 +83,7 @@ const remarkGithubActionReadme: Plugin<
         heading(2, [text(yamlContent.name)]),
         paragraph(fromMarkdown(description)),
         ...filteredNodes,
-        end
+        end,
       ]
     })
 
@@ -96,7 +97,7 @@ const remarkGithubActionReadme: Plugin<
           type || 'string',
           input.required ? '✅' : '',
           input.default || '',
-          description
+          description,
         ]
       }
     )
@@ -106,7 +107,7 @@ const remarkGithubActionReadme: Plugin<
       ['name', 'type', 'required', 'default', 'description'],
       inputs,
       {
-        subtitle: 'The list of arguments, that are used in GH Action:\n\n'
+        subtitle: 'The list of arguments, that are used in GH Action:\n\n',
       }
     )
 
@@ -124,19 +125,19 @@ const remarkGithubActionReadme: Plugin<
       ['name', 'type', 'description'],
       outputs,
       {
-        subtitle: 'The list of variables, that are returned by GH Action:\n\n'
+        subtitle: 'The list of variables, that are returned by GH Action:\n\n',
       }
     )
 
     // inject `ENV Variables` table
     const env = Object.keys(envInputs || {}).map(envKey => [
       inlineCode(envKey) as Node,
-      envInputs![envKey]
+      envInputs![envKey],
     ])
     injectTableToSection(tree, 'ENV Variables', ['name', 'description'], env, {
       subtitle:
         'All ENV Variables, defined in a GH Workflow are also passed to a GH Action. It means, the might be reused as is.\n' +
-        'This is a list of ENV Variables that are used in GH Action:\n\n'
+        'This is a list of ENV Variables that are used in GH Action:\n\n',
     })
   }
 }

_scripts/documentation/utils/files.ts

@@ -35,6 +35,6 @@ export const updateReadmeFile = (
   content: string
 ) => {
   fs.writeFileSync(getActionReadmeFilePath(rootDir, folder), content, {
-    encoding: 'utf8'
+    encoding: 'utf8',
   })
 }

_scripts/documentation/utils/yaml.test.ts

@@ -3,12 +3,12 @@ import yaml from 'js-yaml'
 import {
   getYMLConfiguration,
   parseActionDescription,
-  parseInputDescription
+  parseInputDescription,
 } from './yaml'
-import { YMLConfiguration } from '../types'
+import type { YMLConfiguration } from '../types'
 
 jest.mock('js-yaml', () => ({
-  load: jest.fn()
+  load: jest.fn(),
 }))
 
 const mockedLoad = yaml.load as jest.Mock<YMLConfiguration>
@@ -28,7 +28,7 @@ describe('yaml util', () => {
         name: '__NAME__',
         description: '__DESC__',
         inputs: {},
-        outputs: {}
+        outputs: {},
       }
       mockedLoad.mockReturnValueOnce(content)
 
@@ -45,12 +45,12 @@ describe('yaml util', () => {
       content = {
         envInputs: {
           ENV_VARIABLE1: 'description1',
-          ENV_VARIABLE2: 'description2'
+          ENV_VARIABLE2: 'description2',
         },
         name: '__NAME__',
         description: '__DESC__',
         inputs: {},
-        outputs: {}
+        outputs: {},
       }
       mockedLoad.mockReturnValueOnce(content)
     })

_scripts/documentation/utils/yaml.ts

@@ -1,6 +1,6 @@
 import yaml from 'js-yaml'
 
-import { YMLConfiguration } from '../types'
+import type { YMLConfiguration } from '../types'
 
 export const getYMLConfiguration = (content: string): YMLConfiguration => {
   return yaml.load(content) as YMLConfiguration
@@ -12,7 +12,7 @@ export const parseActionDescription = (information: string) => {
 
   return {
     description,
-    envInputs: envInputs ? envInputs.envInputs : null
+    envInputs: envInputs ? envInputs.envInputs : null,
   }
 }
 
@@ -21,6 +21,6 @@ export const parseInputDescription = (information: string) => {
 
   return {
     description,
-    type
+    type,
   }
 }

create-matrix/dist/index.js

@@ -2757,7 +2757,7 @@
       /***/
     },
 
-    /***/ 7740: /***/ (
+    /***/ 1585: /***/ (
       module,
       __unused_webpack_exports,
       __nccwpck_require__
@@ -2819,7 +2819,7 @@
       /***/
     },
 
-    /***/ 1336: /***/ (
+    /***/ 1766: /***/ (
       module,
       __unused_webpack_exports,
       __nccwpck_require__
@@ -2829,7 +2829,7 @@
       const { constants: BufferConstants } = __nccwpck_require__(4300)
       const stream = __nccwpck_require__(2781)
       const { promisify } = __nccwpck_require__(3837)
-      const bufferStream = __nccwpck_require__(7740)
+      const bufferStream = __nccwpck_require__(1585)
 
       const streamPipelinePromisified = promisify(stream.pipeline)
 
@@ -5574,8 +5574,8 @@
         return isDuplexStream(stream) && typeof stream._transform === 'function'
       }
 
-      // EXTERNAL MODULE: ./node_modules/execa/node_modules/get-stream/index.js
-      var get_stream = __nccwpck_require__(1336)
+      // EXTERNAL MODULE: ./node_modules/get-stream/index.js
+      var get_stream = __nccwpck_require__(1766)
       // EXTERNAL MODULE: ./node_modules/merge-stream/index.js
       var merge_stream = __nccwpck_require__(2621) // CONCATENATED MODULE: ./node_modules/execa/lib/stream.js
       // `input` option

create-matrix/index.js

@@ -4,11 +4,7 @@ const execa = require('execa').execa
 const getWorkspaces = async () => {
   const { exitCode, stdout } = await execa(
     'yarn',
-    [
-      'workspaces',
-      '--no-default-rc',
-      'info'
-    ],
+    ['workspaces', '--no-default-rc', 'info'],
     {
       reject: false,
     }
@@ -35,7 +31,9 @@ const run = async () => {
 
     core.setOutput('is-monorepo', isMonorepo)
 
-    let groups = workspaces ? Object.entries(workspaces) : [['default', { location: '.' }]]
+    let groups = workspaces
+      ? Object.entries(workspaces)
+      : [['default', { location: '.' }]]
 
     // custom matrix
     if (parallelMatrixInput) {
@@ -47,7 +45,7 @@ const run = async () => {
 
       groups = parallelMatrix.map(({ pkg, location, parallelGroups }) => [
         pkg,
-        { location, parallelGroups }
+        { location, parallelGroups },
       ])
     }
 
@@ -56,20 +54,23 @@ const run = async () => {
     const matrix = groups.reduce((acc, [pkg, { location, parallelGroups }]) => {
       const groupsTotal = parallelGroups || parallelGroupsInput
 
-      Array(groupsTotal).fill().forEach((_, index) => acc.push({
-        pkg,
-        location,
-        index,
-        total: groupsTotal,
-      }))
+      Array(groupsTotal)
+        .fill()
+        .forEach((_, index) =>
+          acc.push({
+            pkg,
+            location,
+            index,
+            total: groupsTotal,
+          })
+        )
 
       return acc
     }, [])
 
     core.setOutput('matrix', matrix)
 
     console.log('Done.')
-
   } catch (error) {
     core.setFailed(error.message)
   }

package.json

@@ -19,13 +19,13 @@
     "@actions/core": "^1.10.0",
     "@actions/github": "^5.1.1",
     "@changesets/changelog-github": "^0.4.8",
-    "@changesets/get-github-info": "^0.5.2",
     "@changesets/cli": "^2.26.0",
+    "@changesets/get-github-info": "^0.5.2",
     "@changesets/get-release-plan": "^3.0.16",
     "@changesets/git": "^1.5.0",
     "@toptal/browserslist-config": "^1.2.0",
     "@toptal/davinci-qa": "^12.1.0",
-    "@toptal/davinci-syntax": "^16.2.0",
+    "@toptal/davinci-syntax": "^20.0.6",
     "@types/js-yaml": "^4.0.5",
     "@types/marked": "^4.0.3",
     "@types/node": "^17.0.34",

report-affected-packages/diagram.js

@@ -23,7 +23,7 @@ const dependents = {}
  */
 const changedPackages = changedFiles
   .map(file => {
-    for (let packageName in info) {
+    for (const packageName in info) {
       if (file.startsWith(info[packageName].location)) {
         return packageName
       }
@@ -38,10 +38,10 @@ const highlights = [...new Set(changedPackages)]
 /**
  * Reverse the dependency tree from the info file for easy access to the dependent packages.
  */
-for (let packageName in info) {
+for (const packageName in info) {
   const package = info[packageName]
 
-  for (let dependency of package.workspaceDependencies) {
+  for (const dependency of package.workspaceDependencies) {
     dependents[dependency] = dependents[dependency] || []
     dependents[dependency].push(packageName)
   }
@@ -50,7 +50,7 @@ for (let packageName in info) {
 /**
  * Compile a list of packages directly or indirectly depending on the modified packages
  */
-function getDependents(packageName, ancestors = []) {
+const getDependents = (packageName, ancestors = []) => {
   const list = dependents[packageName] || []
 
   // Detect a cycle and bail
@@ -60,15 +60,19 @@ function getDependents(packageName, ancestors = []) {
 
   return [
     ...list,
-    ...list.map(dependentName => getDependents(dependentName, [...ancestors, packageName])).flat()
+    ...list
+      .map(dependentName =>
+        getDependents(dependentName, [...ancestors, packageName])
+      )
+      .flat(),
   ]
 }
 
 const includeList = [
   ...new Set([
     ...highlights,
-    ...highlights.map(packageName => getDependents(packageName)).flat()
-  ])
+    ...highlights.map(packageName => getDependents(packageName)).flat(),
+  ]),
 ]
 
 /**
@@ -114,14 +118,14 @@ const assignNode = (node, paths, content) => {
   assignNode(node.nodes[step], rest, content)
 }
 
-for (let package of packages) {
+for (const package of packages) {
   if (isIncluded(package)) {
     const paths = getGroup(package)
     const color = highlights.includes(package) ? ':::highlighted' : ''
     assignNode(root, paths, `    ${getId(package)}["${package}"]${color}`)
   }
 
-  for (let dependency of info[package].workspaceDependencies) {
+  for (const dependency of info[package].workspaceDependencies) {
     if (!isIncluded(dependency)) {
       continue
     }