More debug info for fixing challenges with default reviewer setups #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| let challengesUpdated = 0; | ||
|
|
||
| for (const challenge of challenges) { | ||
| const typeName = challenge.type?.name ?? 'Unknown type'; |
There was a problem hiding this comment.
[correctness]
The use of ?? 'Unknown type' and ?? 'Unknown track' for default values could lead to misleading log messages if the type or track is null but typeId or trackId is present. Consider checking for typeId and trackId before assigning default values to ensure accurate logging.
| if (!matchingPhases || !matchingPhases.length) { | ||
| console.warn( | ||
| `Challenge ${challenge.id} (${challenge.name}) does not have a phase matching "${defaultReviewer.phaseName}".`, | ||
| `Challenge ${challenge.id} (${challenge.name}) does not have a phase matching "${defaultReviewer.phaseName}". Available phases: ${challenge.phases |
There was a problem hiding this comment.
[correctness]
The console.warn statement concatenates phase names without checking if challenge.phases is empty, which could lead to an empty string being logged. Consider adding a check to ensure challenge.phases has elements before calling .map().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.