Skip to content

Skip tasks #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
Merged

Skip tasks #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions scripts/update-topgear-reviewers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@ async function fetchDefaultReviewers(

async function backfillChallengeReviewers() {
const defaultsCache = new Map<string, DefaultChallengeReviewer[]>();

const taskTypes = await prisma.challengeType.findMany({
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
Consider adding error handling for the prisma.challengeType.findMany call to handle cases where the database query might fail. This will improve the robustness of the script.

where: {
name: { equals: 'Task', mode: 'insensitive' },
},
select: { id: true },
});
const taskTypeIds = new Set(taskTypes.map((type) => type.id));

const challenges = await prisma.challenge.findMany({
where: {
status: ChallengeStatusEnum.ACTIVE,
Expand Down Expand Up @@ -148,6 +157,13 @@ async function backfillChallengeReviewers() {
continue;
}

if (taskTypeIds.has(challenge.typeId)) {
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 maintainability]
The console.log statement used for skipping Task type challenges could be replaced with a logging library or mechanism that allows for different log levels (e.g., debug, info, warn, error). This would provide more control over log output and improve maintainability.

console.log(
`Skipping challenge ${challenge.id} (${challenge.name}) because it is a Task type.`,
);
continue;
}

const defaultReviewers = await fetchDefaultReviewers(
challenge.typeId,
challenge.trackId,
Expand Down