Merge pull request #1357 from topcoder-platform/PS-469_update-walletadmin-ui-to-show-onholdadmin

PS-469 - update wallet admin ui to show the onhold admin dropdown

Author: vas3a

src/apps/wallet-admin/src/home/tabs/payments/PaymentsTab.tsx

@@ -217,7 +217,7 @@ const ListView: FC<ListViewProps> = (props: ListViewProps) => {
         if (updateObj.paymentStatus !== undefined) {
             if (updateObj.paymentStatus === 'Owed') {
                 paymentStatus = 'OWED'
-            } else if (updateObj.paymentStatus === 'On Hold') {
+            } else if (updateObj.paymentStatus === 'On Hold (Admin)') {
                 paymentStatus = 'ON_HOLD_ADMIN'
             } else if (updateObj.paymentStatus === 'Cancel') {
                 paymentStatus = 'CANCELLED'
@@ -267,24 +267,14 @@ const ListView: FC<ListViewProps> = (props: ListViewProps) => {
     }, [fetchWinnings])
 
     const onPaymentEditCallback = useCallback((payment: Winning) => {
-        let status = payment.status
-        if (status === 'On Hold (Admin)') {
-            status = 'On Hold'
-        } else if (['On Hold (Member)', 'On Hold (Tax Form)', 'On Hold (Payment Provider)'].indexOf(status) !== -1) {
-            status = 'Owed'
-        }
-
         setConfirmFlow({
             action: 'Save',
             callback: async () => {
                 updatePayment(payment.id)
             },
             content: (
                 <PaymentEditForm
-                    payment={{
-                        ...payment,
-                        status,
-                    }}
+                    payment={payment}
                     canSave={setIsConfirmFormValid}
                     onValueUpdated={handleValueUpdated}
                 />

src/apps/wallet-admin/src/lib/components/payment-edit/PaymentEdit.tsx

@@ -179,9 +179,16 @@ const PaymentEdit: React.FC<PaymentEditFormProps> = (props: PaymentEditFormProps
 
     const options = useCallback(() => {
         if (props.payment.status.toUpperCase() !== 'PAID') {
+            const isMemberHold = [
+                'On Hold (Member)',
+                'On Hold (Tax Form)',
+                'On Hold (Payment Provider)',
+            ].includes(props.payment.status)
+
             return [
+                ...(isMemberHold ? [{ label: props.payment.status, value: props.payment.status }] : []),
                 { label: 'Owed', value: 'Owed' },
-                { label: 'On Hold', value: 'On Hold' },
+                { label: 'On Hold (Admin)', value: 'On Hold (Admin)' },
                 { label: 'Cancel', value: 'Cancel' },
             ]
         }