Skip to content

Commit 23a62d1

Browse files
authored
Merge pull request #1373 from topcoder-platform/pm-2573
fix(PM-2573): show only submissions with passed screening score
2 parents d1cf5c6 + 6ae3ec0 commit 23a62d1

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

src/apps/review/src/lib/components/TableReview/TableReview.tsx

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -266,11 +266,21 @@ export const TableReview: FC<TableReviewProps> = (props: TableReviewProps) => {
266266
const minimumPassingScoreByScorecardId = useScorecardPassingScores(scorecardIds)
267267

268268
const aggregatedRows = useMemo<SubmissionRow[]>(() => {
269-
const rows = aggregatedSubmissionRows.map(aggregated => ({
270-
...(aggregated.submission ?? {}),
271-
...aggregated.submission,
272-
aggregated,
273-
})) as SubmissionRow[]
269+
const rows = aggregatedSubmissionRows
270+
.filter(aggregated => {
271+
const reviews = aggregated.reviews ?? []
272+
const myReviewDetail = reviews.find(review => {
273+
const resourceId = review.reviewInfo?.resourceId ?? review.resourceId
274+
return resourceId ? myReviewerResourceIds.has(resourceId) : false
275+
})
276+
277+
return !!myReviewDetail?.reviewId
278+
})
279+
.map(aggregated => ({
280+
...(aggregated.submission ?? {}),
281+
...aggregated.submission,
282+
aggregated,
283+
})) as SubmissionRow[]
274284

275285
if (!restrictToLatest) {
276286
return rows

0 commit comments

Comments
 (0)