Skip to content

Commit 9b4944d

Browse files
Merge branch 'qa' into PROD-1565_work-details
2 parents e384e02 + 5393081 commit 9b4944d

File tree

11 files changed

+51
-19
lines changed

11 files changed

+51
-19
lines changed

.circleci/config.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ workflows:
7575
filters:
7676
branches:
7777
only:
78-
- develop
78+
# - develop
79+
- qa
7980

8081
# Production builds are exectuted only on tagged commits to the
8182
# master branch.

src-ts/lib/svgs/index.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ import { ReactComponent as SocialIconLinkedin } from './social-linkedin-icon.svg
1010
import { ReactComponent as SocialIconTwitter } from './social-tw-icon.svg'
1111
import { ReactComponent as SocialIconYoutube } from './social-yt-icon.svg'
1212
import { ReactComponent as TooltipArrowIcon } from './tooltip-arrow.svg'
13-
import { ReactComponent as WorkTypeDataExplorationIcon } from './work-type-data-exploration.svg'
14-
import { ReactComponent as WorkTypeUnknownIcon } from './work-type-unknown.svg'
15-
import { ReactComponent as WorkTypeWebsiteDesignIcon } from './work-type-website-design.svg'
13+
import { ReactComponent as WorkTypeCategoryDataIcon } from './work-type-category-data.svg'
14+
import { ReactComponent as WorkTypeCategoryDesignIcon } from './work-type-category-design.svg'
15+
import { ReactComponent as WorkTypeCategoryUnknownIcon } from './work-type-category-unknown.svg'
1616

1717
export { ActiveTabTipIcon }
1818
export { IconOutline }
@@ -24,6 +24,6 @@ export { SocialIconLinkedin }
2424
export { SocialIconTwitter }
2525
export { SocialIconYoutube }
2626
export { TooltipArrowIcon }
27-
export { WorkTypeDataExplorationIcon }
28-
export { WorkTypeUnknownIcon }
29-
export { WorkTypeWebsiteDesignIcon }
27+
export { WorkTypeCategoryDataIcon }
28+
export { WorkTypeCategoryDesignIcon }
29+
export { WorkTypeCategoryUnknownIcon }

src-ts/lib/work-provider/work-functions/index.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
export {
22
type Work,
3+
workFactoryCreate,
4+
workFactoryGetStatus,
35
type WorkProgress,
46
type WorkProgressStep,
57
type WorkSolution,
68
WorkStatus,
79
WorkType,
8-
workFactoryCreate,
9-
workFactoryGetStatus,
10+
WorkTypeCategory,
1011
} from './work-factory'
1112
export {
1213
type Challenge,

src-ts/lib/work-provider/work-functions/work-factory/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ export * from './work-progress.model'
22
export * from './work-progress-step.model'
33
export * from './work-status.enum'
44
export * from './work-solution.model'
5+
export * from './work-type-category.enum'
56
export * from './work-type.enum'
67
export {
78
create as workFactoryCreate,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export enum WorkTypeCategory {
2+
data = 'Data',
3+
design = 'Design',
4+
dev = 'Development',
5+
qa = 'QA',
6+
unknown = '',
7+
}

src-ts/lib/work-provider/work-functions/work-factory/work.factory.ts

+19
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { ChallengeStatus } from './challenge-status.enum'
1515
import { WorkProgressStep } from './work-progress-step.model'
1616
import { WorkProgress } from './work-progress.model'
1717
import { WorkStatus } from './work-status.enum'
18+
import { WorkTypeCategory } from './work-type-category.enum'
1819
import { WorkType } from './work-type.enum'
1920
import { Work } from './work.model'
2021

@@ -38,6 +39,7 @@ export function create(challenge: Challenge): Work {
3839
submittedDate,
3940
title: challenge.name,
4041
type,
42+
typeCategory: getTypeCategory(type),
4143
}
4244
}
4345

@@ -231,3 +233,20 @@ function getType(challenge: Challenge): WorkType {
231233
const output: WorkType = !!workTypeKey ? WorkType[workTypeKey] : WorkType.unknown
232234
return output
233235
}
236+
237+
function getTypeCategory(type: WorkType): WorkTypeCategory {
238+
239+
switch (type) {
240+
241+
case WorkType.data:
242+
case WorkType.findData:
243+
return WorkTypeCategory.data
244+
245+
case WorkType.design:
246+
return WorkTypeCategory.design
247+
248+
// TOOD: other categories: qa and dev
249+
default:
250+
return WorkTypeCategory.unknown
251+
}
252+
}

src-ts/lib/work-provider/work-functions/work-factory/work.model.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { WorkProgress } from './work-progress.model'
22
import { WorkStatus } from './work-status.enum'
3+
import { WorkTypeCategory } from './work-type-category.enum'
34
import { WorkType } from './work-type.enum'
45

56
export interface Work {
@@ -16,4 +17,5 @@ export interface Work {
1617
submittedDate?: Date
1718
title: string
1819
type: WorkType
20+
typeCategory: WorkTypeCategory
1921
}

src-ts/tools/work/work-table/work-table-title-renderer/WorkTableTitleRenderer.tsx

+11-10
Original file line numberDiff line numberDiff line change
@@ -2,29 +2,30 @@ import { FC, SVGProps } from 'react'
22

33
import {
44
Work,
5-
WorkType,
6-
WorkTypeDataExplorationIcon,
7-
WorkTypeUnknownIcon,
8-
WorkTypeWebsiteDesignIcon,
5+
WorkTypeCategory,
6+
WorkTypeCategoryDataIcon,
7+
WorkTypeCategoryDesignIcon,
8+
WorkTypeCategoryUnknownIcon,
99
} from '../../../../lib'
1010

1111
import styles from './WorkTableTitleRenderer.module.scss'
1212

1313
function WorkTableTitleRenderer(data: Work): JSX.Element {
1414

1515
let Icon: FC<SVGProps<SVGSVGElement>>
16-
switch (data.type) {
16+
switch (data.typeCategory) {
1717

18-
case WorkType.design:
19-
Icon = WorkTypeWebsiteDesignIcon
18+
case WorkTypeCategory.data:
19+
Icon = WorkTypeCategoryDataIcon
2020
break
2121

22-
case WorkType.data:
23-
Icon = WorkTypeDataExplorationIcon
22+
case WorkTypeCategory.design:
23+
Icon = WorkTypeCategoryDesignIcon
2424
break
2525

26+
// TODO: qa and dev work categories
2627
default:
27-
Icon = WorkTypeUnknownIcon
28+
Icon = WorkTypeCategoryUnknownIcon
2829
break
2930
}
3031

0 commit comments

Comments
 (0)