Skip to content

Commit 76348b1

Browse files
committed
fix: lint issues
1 parent af3ddea commit 76348b1

File tree

6 files changed

+46
-29
lines changed

6 files changed

+46
-29
lines changed

src/shared/components/ReviewOpportunityDetailsPage/ApplyModal/index.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ class ApplyModal extends React.Component {
8282
onChange={() => toggleRole(position.roleId)}
8383
type="checkbox"
8484
/>
85+
{/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
8586
<label htmlFor={`${position.roleId}-checkbox`}>
8687
<input type="hidden" />
8788
<div styleName="tc-checkbox-label" />

src/shared/components/SubmissionManagement/DownloadArtifactsModal/index.jsx

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,21 @@ import React, { useEffect, useState } from 'react';
77

88
import { Modal } from 'topcoder-react-ui-kit';
99

10-
import style from './style.scss';
1110
import LoadingIndicator from 'components/LoadingIndicator';
12-
1311
import DownloadIcon from '../Icons/IconSquareDownload.svg';
12+
import style from './style.scss';
1413

1514
const theme = {
1615
container: style.modalContainer,
1716
overlay: style.modalOverlay,
1817
};
1918

20-
export const DownloadArtifactsModal = ({submissionId, onCancel, getSubmissionArtifacts, onDownloadArtifacts}) => {
19+
export default function DownloadArtifactsModal({
20+
submissionId,
21+
onCancel,
22+
getSubmissionArtifacts,
23+
onDownloadArtifacts,
24+
}) {
2125
const [artifacts, setArtifacts] = useState([]);
2226
const [loading, setLoading] = useState(false);
2327

@@ -32,7 +36,6 @@ export const DownloadArtifactsModal = ({submissionId, onCancel, getSubmissionArt
3236
getArtifacts();
3337
}, [submissionId]);
3438

35-
console.log(artifacts, 'artifacts');
3639
return (
3740
<div styleName="container">
3841
<Modal
@@ -46,20 +49,18 @@ export const DownloadArtifactsModal = ({submissionId, onCancel, getSubmissionArt
4649
<div>Action</div>
4750
</div>
4851
{
49-
!loading && artifacts.map((item) => {
50-
return (
51-
<div styleName="list-item">
52-
<div styleName="artifact-name">{item}</div>
53-
<button
54-
onClick={() => onDownloadArtifacts(item, submissionId)}
55-
type="button"
56-
styleName="icon-download"
57-
>
58-
<DownloadIcon />
59-
</button>
60-
</div>
61-
)
62-
})
52+
!loading && artifacts.map(item => (
53+
<div styleName="list-item">
54+
<div styleName="artifact-name">{item}</div>
55+
<button
56+
onClick={() => onDownloadArtifacts(item, submissionId)}
57+
type="button"
58+
styleName="icon-download"
59+
>
60+
<DownloadIcon />
61+
</button>
62+
</div>
63+
))
6364
}
6465

6566
{
@@ -70,7 +71,7 @@ export const DownloadArtifactsModal = ({submissionId, onCancel, getSubmissionArt
7071
</div>
7172
</Modal>
7273
</div>
73-
)
74+
);
7475
}
7576

7677
DownloadArtifactsModal.defaultProps = {

src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,8 @@ SubmissionManagement.defaultProps = {
209209
onDelete: _.noop,
210210
onShowDetails: _.noop,
211211
onDownload: _.noop,
212+
onDownloadArtifacts: _.noop,
213+
getSubmissionArtifacts: _.noop,
212214
onlineReviewUrl: '',
213215
helpPageUrl: '',
214216
loadingSubmissions: false,
@@ -224,6 +226,8 @@ SubmissionManagement.propTypes = {
224226
helpPageUrl: PT.string,
225227
onDownload: PT.func,
226228
onShowDetails: PT.func,
229+
onDownloadArtifacts: PT.func,
230+
getSubmissionArtifacts: PT.func,
227231
submissions: PT.arrayOf(PT.shape()),
228232
loadingSubmissions: PT.bool,
229233
challengeUrl: PT.string,

src/shared/components/SubmissionManagement/SubmissionsTable/index.jsx

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ import PT from 'prop-types';
2020
import shortid from 'shortid';
2121
import moment from 'moment';
2222
import { COMPETITION_TRACKS } from 'utils/tc';
23-
import Submission from '../Submission';
24-
import ScreeningDetails from '../ScreeningDetails';
2523
import { PrimaryButton } from 'topcoder-react-ui-kit';
24+
import ScreeningDetails from '../ScreeningDetails';
25+
import DownloadArtifactsModal from '../DownloadArtifactsModal';
26+
import Submission from '../Submission';
2627
import style from './styles.scss';
27-
import { DownloadArtifactsModal } from '../DownloadArtifactsModal';
2828

2929
export default function SubmissionsTable(props) {
3030
const [submissionId, setSubmissionId] = useState('');
@@ -44,6 +44,10 @@ export default function SubmissionsTable(props) {
4444
getSubmissionArtifacts,
4545
} = props;
4646

47+
const onOpenDownloadArtifactsModal = (id) => {
48+
setSubmissionId(id);
49+
};
50+
4751
const submissionsWithDetails = [];
4852
if (!submissionObjects || submissionObjects.length === 0) {
4953
submissionsWithDetails.push((
@@ -81,7 +85,14 @@ export default function SubmissionsTable(props) {
8185
{showDetails[subObject.id]
8286
&& (
8387
<td colSpan="6" styleName="dev-details">
84-
<PrimaryButton theme={{button: style['upload-artifact-btn']}} onClick={() => onOpenDownloadArtifactsModal(subObject.id)}>Download Artifacts</PrimaryButton>
88+
<PrimaryButton
89+
theme={{
90+
button: style['upload-artifact-btn'],
91+
}}
92+
onClick={() => onOpenDownloadArtifactsModal(subObject.id)}
93+
>
94+
Download Artifacts
95+
</PrimaryButton>
8596
<ScreeningDetails
8697
screeningObject={subObject.screening}
8798
helpPageUrl={helpPageUrl}
@@ -96,10 +107,6 @@ export default function SubmissionsTable(props) {
96107
});
97108
}
98109

99-
const onOpenDownloadArtifactsModal = (submissionId) => {
100-
setSubmissionId(submissionId);
101-
};
102-
103110
return (
104111
<div styleName="submissions-table">
105112
<table>
@@ -148,6 +155,8 @@ SubmissionsTable.defaultProps = {
148155
onDelete: _.noop,
149156
onDownload: _.noop,
150157
onShowDetails: _.noop,
158+
onDownloadArtifacts: _.noop,
159+
getSubmissionArtifacts: _.noop,
151160
onlineReviewUrl: '',
152161
helpPageUrl: '',
153162
};
@@ -162,6 +171,8 @@ SubmissionsTable.propTypes = {
162171
helpPageUrl: PT.string,
163172
onDownload: PT.func,
164173
onShowDetails: PT.func,
174+
onDownloadArtifacts: PT.func,
175+
getSubmissionArtifacts: PT.func,
165176
status: PT.string.isRequired,
166177
submissionPhaseStartDate: PT.string.isRequired,
167178
};

src/shared/components/SubmissionPage/Submit/index.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,7 @@ class Submit extends React.Component {
343343
aria-label="I understand and agree"
344344
onChange={e => setAgreed(e.target.checked)}
345345
/>
346+
{/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
346347
<label htmlFor="agree">
347348
<input type="hidden" />
348349
</label>

src/shared/containers/SubmissionManagement/index.jsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class SubmissionManagementPageContainer extends React.Component {
133133
'application/pdf': 'pdf',
134134
'image/jpeg': 'jpg',
135135
'image/png': 'png',
136-
'text/plain': 'txt'
136+
'text/plain': 'txt',
137137
};
138138
return mimeMap[mimeType] || 'zip';
139139
};
@@ -171,7 +171,6 @@ class SubmissionManagementPageContainer extends React.Component {
171171
});
172172
},
173173
getSubmissionArtifacts: (submissionId) => {
174-
console.log(authTokens, 'authTokens');
175174
const submissionsService = getService(authTokens.tokenV3);
176175
return submissionsService.getSubmissionArtifacts(submissionId);
177176
},

0 commit comments

Comments
 (0)