Skip to content

Commit c3c94d9

Browse files
Merge pull request #419 from Gauravseta/issue-416
issue 416 fix
2 parents 3a1b710 + a385bf9 commit c3c94d9

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/services/ChallengeService.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,7 +1055,8 @@ createChallenge.schema = {
10551055
reviewScorecardId: Joi.number().integer(),
10561056
isTask: Joi.boolean(),
10571057
useSchedulingAPI: Joi.boolean(),
1058-
pureV5Task: Joi.boolean()
1058+
pureV5Task: Joi.boolean(),
1059+
pureV5: Joi.boolean(),
10591060
}),
10601061
billing: Joi.object().keys({
10611062
billingAccountId: Joi.string(),
@@ -1323,6 +1324,9 @@ async function update (currentUser, challengeId, data, isFull) {
13231324
if (_.get(challenge, 'legacy.pureV5Task') && _.get(data, 'legacy.pureV5Task') && _.get(challenge, 'legacy.pureV5Task') !== _.get(data, 'legacy.pureV5Task')) {
13241325
throw new errors.ForbiddenError('Cannot change legacy.pureV5Task')
13251326
}
1327+
if (_.get(challenge, 'legacy.pureV5') && _.get(data, 'legacy.pureV5') && _.get(challenge, 'legacy.pureV5') !== _.get(data, 'legacy.pureV5')) {
1328+
throw new errors.ForbiddenError('Cannot change legacy.pureV5')
1329+
}
13261330

13271331
if (!_.isUndefined(challenge.legacy) && !_.isUndefined(data.legacy)) {
13281332
_.extend(challenge.legacy, data.legacy)
@@ -1771,7 +1775,8 @@ function sanitizeChallenge (challenge) {
17711775
'reviewScorecardId',
17721776
'isTask',
17731777
'useSchedulingAPI',
1774-
'pureV5Task'
1778+
'pureV5Task',
1779+
'pureV5'
17751780
])
17761781
}
17771782
if (challenge.billing) {
@@ -1837,7 +1842,8 @@ fullyUpdateChallenge.schema = {
18371842
reviewScorecardId: Joi.number().integer(),
18381843
isTask: Joi.boolean(),
18391844
useSchedulingAPI: Joi.boolean(),
1840-
pureV5Task: Joi.boolean()
1845+
pureV5Task: Joi.boolean(),
1846+
pureV5: Joi.boolean()
18411847
}).unknown(true),
18421848
billing: Joi.object().keys({
18431849
billingAccountId: Joi.string(),
@@ -1938,7 +1944,8 @@ partiallyUpdateChallenge.schema = {
19381944
forumId: Joi.number().integer(),
19391945
isTask: Joi.boolean(),
19401946
useSchedulingAPI: Joi.boolean(),
1941-
pureV5Task: Joi.boolean()
1947+
pureV5Task: Joi.boolean(),
1948+
pureV5: Joi.boolean()
19421949
}).unknown(true),
19431950
task: Joi.object().keys({
19441951
isTask: Joi.boolean().default(false),

0 commit comments

Comments
 (0)