Skip to content

Commit 92e077c

Browse files
toniarnoldtoniarnold
committed
Enable ContinuousIntegrationBuild
ContinuousIntegrationBuild seems defunct for webforms although reported MSBuild version is 17.4.1.60106 Centralize version.txt
1 parent 2e4d268 commit 92e077c

File tree

18 files changed

+81
-32
lines changed

18 files changed

+81
-32
lines changed

‎.github/workflows/libs-build-release.yml

-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,5 @@ jobs:
1111
release:
1212
needs: [build-core, build-webforms]
1313
uses: ./.github/workflows/libs-release.yml
14-
with:
15-
version: v0.2.1
1614
secrets:
1715
nuget_api_key: ${{ secrets.NUGET_API }}

‎.github/workflows/libs-release.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@ name: Release Libraries
22

33
on:
44
workflow_call:
5-
inputs:
6-
version:
7-
description: 'version tag name for the GitHub release'
8-
required: true
9-
type: string
105
secrets:
116
nuget_api_key:
127
description: 'nuget.org API key'
@@ -43,10 +38,15 @@ jobs:
4338
nuget-api-key: ${{ secrets.nuget_api_key }}
4439
- name: Publish NuGet packages to nuget.org
4540
run: nuget push -Source https://api.nuget.org/v3/index.json '${{ github.workspace }}\packages\*.nupkg' -SkipDuplicate
46-
- name: Create GitHub release ${{ inputs.version }}
41+
- name: Get version.txt
42+
shell: pwsh
43+
run: |
44+
$version = Get-Content ${{ github.workspace }}/nuget-info/version.txt
45+
echo "version=$version" >> $Env:GITHUB_ENV
46+
- name: Create GitHub release "v${{ env.version }}"
4747
uses: ncipollo/release-action@v1
4848
with:
4949
commit: master
50-
tag: ${{ inputs.version }}
50+
tag: "v${{ env.version }}"
5151
artifacts: "${{ github.workspace }}/packages/*.nupkg"
52-
bodyFile: "${{ github.workspace }}/.github/workflows/release.md"
52+
bodyFile: "${{ github.workspace }}/nuget-info/release-notes.txt"

‎.github/workflows/sandbox.yml

+4-10
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,7 @@ jobs:
88
try:
99
runs-on: windows-latest
1010
steps:
11-
- uses: actions/checkout@v3
12-
with:
13-
fetch-depth: 0
14-
- name: Get version.txt
15-
shell: pwsh
16-
run: |
17-
$version = Get-Content ${{ github.workspace }}/nuget-info/version.txt
18-
echo "version=$version" >> $GITHUB_ENV
19-
- name: Use version.txt
20-
run: echo ">${{ env.version }}<"
11+
- name: Add msbuild to PATH
12+
uses: microsoft/[email protected]
13+
- name: view version
14+
run: msbuild --version

‎nuget-info/release-notes.txt

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
* Add Source Link to all NuGet packages
2-
3-
* Fix race condition in the PersistentMainFactory due to the static cache
1+
* Fix issue #5 race condition in the PersistentMainFactory due to the static cache
42
by setting up an identifying Request Correlation Guid in _Host.cshtml according to
53
https://learn.microsoft.com/en-us/aspnet/core/blazor/security/server/additional-scenarios?view=aspnetcore-6.0#pass-tokens-to-a-blazor-server-app
64

75
* Deprecate the 'Component' accessor in favor of 'Cut' as in
86
https://learn.microsoft.com/en-us/aspnet/core/blazor/test
97

10-
* Set Selenium RequestTimeout default to 1 if not configured
8+
* Set Selenium RequestTimeout default to 1 sec if not configured
119

12-
* Blazor Test Navigate() and Refresh() as in Click() with numeric expectRenders
10+
* Blazor synchronization in Navigate() and Refresh() with the same argumenrs as Click() with numeric expectRenders
1311
instead of bool expectRender (breaking change)
1412

15-
* Support the ?clear=true GET argument to clear browser storage also for Blazor
13+
* Support the ?clear=true GET argument to clear browser storage also in Blazor
14+
15+
* Internet Explorer has been forcibly disabled by Microsoft, thus remove it from old tests.
1616

17-
* Internet Explorer has been forcibly disabled by Microsoft, thus removed it from old tests.
17+
* Add Source Link to the NuGet packages

‎src/apicaller.core/apicaller.core.nuget.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText("$(MSBuildProjectDirectory)/../../nuget-info/version.txt"))" />
11+
<PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText('$(MSBuildProjectDirectory)/../../nuget-info/version.txt'))" />
1212
</ItemGroup>
1313

1414
<ItemGroup>

‎src/apiservice.core/apiservice.core.nuget.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText("$(MSBuildProjectDirectory)/../../nuget-info/version.txt"))" />
11+
<PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText('$(MSBuildProjectDirectory)/../../nuget-info/version.txt'))" />
1212
</ItemGroup>
1313

1414
<!-- Don't require the SMC code generator Makefile project dependency when /p:noSmc=true -->

‎src/apitest.core/apitest.core.nuget.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText("$(MSBuildProjectDirectory)/../../nuget-info/version.txt"))" />
11+
<PackageReference Include="aspnettest.asplib.core" Version="$([System.IO.File]::ReadAllText('$(MSBuildProjectDirectory)/../../nuget-info/version.txt'))" />
1212
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="6.0.13" />
1313
<PackageReference Include="nunit" Version="3.13.3" />
1414
<PackageReference Include="NUnit3TestAdapter" Version="4.3.1">

‎src/asplib.blazor/asplib.blazor.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@
3030
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
3131
</PropertyGroup>
3232

33+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
34+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
35+
</PropertyGroup>
36+
3337
<ItemGroup>
3438
<SupportedPlatform Include="browser" />
3539
</ItemGroup>

‎src/asplib.core/asplib.core.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@
2929
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
3030
</PropertyGroup>
3131

32+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
33+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
34+
</PropertyGroup>
35+
3236
<ItemGroup>
3337
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="6.0.13" />
3438
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.13" />

‎src/asplib.webforms/asplib.webforms.csproj

+3
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@
3939
<IncludeSymbols>true</IncludeSymbols>
4040
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
4141
</PropertyGroup>
42+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
43+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
44+
</PropertyGroup>
4245
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
4346
<DebugSymbols>true</DebugSymbols>
4447
<DebugType>full</DebugType>

‎src/asplib.websharper/asplib.websharper.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@
2929
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
3030
</PropertyGroup>
3131

32+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
33+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
34+
</PropertyGroup>
35+
3236
<ItemGroup>
3337
<PackageReference Include="FSharp.Core" Version="6.0.7" />
3438
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">

‎src/asplib/asplib.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
1717
</PropertyGroup>
1818

19+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
20+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
21+
</PropertyGroup>
22+
1923
<ItemGroup>
2024
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
2125
<PrivateAssets>all</PrivateAssets>

‎src/iselenium.blazor/iselenium.blazor.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@
2929
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
3030
</PropertyGroup>
3131

32+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
33+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
34+
</PropertyGroup>
35+
3236
<ItemGroup>
3337
<SupportedPlatform Include="browser" />
3438
</ItemGroup>

‎src/iselenium.core/iselenium.core.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@
2929
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
3030
</PropertyGroup>
3131

32+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
33+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
34+
</PropertyGroup>
35+
3236
<ItemGroup>
3337
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
3438
<PrivateAssets>all</PrivateAssets>

‎src/iselenium.webforms/iselenium.webforms.csproj

+3
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@
4040
<IncludeSymbols>true</IncludeSymbols>
4141
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
4242
</PropertyGroup>
43+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
44+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
45+
</PropertyGroup>
4346
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
4447
<DebugSymbols>true</DebugSymbols>
4548
<DebugType>full</DebugType>

‎src/iselenium.websharper/iselenium.websharper.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
2929
</PropertyGroup>
3030

31+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
32+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
33+
</PropertyGroup>
34+
3135
<ItemGroup>
3236
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
3337
<PrivateAssets>all</PrivateAssets>

‎src/iselenium/iselenium.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
1717
</PropertyGroup>
1818

19+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
20+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
21+
</PropertyGroup>
22+
1923
<ItemGroup>
2024
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
2125
<PrivateAssets>all</PrivateAssets>

‎src/smc/smc.csproj

+21-2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,25 @@
1010

1111
<PropertyGroup>
1212
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
13-
</PropertyGroup>
14-
13+
</PropertyGroup>
14+
15+
<PropertyGroup>
16+
<!-- Source Link -->
17+
<PublishRepositoryUrl>true</PublishRepositoryUrl>
18+
<EmbedUntrackedSources>true</EmbedUntrackedSources>
19+
<IncludeSymbols>true</IncludeSymbols>
20+
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
21+
</PropertyGroup>
22+
23+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
24+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
25+
</PropertyGroup>
26+
27+
<ItemGroup>
28+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
29+
<PrivateAssets>all</PrivateAssets>
30+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
31+
</PackageReference>
32+
</ItemGroup>
33+
1534
</Project>

0 commit comments

Comments
 (0)