Skip to content

Conversation

@Shvandre
Copy link
Collaborator

@Shvandre Shvandre commented Oct 8, 2025

Closes #175

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore guidebook/debug.mdx techniques/gas.mdx 

Copy link
Collaborator

@skywardboundd skywardboundd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, can we add link to gas-utility file?

@Shvandre Shvandre marked this pull request as ready for review October 8, 2025 12:34
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Thanks for the update to the techniques docs. One high‑severity fix is needed before merge.

Findings (1)

High (1)

[HIGH] Missing frontmatter; page title rendered as body text

Location: https://github.com/tact-lang/mintlify-ton-docs/blob/b025787e285117b90fde9b9afa584fad875b4228/techniques/gas.mdx?plain=1#L1-L1

Description:
The YAML frontmatter was removed and replaced by an in‑body H2 ## title: "Estimate gas usage in TON contracts". The site expects page metadata (including the title) in frontmatter, with no visible in‑body H1; rendering the title: key as body text breaks metadata, disrupts heading hierarchy/TOC, and conflicts with the site’s title handling (see https://github.com/tact-lang/mintlify-ton-docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L282-L284).

Suggestion:
Restore YAML frontmatter and remove the in‑body “title” heading.

-## title: "Estimate gas usage in TON contracts"
+---
+title: "Estimate gas usage in TON contracts"
+---

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore guidebook/debug.mdx techniques/gas.mdx 

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore guidebook/debug.mdx standard/tokens/airdrop.mdx techniques/gas.mdx 

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore guidebook/debug.mdx standard/tokens/airdrop.mdx techniques/gas.mdx 

Copy link
Collaborator

@skywardboundd skywardboundd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pr!
Can we add may be more pics
I have several suggestions:

@Shvandre
Copy link
Collaborator Author

@skywardboundd sure, examples in ts will be added as part of #620

@github-actions
Copy link

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore guidebook/debug.mdx techniques/gas.mdx 

@Shvandre Shvandre dismissed stale reviews from Kaladin13 and skywardboundd via 71588c0 October 28, 2025 14:05
@verytactical
Copy link
Collaborator

/review

@novusnota
Copy link
Collaborator

novusnota commented Oct 29, 2025

Re-deployed: View deployment

I'm not sure if Mintlify's bot will pick up new updates here, because previously deployments were skipped for this branch and all other branches that were moved from the previous org/repo place.

@verytactical verytactical marked this pull request as draft October 29, 2025 16:32
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore contract-dev/gas.mdx 

@github-actions
Copy link

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore contract-dev/gas.mdx 

@Shvandre Shvandre marked this pull request as ready for review November 13, 2025 11:09
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates—I've left several suggestions in contract-dev/gas.mdx: please apply the inline suggestions.

@github-actions
Copy link

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore contract-dev/gas.mdx 

@anton-trunov anton-trunov merged commit e530cd2 into main Nov 13, 2025
5 checks passed
@anton-trunov anton-trunov deleted the gas-best-practices branch November 13, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Contract dev > Estimate gas usage in TON contracts]

8 participants