traces #603
traces #603
Conversation
aigerimu
requested review from
reveloper and
verytactical
and removed request for
verytactical
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/rpc/traces.mdx |
|
Thanks for the update to the traces docs under ecosystem/rpc. There’s one high‑severity link issue that needs a small fix before merge. Findings (1)High (1)[HIGH] Broken internal link to non-existent API referenceDescription: Suggestion: - To fetch transaction data, use the high-level [`GET /traces`](/api-reference/actions/get-traces) endpoint.
+ To fetch transaction data, use the high-level `GET /traces` endpoint.- To fetch transaction data, use the high-level [`GET /traces`](/api-reference/actions/get-traces) endpoint.
+ To fetch transaction data, use the high-level `GET /api/v3/traces` endpoint.- To fetch transaction data, use the high-level [`GET /traces`](/api-reference/actions/get-traces) endpoint.
+ To fetch transaction data, use the high-level Get Traces endpoint in [TON Center API v3](/ecosystem/rpc/ton-center-http-api-v-3). |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/rpc/traces.mdx |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/rpc/traces.mdx |
verytactical
left a comment
verytactical
left a comment
There was a problem hiding this comment.
- Wasn't this article meant to go into Ecosystem > Explorers?
- Probably
m4'andm4''were meant to bem4andm4', otherwise it's not consistent with the rest of them - After internal discussion it turned out we're not satisfied with how the image looks after all :) The spacing is off, and it doesn't really look professional. Could you please create an issue, so that we can ask designers to make a better one in the future?
This is another article from this issue
Will fix it. Thank you |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/rpc/traces.mdx |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/rpc/traces.mdx |
|
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/rpc/traces.mdx |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ecosystem/rpc/traces.mdx
Outdated
| <Aside | ||
| type={"note"} | ||
| > | ||
| Transactions may be triggered not only by external messages but also by [tick-tock](https://companyname-a7d5b98e.mintlify.app/ton/tblkch#4-2-4-kinds-of-transactions) events, commonly used within internal TON Blockchain contracts, such as governance or elector contracts. |
There was a problem hiding this comment.
[HIGH] Unofficial external link used instead of internal canonical page
This line links the term “tick-tock” to an unofficial Mintlify preview domain rather than the internal canonical whitepaper anchor. Using non-canonical external links risks link rot and inconsistency with the maintained internal spec. The repository contains a stable internal whitepaper path that should be used instead.
| Transactions may be triggered not only by external messages but also by [tick-tock](https://companyname-a7d5b98e.mintlify.app/ton/tblkch#4-2-4-kinds-of-transactions) events, commonly used within internal TON Blockchain contracts, such as governance or elector contracts. | |
| Transactions may be triggered not only by external messages but also by [tick-tock](/foundations/whitepapers/tblkch#4-2-4-kinds-of-transactions) events, commonly used within internal TON Blockchain contracts, such as governance or elector contracts. |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
|
/review |
|
Re-deployed: https://companyname-a7d5b98e-trace.mintlify.app/ |
ecosystem/rpc/traces.mdx
Outdated
|
|
||
| ### Tracing operations | ||
|
|
||
| Traces offer **a high-level** view of an operation, illustrating how multiple transactions and messages interact to produce the final result. Within the graph, related transactions are grouped into human-readable actions, _providing developers with both the low-level transaction flow and the corresponding higher-level operations_. |
There was a problem hiding this comment.
This doesn't make sense.
There is no such grouping inside of traces. Trace is merely a tree, generated completely autonomously, with no such feedback from a person possible.
|
migrated to foundations: #928 |
|
|
||
| **Example** | ||
|
|
||
| The NFT transfer illustrates a single operation that consists of **three transactions**, each triggered by messages. To learn how to read traces, follow [this article](/ecosystem/explorers/tonviewer#steps-to-analyze-an-operation). |
There was a problem hiding this comment.
[HIGH] Broken internal anchor to Tonviewer section
The in-doc link points to /ecosystem/explorers/tonviewer#steps-to-analyze-an-operation, but the target page’s actual heading is “Steps to read a trace,” which renders as the anchor #steps-to-read-a-trace. This makes the link 404/misdirect, which is release‑blocking. Evidence: ecosystem/explorers/tonviewer.mdx:55-56 shows the heading “### Steps to read a trace” (out-of-diff reference).
| The NFT transfer illustrates a single operation that consists of **three transactions**, each triggered by messages. To learn how to read traces, follow [this article](/ecosystem/explorers/tonviewer#steps-to-analyze-an-operation). | |
| The NFT transfer illustrates a single operation that consists of **three transactions**, each triggered by messages. To learn how to read traces, follow [this article](/ecosystem/explorers/tonviewer#steps-to-read-a-trace). |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
|
|
||
| ## Access using API | ||
|
|
||
| To fetch transaction data, use the [`GET /traces`](/ecosystem/api/toncenter/v3/actions-and-traces/list-actions-by-filters-tx-msg-trace) endpoint. |
There was a problem hiding this comment.
[HIGH] API endpoint label/link mismatch misleads readers
The text label says “GET /traces” but links to the Actions reference page, which defines openapi: get /api/v3/actions. The correct Traces reference (matching the label) is list-completed-traces-with-actions.mdx, which defines openapi: get /api/v3/traces. Evidence: ecosystem/api/toncenter/v3/actions-and-traces/list-actions-by-filters-tx-msg-trace.mdx:1-3 (actions) and ecosystem/api/toncenter/v3/actions-and-traces/list-completed-traces-with-actions.mdx:1-3 (traces).
| To fetch transaction data, use the [`GET /traces`](/ecosystem/api/toncenter/v3/actions-and-traces/list-actions-by-filters-tx-msg-trace) endpoint. | |
| To fetch transaction data, use the [`GET /traces`](/ecosystem/api/toncenter/v3/actions-and-traces/list-completed-traces-with-actions) endpoint. |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
verytactical
left a comment
verytactical
left a comment
There was a problem hiding this comment.
Please address AI review.
| /> | ||
| </div> | ||
|
|
||
| All messages and transactions in the trace are ordered by their [logical time (lt)](/foundations/whitepapers/tblkch#1-4-1-logical-time), reflecting their logical dependencies. The diagram shows transactions on independent accounts, each triggered by an incoming message, with `lt` values indicated for every message. |
There was a problem hiding this comment.
They're ordered by which messages sent which. Logical time is not used directly to order the trace.
|
|
||
| **Example** | ||
|
|
||
| The NFT transfer illustrates a single operation that consists of **three transactions**, each triggered by messages. To learn how to read traces, follow [this article](/ecosystem/explorers/tonviewer#steps-to-analyze-an-operation). |
There was a problem hiding this comment.
Why "three transactions" is so important that reader's attention has to be attracted during the skimming of the article text?
closes #302
closes #928