-
Notifications
You must be signed in to change notification settings - Fork 6
feat(ci): prohibit adhoc two-letter words in the spell checker #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
novusnota
wants to merge
14
commits into
main
Choose a base branch
from
closes-1132/ae
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
novusnota
commented
Nov 11, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
novusnota
commented
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No documentation issues detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1132. From the issue:
Well, I started specifying common typos, but then I discovered that the valid range is quite small in comparison, so I just banned
26*26*4two-letter words instead, excluding valid ones of course.The number comes from the following pseudo-formula:
[a-z] twice * 4, where 4 is the number of different spellings a word can have. For example, wordaacan be written as:aa,aA,Aa, andAA. Since the case sensitivity is turned on, each of those options is considered a separate word.However, I did not set the minimum checked word length to 2 characters in the config due to two reasons:
resources/dictionaries/custom.txtfile. Not nice.Overall, I'm not sure if banning 2k+ words is a good idea. We might want to only restrict the common letter-omission typos of 3-letter words and be done with it. That said, this might be better in the long run, as people would be more conscious of the spelling errors, and because such typos are tricky to spot with AI. The latter would assume "ar" to be "Augmented Reality" or Argentina's country code rather than a missed "e" in "are".