Skip to content

Commit 12c1023

Browse files
committed
Cleanup manpage container in build process
When running a `make manpages` the image `docker-manpage-dev` will be build and started to create the man pages. But the container will not be deleted afterwards. So I propose to start it with `docker run --rm ...`, otherwise we'll collect some trash. ``` $ docker ps -a CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES e3d9f721d862 docker-manpage-dev "man/generate.sh" 19 minutes ago Exited (0) 16 minutes ago berserk_jang 5738a23fb682 docker-manpage-dev "man/generate.sh" 9 hours ago Exited (0) 9 hours ago boring_bartik 15490b5e63f7 docker-manpage-dev "man/generate.sh" 10 hours ago Exited (0) 10 hours ago lonely_joliot ``` Signed-off-by: Dieter Reuter <[email protected]>
1 parent 59b0324 commit 12c1023

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ validate: build ## validate DCO, Seccomp profile generation, gofmt,\n./pkg/ isol
136136

137137
manpages: ## Generate man pages from go source and markdown
138138
docker build -t docker-manpage-dev -f "man/$(DOCKERFILE)" ./man
139-
docker run \
139+
docker run --rm \
140140
-v $(PWD):/go/src/github.com/docker/docker/ \
141141
docker-manpage-dev
142142

0 commit comments

Comments
 (0)