Make methods returning only noError return nothing (lib)

Author: MartinBriza

src/context.cc

@@ -2746,14 +2746,14 @@ error Context::Login(
     }
 }
 
-error Context::AsyncSignup(const std::string &email,
+void Context::AsyncSignup(const std::string &email,
                            const std::string &password,
                            const uint64_t country_id) {
     std::thread backgroundThread([&](std::string email, std::string password, uint64_t country_id) {
         return this->Signup(email, password, country_id);
     }, email, password, country_id);
     backgroundThread.detach();
-    return noError;
+    return;
 }
 
 error Context::Signup(
@@ -2782,13 +2782,13 @@ error Context::GoogleSignup(
     return Login(access_token, kGoogleAccessToken, true);
 }
 
-error Context::AsyncGoogleSignup(const std::string &access_token,
+void Context::AsyncGoogleSignup(const std::string &access_token,
                                  const uint64_t country_id) {
     std::thread backgroundThread([&](std::string access_token, uint64_t country_id) {
         return this->GoogleSignup(access_token, country_id);
     }, access_token, country_id);
     backgroundThread.detach();
-    return noError;
+    return;
 }
 
 error Context::AppleSignup(
@@ -2803,15 +2803,15 @@ error Context::AppleSignup(
     return Login(access_token, kAppleAccessToken, true);
 }
 
-error Context::AsyncAppleSignup(
+void Context::AsyncAppleSignup(
     const std::string &access_token,
     const uint64_t country_id,
     const std::string &full_name) {
     std::thread backgroundThread([&](std::string access_token, uint64_t country_id, std::string full_name) {
         return this->AppleSignup(access_token, country_id, full_name);
     }, access_token, country_id, full_name);
     backgroundThread.detach();
-    return noError;
+    return;
 }
 
 void Context::setUser(User *value, const bool logged_in) {
@@ -5751,12 +5751,8 @@ error Context::pushChanges(
             }
 
             // Update project id on time entries if needed
-            err = updateEntryProjects(
-                projects,
-                time_entries);
-            if (err != noError) {
-                return err;
-            }
+            updateEntryProjects(projects, time_entries);
+
             project_stopwatch.stop();
             ss << " | " << projects.size() << " projects in "
                << project_stopwatch.elapsed() / 1000 << " ms";
@@ -5897,7 +5893,7 @@ error Context::pushProjects(
     return err;
 }
 
-error Context::updateProjectClients(const std::vector<Client *> &clients,
+void Context::updateProjectClients(const std::vector<Client *> &clients,
                                     const std::vector<Project *> &projects) {
     for (auto it = projects.cbegin(); it != projects.cend(); ++it) {
         if (!(*it)->CID() && !(*it)->ClientGUID().empty()) {
@@ -5911,10 +5907,10 @@ error Context::updateProjectClients(const std::vector<Client *> &clients,
         }
     }
 
-    return noError;
+    return;
 }
 
-error Context::updateEntryProjects(const std::vector<Project *> &projects,
+void Context::updateEntryProjects(const std::vector<Project *> &projects,
                                    const std::vector<TimeEntry *> &time_entries) {
     for (std::vector<TimeEntry *>::const_iterator it =
         time_entries.begin();
@@ -5932,7 +5928,7 @@ error Context::updateEntryProjects(const std::vector<Project *> &projects,
         }
     }
 
-    return noError;
+    return;
 }
 
 error Context::pushEntries(
@@ -6776,10 +6772,10 @@ error Context::ToSAccept() {
     return noError;
 }
 
-error Context::ToggleEntriesGroup(std::string name) {
+void Context::ToggleEntriesGroup(std::string name) {
     entry_groups[name] = !entry_groups[name];
     OpenTimeEntryList();
-    return noError;
+    return;
 }
 
 error Context::AsyncPullCountries() {

src/context.h

@@ -304,7 +304,7 @@ class TOGGL_INTERNAL_EXPORT Context : public TimelineDatasource {
         const std::string &password,
         const bool isSignup = false);
 
-    error AsyncSignup(
+    void AsyncSignup(
         const std::string &email,
         const std::string &password,
         const uint64_t country_id);
@@ -318,7 +318,7 @@ class TOGGL_INTERNAL_EXPORT Context : public TimelineDatasource {
         const std::string &access_token,
         const uint64_t country_id);
 
-    error AsyncGoogleSignup(
+    void AsyncGoogleSignup(
         const std::string &access_token,
         const uint64_t country_id);
 
@@ -327,7 +327,7 @@ class TOGGL_INTERNAL_EXPORT Context : public TimelineDatasource {
         const uint64_t country_id,
         const std::string &full_name);
 
-    error AsyncAppleSignup(
+    void AsyncAppleSignup(
         const std::string &access_token,
         const uint64_t country_id,
         const std::string &full_name);
@@ -561,7 +561,7 @@ class TOGGL_INTERNAL_EXPORT Context : public TimelineDatasource {
         const int64_t promotion_type,
         const int64_t promotion_response);
 
-    error ToggleEntriesGroup(
+    void ToggleEntriesGroup(
         std::string name);
 
     error AsyncPullCountries();
@@ -729,10 +729,10 @@ class TOGGL_INTERNAL_EXPORT Context : public TimelineDatasource {
         const std::map<std::string, BaseModel *> &models,
         const std::vector<TimeEntry *> &time_entries,
         const std::string &api_token);
-    error updateProjectClients(
+    void updateProjectClients(
         const std::vector<Client *> &clients,
         const std::vector<Project *> &projects);
-    error updateEntryProjects(
+    void updateEntryProjects(
         const std::vector<Project *> &projects,
         const std::vector<TimeEntry *> &time_entries);
     error signup(

src/toggl_api.cc

@@ -464,8 +464,11 @@ bool_t toggl_signup_async(
     const char_t *email,
     const char_t *password,
     const uint64_t country_id) {
-    return toggl::noError == app(context)->AsyncSignup(to_string(email),
-            to_string(password), country_id);
+
+    app(context)->AsyncSignup(to_string(email),
+                              to_string(password),
+                              country_id);
+    return true;
 }
 
 bool_t toggl_google_signup(
@@ -480,8 +483,10 @@ bool_t toggl_google_signup_async(
     void *context,
     const char_t *access_token,
     const uint64_t country_id) {
-    return toggl::noError == app(context)->AsyncGoogleSignup(to_string(access_token),
-            country_id);
+
+    app(context)->AsyncGoogleSignup(to_string(access_token),
+                                    country_id);
+    return true;
 }
 
 bool_t toggl_apple_signup(
@@ -505,7 +510,10 @@ bool_t toggl_apple_signup_async(
     if (full_name) {
         name = to_string(full_name);
     }
-    return toggl::noError == app(context)->AsyncAppleSignup(to_string(access_token), country_id, name);
+    app(context)->AsyncAppleSignup(to_string(access_token),
+                                   country_id,
+                                   name);
+    return true;
 }
 
 bool_t toggl_google_login(