Implement a skeleton of DisplayError(Error) (lib)

Author: MartinBriza

src/context.cc

@@ -1061,6 +1061,41 @@ error Context::displayError(const error &err) {
     return UI()->DisplayError(err);
 }
 
+error Context::reportError(const Error &err) {
+    /* TODO
+    if ((err.find(kUnauthorizedError) != std::string::npos)) {
+        if (user_) {
+            setUser(nullptr);
+        }
+    }
+    */
+    /* TODO
+    if (err.find(kUnsupportedAppError) != std::string::npos) {
+        urls::SetImATeapot(true);
+    } else {
+        urls::SetImATeapot(false);
+    }
+    */
+    /* TODO
+    if (user_ && (err.find(kRequestIsNotPossible) != std::string::npos
+                  || (err.find(kForbiddenError) != std::string::npos))) {
+        error err = pullWorkspaces();
+        if (err != noError) {
+            // Check for missing WS error and
+            if (err.find(kMissingWS) != std::string::npos) {
+                overlay_visible_ = true;
+                UI()->DisplayWSError();
+                return noError;
+            }
+        }
+    }
+    */
+
+
+
+    return UI()->DisplayError(err);
+}
+
 int Context::nextSyncIntervalSeconds() const {
     int n = static_cast<int>(Random::next(kSyncIntervalRangeSeconds)) + kSyncIntervalRangeSeconds;
     logger.trace("Next autosync in ", n, " seconds");

src/context.h

@@ -671,6 +671,7 @@ class TOGGL_INTERNAL_EXPORT Context : public TimelineDatasource {
     void updateUI(const UIElements &elements);
 
     error displayError(const error &err);
+    error reportError(const Error &err);
 
     void scheduleSync();
 

src/gui.cc

@@ -180,6 +180,39 @@ error GUI::DisplayError(const error &err) {
     return err;
 }
 
+Error GUI::DisplayError(const Error &err) {
+    if (!err->IsError() || err->UserMessage().empty()) {
+        return NoError {};
+    }
+
+    logger.error(err);
+
+    if (err->Class() == "NetworkingError") {
+        logger.debug("You are offline (", err, ")");
+        /* TODO
+        auto nErr = err.promote<NetworkingError>();
+        if (nErr->Type() == NetworkingError::BACKEND_OFFLINE) {
+            DisplayOnlineState(kOnlineStateBackendDown);
+        }
+        else {
+            DisplayOnlineState(kOnlineStateNoNetwork);
+        }
+        */
+        return err;
+    }
+
+    // making error actionable is not necessary with Error
+    // determining if error is user error is not necessary as well
+
+    char_t *err_s = copy_string(err->UserMessage());
+    on_display_error_(err_s, true);
+    free(err_s);
+
+    lastErr = err->UserMessage();
+
+    return err;
+}
+
 error GUI::DisplayWSError() {
     on_display_overlay_(0);
     return noError;

src/gui.h

@@ -327,6 +327,7 @@ class TOGGL_INTERNAL_EXPORT GUI : public SyncStateMonitor {
     void DisplayApp();
 
     error DisplayError(const error &err);
+    Error DisplayError(const Error &err);
 
     // Overlay screen triggers
     error DisplayWSError();