fix(optimizer)!: simplify AND with static BOOLEAN type

Author: geooo109

sqlglot/optimizer/simplify.py

@@ -278,9 +278,9 @@ def _simplify_connectors(expression, left, right):
                 return exp.null()
             if always_true(left) and always_true(right):
                 return exp.true()
-            if always_true(left):
+            if is_true(left):
                 return right
-            if always_true(right):
+            if is_true(right):
                 return left
             return _simplify_comparison(expression, left, right)
         elif isinstance(expression, exp.Or):
@@ -1128,7 +1128,7 @@ def remove_where_true(expression):
 
 
 def always_true(expression):
-    return (isinstance(expression, exp.Boolean) and expression.this) or (
+    return is_true(expression) or (
         isinstance(expression, exp.Literal) and expression.is_number and not is_zero(expression)
     )
 
@@ -1149,6 +1149,10 @@ def is_false(a: exp.Expression) -> bool:
     return type(a) is exp.Boolean and not a.this
 
 
+def is_true(a: exp.Expression):
+    return type(a) is exp.Boolean and a.this
+
+
 def is_null(a: exp.Expression) -> bool:
     return type(a) is exp.Null
 

tests/fixtures/optimizer/simplify.sql

@@ -153,6 +153,12 @@ COALESCE(x, y) <> ALL (SELECT z FROM w);
 SELECT NOT (2 <> ALL (SELECT 2 UNION ALL SELECT 3));
 SELECT 2 = ANY(SELECT 2 UNION ALL SELECT 3);
 
+x AND TRUE;
+x;
+
+TRUE AND x;
+x;
+
 --------------------------------------
 -- Absorption
 --------------------------------------