Add latest changes from gitlab-org/gitlab@master

Author: GitLab Bot

.rubocop_todo/layout/line_continuation_spacing.yml

@@ -2,7 +2,6 @@
 # Cop supports --autocorrect.
 Layout/LineContinuationSpacing:
   Exclude:
-    - 'app/helpers/application_settings_helper.rb'
     - 'app/helpers/projects_helper.rb'
     - 'app/helpers/tags_helper.rb'
     - 'app/helpers/tree_helper.rb'

.rubocop_todo/rspec/multiple_memoized_helpers.yml

@@ -25,6 +25,7 @@ RSpec/MultipleMemoizedHelpers:
     - 'spec/requests/api/issues/issues_spec.rb'
     - 'spec/requests/api/issues/put_projects_issues_spec.rb'
     - 'spec/requests/api/maven_packages_spec.rb'
+    - 'spec/requests/api/todos_spec.rb'
     - 'spec/requests/api/users_spec.rb'
     - 'spec/services/boards/issues/list_service_spec.rb'
     - 'spec/services/labels/promote_service_spec.rb'

app/graphql/mutations/work_items/bulk_update.rb

@@ -33,10 +33,6 @@ class BulkUpdate < BaseMutation
         description: 'Number of work items that were successfully updated.'
 
       def ready?(**args)
-        if Feature.disabled?(:bulk_update_work_items_mutation, parent_for!(args[:parent_id]))
-          raise_resource_not_available_error!('`bulk_update_work_items_mutation` feature flag is disabled.')
-        end
-
         if args[:ids].size > MAX_WORK_ITEMS
           raise Gitlab::Graphql::Errors::ArgumentError,
             format(

app/helpers/application_settings_helper.rb

@@ -193,7 +193,7 @@ def repository_storages_options_json
   end
 
   def external_authorization_description
-    s_("ExternalAuthorization|Access to projects is validated on an external service "\
+    s_("ExternalAuthorization|Access to projects is validated on an external service " \
       "using their classification label.")
   end
 
@@ -202,39 +202,39 @@ def external_authorization_allow_token_help_text
   end
 
   def external_authorization_timeout_help_text
-    s_("ExternalAuthorization|Period GitLab waits for a response from the external "\
+    s_("ExternalAuthorization|Period GitLab waits for a response from the external " \
       "service. If there is no response, access is denied. Default: 0.5 seconds.")
   end
 
   def external_authorization_url_help_text
-    s_("ExternalAuthorization|URL to which the projects make authorization requests. If the URL is blank, cross-project "\
-      "features are available and can still specify classification "\
+    s_("ExternalAuthorization|URL to which the projects make authorization requests. If the URL is blank, cross-project " \
+      "features are available and can still specify classification " \
       "labels for projects.")
   end
 
   def external_authorization_client_certificate_help_text
-    s_("ExternalAuthorization|Certificate used to authenticate with the external authorization service. "\
+    s_("ExternalAuthorization|Certificate used to authenticate with the external authorization service. " \
       "If blank, the server certificate is validated when accessing over HTTPS.")
   end
 
   def external_authorization_client_key_help_text
-    s_("ExternalAuthorization|Private key of client authentication certificate. "\
+    s_("ExternalAuthorization|Private key of client authentication certificate. " \
       "Encrypted when stored.")
   end
 
   def external_authorization_client_pass_help_text
-    s_("ExternalAuthorization|Passphrase required to decrypt the private key. "\
+    s_("ExternalAuthorization|Passphrase required to decrypt the private key. " \
       "Encrypted when stored.")
   end
 
   def external_authorization_client_url_help_text
-    s_("ExternalAuthorization|Classification label to use when requesting authorization if no specific "\
+    s_("ExternalAuthorization|Classification label to use when requesting authorization if no specific " \
       "label is defined on the project.")
   end
 
   def sidekiq_job_limiter_mode_help_text
-    _("How the job limiter handles jobs exceeding the thresholds specified below. "\
-      "The 'track' mode only logs the jobs. The 'compress' mode compresses the jobs and "\
+    _("How the job limiter handles jobs exceeding the thresholds specified below. " \
+      "The 'track' mode only logs the jobs. The 'compress' mode compresses the jobs and " \
       "raises an exception if the compressed size exceeds the limit.")
   end
 

app/helpers/groups_helper.rb

@@ -86,14 +86,22 @@ def group_confirm_modal_data(group:, remove_form_id: nil, permanently_remove: fa
     }
   end
 
-  # Overridden in EE
   def remove_group_message(group, permanently_remove)
+    return permanently_delete_group_message(group) if permanently_remove
+    return permanently_delete_group_message(group) unless group.adjourned_deletion?
+    return permanently_delete_group_message(group) if group.marked_for_deletion?
+
+    date = permanent_deletion_date_formatted(Date.current)
+
+    _("The contents of this group, its subgroups and projects will be permanently deleted after %{deletion_adjourned_period} days on %{date}. After this point, your data cannot be recovered.") %
+      { date: date, deletion_adjourned_period: group.deletion_adjourned_period }
+  end
+
+  def permanently_delete_group_message(group)
     content = ''.html_safe
     content << content_tag(:span, format(_("You are about to delete the group %{group_name}."), group_name: group.name))
-
     additional_content = additional_removed_items(group)
     content << additional_content if additional_content.present?
-
     content << remove_group_warning
   end
 

app/mailers/emails/groups.rb

@@ -2,6 +2,8 @@
 
 module Emails
   module Groups
+    include NamespacesHelper
+
     def group_was_exported_email(current_user, group)
       group_email(current_user, group, _('Group was exported'))
     end
@@ -15,6 +17,18 @@ def group_email(current_user, group, subj, errors: nil)
       @errors = errors
       mail_with_locale(to: current_user.notification_email_for(@group), subject: subject(subj))
     end
+
+    def group_scheduled_for_deletion(recipient_id, group_id)
+      @group = ::Group.find(group_id)
+      @user = ::User.find(recipient_id)
+      @deletion_due_in_days = ::Gitlab::CurrentSettings.deletion_adjourned_period.days
+      @deletion_date = permanent_deletion_date_formatted(@group.marked_for_deletion_on, format: '%B %-d, %Y')
+
+      email_with_layout(
+        to: @user.email,
+        subject: subject('Group scheduled for deletion')
+      )
+    end
   end
 end
 

app/mailers/previews/notify_preview.rb

@@ -443,6 +443,17 @@ def project_scheduled_for_deletion
     end
   end
 
+  def group_scheduled_for_deletion
+    cleanup do
+      group.create_deletion_schedule!(
+        marked_for_deletion_on: Time.current,
+        deleting_user: user
+      )
+
+      ::Notify.group_scheduled_for_deletion(user.id, group.id).message
+    end
+  end
+
   private
 
   def project

app/services/groups/mark_for_deletion_service.rb

@@ -18,8 +18,12 @@ def execute(licensed: false)
 
     private
 
-    # overridden in EE
-    def send_group_deletion_notification; end
+    def send_group_deletion_notification
+      return unless ::Feature.enabled?(:group_deletion_notification_email, group) &&
+        group.adjourned_deletion?
+
+      ::NotificationService.new.group_scheduled_for_deletion(group)
+    end
 
     def create_deletion_schedule
       deletion_schedule = group.build_deletion_schedule(deletion_schedule_params)

app/services/notification_service.rb

@@ -801,6 +801,19 @@ def project_scheduled_for_deletion(project)
     end
   end
 
+  def group_scheduled_for_deletion(group)
+    return if group.emails_disabled?
+
+    recipients = group.members.active_without_invites_and_requests.owners.map(&:user)
+
+    recipients.each do |recipient|
+      mailer.group_scheduled_for_deletion(
+        recipient.id,
+        group.id
+      ).deliver_later
+    end
+  end
+
   protected
 
   def new_resource_email(target, current_user, method)

app/services/projects/mark_for_deletion_service.rb

@@ -29,9 +29,7 @@ def execute(licensed: false)
     private
 
     def send_project_deletion_notification
-      return unless ::Feature.enabled?(:project_deletion_notification_email, project) &&
-        project.adjourned_deletion? &&
-        project.marked_for_deletion?
+      return unless project.adjourned_deletion? && project.marked_for_deletion?
 
       ::NotificationService.new.project_scheduled_for_deletion(project)
     end

app/views/notify/group_scheduled_for_deletion.html.haml

@@ -0,0 +1,7 @@
+%p
+  = _('Hi %{username}!') % { username: sanitize_name(@user.name) }
+%p
+  = _('Your group %{group_name} has been marked for deletion and will be removed in %{days}.').html_safe % { group_name: link_to(@group.full_name, group_url(@group)), days: pluralize((@deletion_due_in_days / 1.day).to_i, _('day')) }
+%p
+  - link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: url_for(controller: 'groups', action: 'edit', id: @group.full_path, anchor: 'js-advanced-settings', only_path: false) }
+  = _('If this was a mistake, you can %{link_start}retain the group%{link_end} before %{deletion_date}.').html_safe % { link_start: link_start, link_end: '</a>'.html_safe, deletion_date: @deletion_date }

app/views/notify/group_scheduled_for_deletion.text.erb

@@ -0,0 +1,4 @@
+<%= _('Hi %{username}!') % { username: sanitize_name(@user.name) } %>
+<%= _('Your group %{group_name} has been marked for deletion and will be removed in %{days}.') % { group_name: @group.full_name, days: pluralize((@deletion_due_in_days / 1.day).to_i, _('day')) } %>
+<%= _('View your group: %{group_url}') % { group_url: group_url(@group) } %>
+<%= _('If this was a mistake, you can retain the group before %{deletion_date}: %{retention_url}') % { retention_url: url_for(controller: 'groups', action: 'edit', id: @group.full_path, anchor: 'js-advanced-settings', only_path: false), deletion_date: @deletion_date } %>

config/feature_flags/beta/bulk_update_work_items_mutation.yml

@@ -1,10 +1,9 @@
 ---
-name: project_deletion_notification_email
+name: group_deletion_notification_email
 feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/522883
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/184026
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/525979
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/185270
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/526037
 milestone: '17.11'
 group: group::authorization
 type: gitlab_com_derisk
 default_enabled: false
-

config/feature_flags/gitlab_com_derisk/project_deletion_notification_email.yml renamed to config/feature_flags/gitlab_com_derisk/group_deletion_notification_email.yml

@@ -0,0 +1,14 @@
+---
+table_name: work_item_custom_lifecycle_statuses
+classes:
+- WorkItems::Statuses::Custom::LifecycleStatus
+feature_categories:
+- team_planning
+description: Stores the association between custom lifecycles and statuses with position
+  information for ordering
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/186050
+milestone: '17.11'
+gitlab_schema: gitlab_main_cell
+sharding_key:
+  namespace_id: namespaces
+table_size: small

db/docs/work_item_custom_lifecycle_statuses.yml

@@ -0,0 +1,13 @@
+---
+table_name: work_item_custom_lifecycles
+classes:
+- WorkItems::Statuses::Custom::Lifecycle
+feature_categories:
+- team_planning
+description: Stores namespace-level custom lifecycle configurations with default statuses for open, closed, and duplicate states
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/186050
+milestone: '17.11'
+gitlab_schema: gitlab_main_cell
+sharding_key:
+  namespace_id: namespaces
+table_size: small

db/docs/work_item_custom_lifecycles.yml

@@ -0,0 +1,13 @@
+---
+table_name: work_item_custom_statuses
+classes:
+- WorkItems::Statuses::Custom::Status
+feature_categories:
+- team_planning
+description: Stores namespace-level custom status definitions for work items
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/186050
+milestone: '17.11'
+gitlab_schema: gitlab_main_cell
+sharding_key:
+  namespace_id: namespaces
+table_size: small

db/docs/work_item_custom_statuses.yml

@@ -0,0 +1,13 @@
+---
+table_name: work_item_type_custom_lifecycles
+classes:
+- WorkItems::TypeCustomLifecycle
+feature_categories:
+- team_planning
+description: Associates work item types with custom lifecycles within a namespace
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/186050
+milestone: '17.11'
+gitlab_schema: gitlab_main_cell
+sharding_key:
+  namespace_id: namespaces
+table_size: small

db/docs/work_item_type_custom_lifecycles.yml

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class CreateWorkItemCustomStatuses < Gitlab::Database::Migration[2.2]
+  milestone '17.11'
+
+  def change
+    # Factory: /ee/spec/factories/work_items/statuses/custom/statuses.rb
+    create_table :work_item_custom_statuses do |t| # rubocop:disable Migration/EnsureFactoryForTable -- reason above
+      t.bigint :namespace_id, null: false
+      t.timestamps_with_timezone null: false
+      t.integer :category, null: false, default: 1, limit: 1
+      t.text :name, null: false, limit: 255
+      t.text :description, limit: 255
+      t.text :color, null: false, limit: 7
+
+      t.index [:namespace_id, :name], unique: true
+    end
+  end
+end

db/migrate/20250408224050_create_work_item_custom_statuses.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class AddNamespaceFkToWorkItemCustomStatuses < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+  milestone '17.11'
+
+  def up
+    add_concurrent_foreign_key :work_item_custom_statuses, :namespaces,
+      column: :namespace_id, on_delete: :cascade
+  end
+
+  def down
+    remove_foreign_key_if_exists :work_item_custom_statuses, column: :namespace_id
+  end
+end

db/migrate/20250408230625_add_namespace_fk_to_work_item_custom_statuses.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+class CreateWorkItemCustomLifecycles < Gitlab::Database::Migration[2.2]
+  milestone '17.11'
+
+  def change
+    # Factory: /ee/spec/factories/work_items/statuses/custom/lifecycles.rb
+    create_table :work_item_custom_lifecycles do |t| # rubocop:disable Migration/EnsureFactoryForTable -- reason above
+      t.bigint :namespace_id, null: false
+      t.bigint :default_open_status_id, null: false,
+        index: { name: 'idx_wi_custom_lifecycles_on_open_status_id' }
+      t.bigint :default_closed_status_id, null: false,
+        index: { name: 'idx_wi_custom_lifecycles_on_closed_status_id' }
+      t.bigint :default_duplicate_status_id, null: false,
+        index: { name: 'idx_wi_custom_lifecycles_on_duplicate_status_id' }
+      t.timestamps_with_timezone null: false
+      t.text :name, null: false, limit: 255
+
+      t.index [:namespace_id, :name], unique: true
+    end
+  end
+end

db/migrate/20250408232202_create_work_item_custom_lifecycles.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class AddNamespaceFkToWorkItemCustomLifecycles < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+  milestone '17.11'
+
+  def up
+    add_concurrent_foreign_key :work_item_custom_lifecycles, :namespaces,
+      column: :namespace_id, on_delete: :cascade
+  end
+
+  def down
+    remove_foreign_key_if_exists :work_item_custom_lifecycles, column: :namespace_id
+  end
+end

db/migrate/20250408233737_add_namespace_fk_to_work_item_custom_lifecycles.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class AddOpenStatusFkToWorkItemCustomLifecycles < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+  milestone '17.11'
+
+  def up
+    add_concurrent_foreign_key :work_item_custom_lifecycles, :work_item_custom_statuses,
+      column: :default_open_status_id, on_delete: :cascade
+  end
+
+  def down
+    remove_foreign_key_if_exists :work_item_custom_lifecycles, column: :default_open_status_id
+  end
+end