Add latest changes from gitlab-org/gitlab@master

Author: GitLab Bot

GITLAB_KAS_VERSION

@@ -1 +1 @@
-fbc2185f0b97e3f9340bdfb365e2c8b9e24788da
+4cbdaf5d1ab9382c53e36fdbd2df26b6e5e6151f

app/assets/javascripts/lib/utils/datetime/date_format_utility.js

@@ -348,6 +348,18 @@ export const toISODateFormat = (date) => {
   return `${year}-${month}-${day}`;
 };
 
+/**
+ * Formats a date into an ISO string without milliseconds.
+ *
+ * @example
+ * // returns '2020-01-29T00:00:00Z'
+ * toISOStringWithoutMilliseconds(new Date('2020-01-29:00:00:00.123'))
+ *
+ * @param {Date} date The date to be formatted
+ * @returns {string} The ISO string without milliseconds.
+ */
+export const toISOStringWithoutMilliseconds = (date) => date.toISOString().replace(/\.\d+Z$/, 'Z');
+
 /**
  * This combines a date and a time and returns the computed Date's ISO string representation.
  *

app/assets/javascripts/todos/utils.js

@@ -1,12 +1,21 @@
+import { toISOStringWithoutMilliseconds } from '~/lib/utils/datetime_utility';
 import { updateGlobalTodoCount } from '~/sidebar/utils';
 import snoozeTodoMutation from './components/mutations/snooze_todo.mutation.graphql';
 
 export function snoozeTodo(apolloClient, todo, until) {
+  /**
+   * The API responds with the datetime in ISO 8601 format, without milliseconds. We therefore need
+   * to strip the milliseconds client-side as well so that the optimistic response matches the
+   * actual response. Mismatching date formats would invalidate the Apollo cache, in turn causing
+   * the todos to be re-fetched unexpectedly.
+   */
+  const snoozedUntilISOString = toISOStringWithoutMilliseconds(until);
+
   return apolloClient.mutate({
     mutation: snoozeTodoMutation,
     variables: {
       todoId: todo.id,
-      snoozeUntil: until,
+      snoozeUntil: snoozedUntilISOString,
     },
     optimisticResponse: () => {
       updateGlobalTodoCount(-1);
@@ -15,7 +24,7 @@ export function snoozeTodo(apolloClient, todo, until) {
         todoSnooze: {
           todo: {
             id: todo.id,
-            snoozedUntil: until,
+            snoozedUntil: snoozedUntilISOString,
             __typename: 'Todo',
           },
           errors: [],

data/deprecations/16-5-ci-job-token-limit-setting.yml

@@ -9,6 +9,7 @@
   reporter: jocelynjane  # (required) GitLab username of the person reporting the deprecation
   stage: govern  # (required) String value of the stage that the feature was created in. e.g., Growth
   issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/383084  # (required) Link to the deprecation issue in GitLab
+  check_impact: Use the [Authentication Log](../ci/jobs/ci_job_token.md#job-token-authentication-log) to verify which projects are authenticating with your project.
   impact: high  # Can be one of: [critical, high, medium, low]
   scope: project  # Can be one or a combination of: [instance, group, project]
   resolution_role: Maintainer  # Can be one of: [Admin, Owner, Maintainer, Developer]

data/deprecations/templates/example.yml

@@ -30,6 +30,7 @@
   reporter: exampleuser  # The GitLab username of the person reporting the change
   stage: stage
   issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/000000
+  check_impact:  # Link to a resource, like a tool, issue, docs section, or KB article, that has *concrete steps* for customers to assess the impact of this change.
   impact:  # Can be one of: [critical, high, medium, low]
   impact_details:  # Use the impact calculator and paste the full url in here. It will deep link to the configuration. https://gitlab-com.gitlab.io/gl-infra/breaking-change-impact-calculator/?
   impact_offering:  # The offering this impacts. Can be one or a combination of: [GitLab.com, Dedicated, self-managed]

doc/api/graphql/reference/_index.md

@@ -7679,6 +7679,35 @@ Input type: `LabelCreateInput`
 | <a id="mutationlabelcreateerrors"></a>`errors` | [`[String!]!`](#string) | Errors encountered during execution of the mutation. |
 | <a id="mutationlabelcreatelabel"></a>`label` | [`Label`](#label) | Label after mutation. |
 
+### `Mutation.ldapAdminRoleLinkCreate`
+
+Creates an instance-level custom admin role LDAP link.
+
+{{< details >}}
+**Introduced** in GitLab 17.11.
+**Status**: Experiment.
+{{< /details >}}
+
+Input type: `LdapAdminRoleLinkCreateInput`
+
+#### Arguments
+
+| Name | Type | Description |
+| ---- | ---- | ----------- |
+| <a id="mutationldapadminrolelinkcreateadminmemberroleid"></a>`adminMemberRoleId` | [`MemberRoleID!`](#memberroleid) | Global ID of the custom admin role to be assigned to a user. |
+| <a id="mutationldapadminrolelinkcreateclientmutationid"></a>`clientMutationId` | [`String`](#string) | A unique identifier for the client performing the mutation. |
+| <a id="mutationldapadminrolelinkcreatecn"></a>`cn` | [`String`](#string) | Common Name (CN) of the LDAP group. |
+| <a id="mutationldapadminrolelinkcreatefilter"></a>`filter` | [`String`](#string) | Search filter for the LDAP group. |
+| <a id="mutationldapadminrolelinkcreateprovider"></a>`provider` | [`String!`](#string) | LDAP provider for the LDAP link. |
+
+#### Fields
+
+| Name | Type | Description |
+| ---- | ---- | ----------- |
+| <a id="mutationldapadminrolelinkcreateclientmutationid"></a>`clientMutationId` | [`String`](#string) | A unique identifier for the client performing the mutation. |
+| <a id="mutationldapadminrolelinkcreateerrors"></a>`errors` | [`[String!]!`](#string) | Errors encountered during execution of the mutation. |
+| <a id="mutationldapadminrolelinkcreateldapadminrolelink"></a>`ldapAdminRoleLink` | [`LdapAdminRoleLink`](#ldapadminrolelink) | Created instance-level LDAP link. |
+
 ### `Mutation.markAsSpamSnippet`
 
 Input type: `MarkAsSpamSnippetInput`