Skip to content

Commit 8547b54

Browse files
committed
Merge branch '56363-inconsitent-file-size-indication-across-different-ci-pages' into 'master'
Show CI artifacts size with 3 significant digits Closes #56363 See merge request gitlab-org/gitlab-ce!24387
2 parents 59ac14a + d6b4b33 commit 8547b54

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

app/views/projects/artifacts/_tree_file.html.haml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
= link_to path_to_file, class: 'str-truncated' do
1515
%span= blob.name
1616
%td
17-
= number_to_human_size(blob.size, precision: 2)
17+
= number_to_human_size(blob.size)
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
title: Show CI artifact file size with 3 significant digits on 'browse job artifacts'
3+
page
4+
merge_request: 24387
5+
author:
6+
type: fixed

spec/features/projects/artifacts/user_browses_artifacts_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
page.within(".tree-table") do
2626
expect(page).to have_no_content("..")
2727
.and have_content("other_artifacts_0.1.2")
28-
.and have_content("ci_artifacts.txt")
29-
.and have_content("rails_sample.jpg")
28+
.and have_content("ci_artifacts.txt 27 Bytes")
29+
.and have_content("rails_sample.jpg 34.4 KB")
3030
end
3131

3232
page.within(".build-header") do

0 commit comments

Comments
 (0)