Skip to content

Commit 49efb57

Browse files
committed
Merge branch '56389-remove-unwanted-suggestion-flash-margin' into 'master'
Remove unwanted margin above suggested changes. Closes #56389 See merge request gitlab-org/gitlab-ce!24419
2 parents c5bc18d + 0cd37ad commit 49efb57

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

app/assets/javascripts/vue_shared/components/markdown/suggestions.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export default {
129129

130130
<template>
131131
<div>
132-
<div class="flash-container mt-3"></div>
132+
<div class="flash-container js-suggestions-flash"></div>
133133
<div v-show="isRendered" ref="container" v-html="noteHtml"></div>
134134
</div>
135135
</template>
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
title: Remove unwanted margin above suggested changes.
3+
merge_request: 24419
4+
author:
5+
type: fixed

spec/javascripts/vue_shared/components/markdown/suggestions_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('Suggestion component', () => {
6161

6262
describe('mounted', () => {
6363
it('renders a flash container', () => {
64-
expect(vm.$el.querySelector('.flash-container')).not.toBeNull();
64+
expect(vm.$el.querySelector('.js-suggestions-flash')).not.toBeNull();
6565
});
6666

6767
it('renders a container for suggestions', () => {

0 commit comments

Comments
 (0)