Merge branch 'mc/fix-artifact-before-validation' into 'master'

Disable artifact validation for download action

See merge request gitlab-org/gitlab-ce!22300

Author: ayufan

app/controllers/projects/artifacts_controller.rb

@@ -10,7 +10,7 @@ class Projects::ArtifactsController < Projects::ApplicationController
   before_action :authorize_update_build!, only: [:keep]
   before_action :extract_ref_name_and_path
   before_action :set_request_format, only: [:file]
-  before_action :validate_artifacts!
+  before_action :validate_artifacts!, except: [:download]
   before_action :entry, only: [:file]
 
   def download
@@ -102,7 +102,7 @@ def build_from_ref
   # rubocop: enable CodeReuse/ActiveRecord
 
   def artifacts_file
-    @artifacts_file ||= build.artifacts_file_for_type(params[:file_type] || :archive)
+    @artifacts_file ||= build&.artifacts_file_for_type(params[:file_type] || :archive)
   end
 
   def entry

app/controllers/projects/build_artifacts_controller.rb

@@ -6,10 +6,10 @@ class Projects::BuildArtifactsController < Projects::ApplicationController
 
   before_action :authorize_read_build!
   before_action :extract_ref_name_and_path
-  before_action :validate_artifacts!
+  before_action :validate_artifacts!, except: [:download]
 
   def download
-    redirect_to download_project_job_artifacts_path(project, job)
+    redirect_to download_project_job_artifacts_path(project, job, params: request.query_parameters)
   end
 
   def browse