Add latest changes from gitlab-org/gitlab@master

Author: GitLab Bot

.rubocop_todo/style/super_arguments.yml

@@ -109,7 +109,6 @@ Style/SuperArguments:
     - 'ee/lib/audit_events/strategies/base_google_cloud_logging_destination_strategy.rb'
     - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb'
     - 'ee/lib/ee/api/groups.rb'
-    - 'ee/lib/ee/api/internal/kubernetes.rb'
     - 'ee/lib/ee/api/snippets.rb'
     - 'ee/lib/ee/banzai/filter/sanitization_filter.rb'
     - 'ee/lib/ee/gitlab/quick_actions/users_extractor.rb'

GITALY_SERVER_VERSION

@@ -1 +1 @@
-98e4597b4ab1d5a87be725ae0aa58ba3f2566210
+6b099fa48bb2b7b64af5d10e2d361d0ceb0b3dad

app/models/issue.rb

@@ -163,8 +163,13 @@ def most_recent
 
   scope :not_authored_by, ->(user) { where.not(author_id: user) }
 
+  # N.B. The start_date and due_date columns are preserved on the issues table to enable performant sorting by these
+  # dates, since we would otherwise need to perform a join for the sort. These are synced via the DB trigger
+  # sync_issues_dates_with_work_item_dates_sources() from the work_item_dates_sources table
   scope :order_due_date_asc, -> { reorder(arel_table[:due_date].asc.nulls_last) }
   scope :order_due_date_desc, -> { reorder(arel_table[:due_date].desc.nulls_last) }
+  scope :order_start_date_asc, -> { reorder(arel_table[:start_date].asc.nulls_last) }
+  scope :order_start_date_desc, -> { reorder(arel_table[:start_date].desc.nulls_last) }
   scope :order_closest_future_date, -> { reorder(Arel.sql("CASE WHEN issues.due_date >= CURRENT_DATE THEN 0 ELSE 1 END ASC, ABS(CURRENT_DATE - issues.due_date) ASC")) }
   scope :order_created_at_desc, -> { reorder(created_at: :desc) }
   scope :order_severity_asc, -> do
@@ -189,8 +194,6 @@ def most_recent
   scope :order_escalation_status_desc, -> { includes(:incident_management_issuable_escalation_status).order(IncidentManagement::IssuableEscalationStatus.arel_table[:status].desc.nulls_last).references(:incident_management_issuable_escalation_status) }
   scope :order_closed_at_asc, -> { reorder(arel_table[:closed_at].asc.nulls_last) }
   scope :order_closed_at_desc, -> { reorder(arel_table[:closed_at].desc.nulls_last) }
-  scope :order_start_date_asc, -> { left_joins(:dates_source).order(WorkItems::DatesSource.arel_table[:start_date].asc.nulls_last) }
-  scope :order_start_date_desc, -> { left_joins(:dates_source).order(WorkItems::DatesSource.arel_table[:start_date].desc.nulls_last) }
 
   scope :preload_associated_models, -> { preload(:assignees, :labels, project: :namespace) }
   scope :with_web_entity_associations, -> do
@@ -449,15 +452,15 @@ def self.sort_by_attribute(method, excluded_labels: [])
     when 'closest_future_date', 'closest_future_date_asc' then order_closest_future_date
     when 'due_date', 'due_date_asc'                       then order_due_date_asc.with_order_id_desc
     when 'due_date_desc'                                  then order_due_date_desc.with_order_id_desc
+    when 'start_date', 'start_date_asc'                   then order_start_date_asc.with_order_id_desc
+    when 'start_date_desc'                                then order_start_date_desc.with_order_id_desc
     when 'relative_position', 'relative_position_asc'     then order_by_relative_position
     when 'severity_asc'                                   then order_severity_asc
     when 'severity_desc'                                  then order_severity_desc
     when 'escalation_status_asc'                          then order_escalation_status_asc
     when 'escalation_status_desc'                         then order_escalation_status_desc
     when 'closed_at', 'closed_at_asc'                     then order_closed_at_asc
     when 'closed_at_desc'                                 then order_closed_at_desc
-    when 'start_date', 'start_date_asc'                   then order_start_date_asc
-    when 'start_date_desc'                                then order_start_date_desc
     else
       super
     end

doc/user/application_security/dependency_scanning/_index.md

@@ -51,10 +51,10 @@ table.no-vertical-table-lines tr {
 
 {{< alert type="warning" >}}
 
-The Dependency Scanning feature based on the Gemnasium analyzer is deprecated in GitLab 17.9 and reaches
-end of support in GitLab 18.0. It is replaced with [Dependency Scanning using SBOM](dependency_scanning_sbom/_index.md)
+The Dependency Scanning feature based on the Gemnasium analyzer is deprecated in GitLab 17.9 and is planned for removal in
+GitLab 19.0. It is being replaced with [Dependency Scanning using SBOM](dependency_scanning_sbom/_index.md)
 and the [new Dependency Scanning analyzer](https://gitlab.com/gitlab-org/security-products/analyzers/dependency-scanning).
-For more information, see [issue 501038](https://gitlab.com/gitlab-org/gitlab/-/issues/501308).
+For more information, see [epic 15961](https://gitlab.com/groups/gitlab-org/-/epics/15961).
 
 {{< /alert >}}
 

lib/gitlab/ci/status/build/common.rb

@@ -18,8 +18,6 @@ def has_details?
           end
 
           def details_path
-            return unless can?(user, :read_build, subject)
-
             project_job_path(subject.project, subject)
           end
         end