Add latest changes from gitlab-org/gitlab@master

Author: GitLab Bot

app/assets/javascripts/feature_flags/components/form.vue

@@ -1,6 +1,6 @@
 <!-- eslint-disable vue/multi-word-component-names -->
 <script>
-import { GlButton } from '@gitlab/ui';
+import { GlButton, GlFormTextarea } from '@gitlab/ui';
 import { memoize, cloneDeep, isNumber, uniqueId } from 'lodash';
 import { s__ } from '~/locale';
 import RelatedIssuesRoot from '~/related_issues/components/related_issues_root.vue';
@@ -23,6 +23,7 @@ export default {
     GlButton,
     Strategy,
     RelatedIssuesRoot,
+    GlFormTextarea,
   },
   mixins: [featureFlagsMixin()],
   inject: {
@@ -159,24 +160,30 @@ export default {
     <fieldset>
       <div class="-gl-mx-5 gl-flex gl-flex-wrap">
         <div class="gl-mb-5 gl-w-full gl-px-5 md:gl-basis-1/3">
-          <label for="feature-flag-name" class="gl-font-bold"
-            >{{ s__('FeatureFlags|Name') }} *</label
-          >
-          <input id="feature-flag-name" v-model="formName" class="form-control" />
+          <label for="feature-flag-name" class="gl-font-bold">
+            {{ s__('FeatureFlags|Name') }}
+          </label>
+          <input
+            id="feature-flag-name"
+            v-model="formName"
+            class="form-control"
+            required
+            aria-required="true"
+          />
         </div>
       </div>
-
       <div class="-gl-mx-5 gl-flex gl-flex-wrap">
         <div class="gl-mb-5 gl-w-full gl-px-5 md:gl-basis-1/3">
           <label for="feature-flag-description" class="gl-font-bold">
-            {{ s__('FeatureFlags|Description') }}
+            {{ s__('FeatureFlags|Description (optional)') }}
           </label>
-          <textarea
+          <gl-form-textarea
             id="feature-flag-description"
             v-model="formDescription"
             class="form-control"
             rows="4"
-          ></textarea>
+            aria-required="false"
+          />
         </div>
       </div>
 
@@ -186,7 +193,6 @@ export default {
         :can-admin="true"
         :show-categorized-issues="false"
       />
-
       <div class="-gl-mx-5 gl-flex gl-flex-wrap">
         <div class="gl-mb-5 gl-w-full gl-px-5">
           <h4>{{ s__('FeatureFlags|Strategies') }}</h4>

app/assets/javascripts/work_items/graphql/cache_utils.js

@@ -149,7 +149,13 @@ function updateNoteAwardEmojiCache(currentNotes, note, callback) {
 
 export const updateCacheAfterAddingAwardEmojiToNote = (currentNotes, note) => {
   return updateNoteAwardEmojiCache(currentNotes, note, (n, awardEmoji) => {
-    n.awardEmoji.nodes.push(awardEmoji);
+    if (
+      !n.awardEmoji.nodes.some(
+        (emoji) => emoji.name === awardEmoji.name && emoji.user.id === awardEmoji.user.id,
+      )
+    ) {
+      n.awardEmoji.nodes.push(awardEmoji);
+    }
   });
 };
 

config/metrics/counts_all/20210216180049_projects_pivotaltracker_active.yml

@@ -9,6 +9,9 @@ value_type: number
 status: active
 time_frame: all
 data_source: database
+instrumentation_class: ActiveProjectIntegrationsMetric
+options:
+  type: pivotaltracker
 tiers:
 - free
 - premium

config/metrics/counts_all/20210216180051_groups_pivotaltracker_active.yml

@@ -9,6 +9,9 @@ value_type: number
 status: active
 time_frame: all
 data_source: database
+instrumentation_class: ActiveGroupIntegrationsMetric
+options:
+  type: pivotaltracker
 tiers:
 - free
 - premium

db/docs/batched_background_migrations/backfill_packages_nuget_metadata_project_id.yml

@@ -6,4 +6,4 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167607
 milestone: '17.5'
 queued_migration_version: 20240930121136
 finalize_after: '2024-10-22'
-finalized_by: # version of the migration that finalized this BBM
+finalized_by: '20250318231614'

db/docs/batched_background_migrations/backfill_packages_pypi_metadata_project_id.yml

@@ -6,4 +6,4 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167608
 milestone: '17.5'
 queued_migration_version: 20240930121830
 finalize_after: '2024-10-22'
-finalized_by: # version of the migration that finalized this BBM
+finalized_by: '20250318231642'

db/migrate/20250317055520_add_allow_agent_to_request_user_to_duo_workflows_workflows.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class AddAllowAgentToRequestUserToDuoWorkflowsWorkflows < Gitlab::Database::Migration[2.2]
+  milestone '17.11'
+
+  def change
+    add_column :duo_workflows_workflows, :allow_agent_to_request_user, :boolean, default: true, null: false
+  end
+end

db/post_migrate/20250318231614_finalize_hk_backfill_packages_nuget_metadata_project_id.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+class FinalizeHkBackfillPackagesNugetMetadataProjectId < Gitlab::Database::Migration[2.2]
+  milestone '17.11'
+
+  disable_ddl_transaction!
+
+  restrict_gitlab_migration gitlab_schema: :gitlab_main_cell
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: 'BackfillPackagesNugetMetadataProjectId',
+      table_name: :packages_nuget_metadata,
+      column_name: :package_id,
+      job_arguments: [:project_id, :packages_packages, :project_id, :package_id],
+      finalize: true
+    )
+  end
+
+  def down; end
+end

db/post_migrate/20250318231642_finalize_hk_backfill_packages_pypi_metadata_project_id.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+class FinalizeHkBackfillPackagesPypiMetadataProjectId < Gitlab::Database::Migration[2.2]
+  milestone '17.11'
+
+  disable_ddl_transaction!
+
+  restrict_gitlab_migration gitlab_schema: :gitlab_main_cell
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: 'BackfillPackagesPypiMetadataProjectId',
+      table_name: :packages_pypi_metadata,
+      column_name: :package_id,
+      job_arguments: [:project_id, :packages_packages, :project_id, :package_id],
+      finalize: true
+    )
+  end
+
+  def down; end
+end

db/schema_migrations/20250317055520

@@ -0,0 +1 @@
+bdb65c5bf0e5ed59deedded20c88516914c9ac5f43c57dc95547a2122d956b2b

db/schema_migrations/20250318231614

@@ -0,0 +1 @@
+0ad8202f097b9509c7430aeabaa6c39d202a2fd8ea06b7bb4f89e4efaccea858

db/schema_migrations/20250318231642

@@ -0,0 +1 @@
+eacfbd652ac6aa09c11f4d5f1540c2bc67db07c17c40c8e2396a16313b7e5e04

db/structure.sql

@@ -13619,6 +13619,7 @@ CREATE TABLE duo_workflows_workflows (
     goal text,
     agent_privileges smallint[] DEFAULT '{1,2}'::smallint[] NOT NULL,
     workflow_definition text DEFAULT 'software_development'::text NOT NULL,
+    allow_agent_to_request_user boolean DEFAULT true NOT NULL,
     CONSTRAINT check_5aedde451d CHECK ((char_length(goal) <= 4096)),
     CONSTRAINT check_ec723e2a1a CHECK ((char_length(workflow_definition) <= 255))
 );

doc/api/graphql/reference/_index.md

@@ -7723,18 +7723,15 @@ Input type: `MemberRoleAdminDeleteInput`
 | Name | Type | Description |
 | ---- | ---- | ----------- |
 | <a id="mutationmemberroleadmindeleteclientmutationid"></a>`clientMutationId` | [`String`](#string) | A unique identifier for the client performing the mutation. |
-| <a id="mutationmemberroleadmindeletedescription"></a>`description` | [`String`](#string) | Description of the member role. |
 | <a id="mutationmemberroleadmindeleteid"></a>`id` | [`MemberRoleID!`](#memberroleid) | ID of the admin member role to delete. |
-| <a id="mutationmemberroleadmindeletename"></a>`name` | [`String`](#string) | Name of the member role. |
-| <a id="mutationmemberroleadmindeletepermissions"></a>`permissions` | [`[MemberRoleAdminPermission!]`](#memberroleadminpermission) | List of all customizable admin permissions. |
 
 #### Fields
 
 | Name | Type | Description |
 | ---- | ---- | ----------- |
 | <a id="mutationmemberroleadmindeleteclientmutationid"></a>`clientMutationId` | [`String`](#string) | A unique identifier for the client performing the mutation. |
 | <a id="mutationmemberroleadmindeleteerrors"></a>`errors` | [`[String!]!`](#string) | Errors encountered during execution of the mutation. |
-| <a id="mutationmemberroleadmindeletememberrole"></a>`memberRole` | [`AdminMemberRole`](#adminmemberrole) | Member role. |
+| <a id="mutationmemberroleadmindeletememberrole"></a>`memberRole` | [`MemberRole`](#memberrole) | Deleted admin member role. |
 
 ### `Mutation.memberRoleAdminUpdate`
 

doc/ci/testing/code_quality.md

@@ -179,14 +179,14 @@ This format is a version of the [CodeClimate report format](https://github.com/c
 The file you provide as [Code Quality report artifact](../yaml/artifacts_reports.md#artifactsreportscodequality) must contain a single JSON array.
 Each object in that array must have at least the following properties:
 
-| Name                                                      | Description                                                                                            | Type                                                                         |
-|-----------------------------------------------------------|--------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------|
-| `description`                                             | A human-readable description of the code quality violation.                                            | String                                                                       |
-| `check_name`                                              | A unique name representing the check, or rule, associated with this violation.                         | String                                                                       |
-| `fingerprint`                                             | A unique fingerprint to identify this specific code quality violation, such as a hash of its contents. | String                                                                       |
-| `severity`                                                | The severity of the violation.                                                                         | String. Valid values are `info`, `minor`, `major`, `critical`, or `blocker`. |
-| `location.path`                                           | The file containing the code quality violation, expressed as a relative path in the repository.        | String                                                                       |
-| `location.lines.begin` or `location.positions.begin.line` | The line on which the code quality violation occurred.                                                 | Integer                                                                      |
+| Name                                                      | Description                                                                                                              | Type                                                                         |
+|-----------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------|
+| `description`                                             | A human-readable description of the code quality violation.                                                              | String                                                                       |
+| `check_name`                                              | A unique name representing the check, or rule, associated with this violation.                                           | String                                                                       |
+| `fingerprint`                                             | A unique fingerprint to identify this specific code quality violation, such as a hash of its contents.                   | String                                                                       |
+| `severity`                                                | The severity of the violation.                                                                                           | String. Valid values are `info`, `minor`, `major`, `critical`, or `blocker`. |
+| `location.path`                                           | The file containing the code quality violation, expressed as a relative path in the repository. Do not prefix with `./`. | String                                                                       |
+| `location.lines.begin` or `location.positions.begin.line` | The line on which the code quality violation occurred.                                                                   | Integer                                                                      |
 
 The format is different from the [CodeClimate report format](https://github.com/codeclimate/platform/blob/master/spec/analyzers/SPEC.md#data-types) in the following ways:
 

doc/ci/testing/code_quality_troubleshooting.md

@@ -45,6 +45,13 @@ Missing report on the target branch can be due to:
 
 Verify the presence of report on the base commit by obtaining the `base_sha` using the [merge request API](../../api/merge_requests.md#get-single-mr) and use the [pipelines API with the `sha` attribute](../../api/pipelines.md#list-project-pipelines) to check if pipelines ran.
 
+## No Code Quality symbol in the changes view
+
+If no symbol is displayed in the [changes view](../testing/code_quality.md#merge-request-changes-view), ensure that the `location.path` in the code quality report:
+
+- Is using a relative path to the file containing the code quality violation.
+- Is not prefixed with `./`. For example, the `path` should be `somedir/file1.rb` instead of `./somedir/file1.rb`.
+
 ## Only a single Code Quality report is displayed, but more are defined
 
 Code Quality automatically [combines multiple reports](code_quality.md#scan-code-for-quality-violations).