Skip to content

Commit 029381b

Browse files
Clement HoClement Ho
Clement Ho
authored and
Clement Ho
committed
Merge branch '64831-add-padding-to-merged-by-widget' into 'master'
Resolve "Add padding to "merged by" widget" Closes #64831 See merge request gitlab-org/gitlab-ce!30972
2 parents d2aeae5 + 96d1021 commit 029381b

File tree

4 files changed

+15
-19
lines changed

4 files changed

+15
-19
lines changed

app/assets/javascripts/reports/components/report_section.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ export default {
166166
<section class="media-section">
167167
<div class="media">
168168
<status-icon :status="statusIconName" :size="24" />
169-
<div class="media-body d-flex flex-align-self-center prepend-left-default">
169+
<div class="media-body d-flex flex-align-self-center">
170170
<span class="js-code-text code-text">
171171
{{ headerText }}
172172
<slot :name="slotName"></slot>

app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.vue

+7-4
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,13 @@ export default {
3232
};
3333
</script>
3434
<template>
35-
<div class="d-flex widget-status-icon">
36-
<div v-if="isLoading" class="mr-widget-icon"><gl-loading-icon size="sm" /></div>
37-
38-
<ci-icon v-else :status="statusObj" :size="24" />
35+
<div class="d-flex align-self-start">
36+
<div class="square s24 h-auto d-flex-center append-right-default">
37+
<div v-if="isLoading" class="mr-widget-icon">
38+
<gl-loading-icon size="sm" />
39+
</div>
40+
<ci-icon v-else :status="statusObj" :size="24" />
41+
</div>
3942

4043
<button
4144
v-if="showDisabledButton"

app/assets/stylesheets/pages/merge_requests.scss

+2-14
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
}
8989

9090
.mr-widget-info {
91-
padding-left: $gl-padding-50 - $gl-padding-32;
91+
padding-left: $gl-padding;
9292
padding-right: $gl-padding;
9393
}
9494

@@ -262,23 +262,11 @@
262262
}
263263
}
264264

265-
.widget-status-icon {
266-
align-self: flex-start;
267-
268-
button {
269-
margin-left: $gl-padding;
270-
}
271-
}
272-
273265
.mr-widget-body {
274266
line-height: 28px;
275267

276268
@include clearfix;
277269

278-
button {
279-
margin-left: $gl-padding;
280-
}
281-
282270
.approve-btn {
283271
margin-right: 5px;
284272
}
@@ -527,7 +515,7 @@
527515
}
528516

529517
.mr-links {
530-
padding-left: $status-icon-size + $gl-btn-padding;
518+
padding-left: $gl-padding-8 + $status-icon-size + $gl-btn-padding;
531519

532520
&:last-child {
533521
padding-bottom: $gl-padding;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
title: Add space to "merged by" widget
3+
merge_request: 30972
4+
author:
5+
type: fixed

0 commit comments

Comments
 (0)