Skip to content

Commit 34e9cec

Browse files
authored
Merge pull request #254 from MartinThoma/typos
Fix typos
2 parents 5aa87c5 + 3db5cc5 commit 34e9cec

File tree

2 files changed

+37
-36
lines changed

2 files changed

+37
-36
lines changed

NEWS

Lines changed: 29 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
* Relase 0.17.0 (27 May 2021)
1+
* Release 0.17.0 (27 May 2021)
22

33
New API:
44
* Keys that use explicit curve parameters can now be read and written.
@@ -38,13 +38,13 @@ Bug fix:
3838
`PointJacobi`, `VerifyingKey`, and `SigningKey` so that it behaves
3939
consistently and in the expected way both in Python 2 and Python 3.
4040
* Implement lock-less algorithm inside PointJacobi for keeping shared state
41-
so that when calculation is aborted with KeyboardInterrupt, the state doesn't
42-
become corrupted (this fixes the occasional breakage of ecdsa in interactive
43-
shells).
41+
so that when a calculation is aborted with KeyboardInterrupt, the state
42+
doesn't become corrupted (this fixes the occasional breakage of ecdsa in
43+
interactive shells).
4444

4545
New features:
4646
* The `speed.py` script now provides performance for signature verification
47-
without use of precomputation.
47+
without the use of precomputation.
4848
* New curves supported: secp112r1, secp112r2, secp128r1, secp160r1.
4949

5050
Performance:
@@ -89,11 +89,11 @@ Support for reading and writing private keys in PKCS#8 format.
8989

9090
New API:
9191
`to_pem` and `to_der` now accept new parameter, `format`, to specify
92-
the format of the encoded files, either the dafault, legacy "ssleay", or
92+
the format of the encoded files, either the default, legacy `ssleay`, or
9393
the new `pkcs8` to use PKCS#8. Note that only unencrypted PKCS#8 files are
9494
supported.
9595
Add `allow_truncate` to `verify` in `VerifyingKey`, it defaults to True,
96-
when specified as False, use of large hashes smaller than curves will be
96+
when specified as False, the use of large hashes smaller than curves will be
9797
disallowed (as it was in 0.14.1 and earlier).
9898

9999
Bug fix:
@@ -108,7 +108,7 @@ as such.
108108
Maintenance:
109109
Ensure that version checks will work with Python 4.
110110
Format the source with black.
111-
Fix uses of `assert_` in test suite.
111+
Fix uses of `assert_` in the test suite.
112112
Use newer Ubuntu in Travis to test against OpenSSL 1.1.1 (and thus
113113
test the interoperability of ECDH code in Travis).
114114

@@ -131,24 +131,24 @@ New API:
131131
`ecdsa.ecdh` module and `ECDH` class.
132132
`PointJacobi` added.
133133
`VerifyingKey.verify_digest`, `SigningKey.sign_digest` and
134-
`SigningKey.sign_digest_deterministic` methods now accept `allow_truncate`
135-
argument to enable use of hashes larger than the curve order.
134+
`SigningKey.sign_digest_deterministic` methods now accept the `allow_truncate`
135+
argument to enable the use of hashes larger than the curve order.
136136
`VerifyingKey` `from_pem` and `from_der` now accept `hashfunc` parameter
137137
like other `from*` methods.
138-
`VerifyingKey` has `precompute` method now.
138+
`VerifyingKey` has the `precompute` method now.
139139
`VerifyingKey.from_public_point` may now not perform validation of public
140-
point when `validate_point=False` argument is passed to method.
140+
point when `validate_point=False` argument is passed to the method.
141141
`CurveFp` constructor now accepts the `h` parameter - the cofactor of the
142-
elliptic curve, it's used for selection of algorithm of public point
142+
elliptic curve, it's used for the selection of algorithm of public point
143143
verification.
144144

145145
Performance:
146-
`randrange` now will now perform much fewer calls to system random number
146+
`randrange` now will perform much fewer calls to the system random number
147147
generator.
148148
`PointJacobi` introduced and used as the underlying implementation; speeds up
149149
the library by a factor of about 20.
150-
Library has now optional dependencies on `gmpy` and `gmpy2`. When they are
151-
availbale, the elliptic curve calculations will be about 3 times faster.
150+
The library has now optional dependencies on `gmpy` and `gmpy2`. When they are
151+
available, the elliptic curve calculations will be about 3 times faster.
152152

153153
Maintenance:
154154
expected minimum version of `six` module (1.9.0) is now specified explicitly
@@ -173,13 +173,13 @@ Make `SigningKey.sign_digest_deterministic` use default object hashfunc when
173173
none was provided.
174174
`encode_integer` now works for large integers.
175175
Make `encode_oid` and `remove_object` correctly handle OBJECT IDENTIFIERs
176-
with large second subidentifier and padding in encoded subidentifiers.
176+
with large second sub-identifier and padding in encoded sub-identifiers.
177177

178178
New features:
179-
Deterministic signature methods now accept `extra_entropy` parameter to further
180-
randomise the selection of `k` (the nonce) for signature, as specified in
181-
RFC6979.
182-
Recovery of public key from signature is now supported.
179+
Deterministic signature methods now accept the `extra_entropy` parameter to
180+
further randomise the selection of `k` (the nonce) for signature, as specified
181+
in RFC6979.
182+
Recovery of the public key from signature is now supported.
183183
Support for SEC1/X9.62 formatted keys, all three encodings are supported:
184184
"uncompressed", "compressed" and "hybrid". Both string, and PEM/DER will
185185
automatically accept them, if the size of the key matches the curve.
@@ -204,7 +204,7 @@ added.
204204
`VerifyingKey`: `__repr__` is now supported
205205

206206
Deprecations:
207-
Python 2.5 is not supported any more - dead code removal.
207+
Python 2.5 is not supported anymore - dead code removal.
208208
`from ecdsa.keys import *` will now import only objects defined in that module.
209209
Trying to decode a malformed point using `VerifyingKey.from_string`
210210
will rise now the `MalformedPointError` exception (that inherits from
@@ -223,10 +223,10 @@ modular_exp: will emit `DeprecationWarning`
223223

224224
Hardening:
225225
Deterministic signatures now verify that the signature won't leak private
226-
key through very unlikely selection of `k` value (the nonce).
226+
key through a very unlikely selection of `k` value (the nonce).
227227
Nonce bit size hiding was added (hardening against Minerva attack). Please
228-
note that it DOES NOT make library secure against side channel attacks (timing
229-
attacks).
228+
note that it DOES NOT make the library secure against side-channel attacks
229+
(timing attacks).
230230

231231
Performance:
232232
The public key in key generation is not verified twice now, making key
@@ -311,14 +311,15 @@ hashfunc=sha256 in each time they call sign() or verify().
311311

312312
Fix test failure against OpenSSL-1.0.0 (previous versions only worked against
313313
openssl-0.9.8 or earlier). Increase python requirement to py2.5 or later
314-
(still no py3 compatibility, but work is underway). Replace use of obsolete
314+
(still no py3 compatibility, but work is underway). Replace the use of obsolete
315315
'sha' library with modern 'hashlib'. Clean up unit test runner (stop using
316316
subprocesses).
317317

318318
* Release 0.6 (15 Oct 2010)
319319

320-
Small packaging changes: extract version number from git, add 'setup.py test'
321-
command, set exit code correctly on test failure. Fix pyflakes warnings.
320+
Small packaging changes: extract the version number from git, add
321+
'setup.py test' command, set exit code correctly on test failure. Fix pyflakes
322+
warnings.
322323

323324
* Release 0.5 (27 Apr 2010)
324325

README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ curves over prime fields.
3939
## Dependencies
4040

4141
This library uses only Python and the 'six' package. It is compatible with
42-
Python 2.6, 2.7 and 3.3+. It also supports execution on the alternative
42+
Python 2.6, 2.7, and 3.3+. It also supports execution on alternative
4343
implementations like pypy and pypy3.
4444

4545
If `gmpy2` or `gmpy` is installed, they will be used for faster arithmetic.
@@ -78,7 +78,7 @@ pip install ecdsa[gmpy]
7878
The following table shows how long this library takes to generate keypairs
7979
(`keygen`), to sign data (`sign`), to verify those signatures (`verify`),
8080
to derive a shared secret (`ecdh`), and
81-
to verify the signatures with no key specific precomputation (`no PC verify`).
81+
to verify the signatures with no key-specific precomputation (`no PC verify`).
8282
All those values are in seconds.
8383
For convenience, the inverses of those values are also provided:
8484
how many keys per second can be generated (`keygen/s`), how many signatures
@@ -87,7 +87,7 @@ per second (`verify/s`), how many shared secrets can be derived per second
8787
(`ecdh/s`), and how many signatures with no key specific
8888
precomputation can be verified per second (`no PC verify/s`). The size of raw
8989
signature (generally the smallest
90-
way a signature can be encoded) is also provided in the `siglen` column.
90+
the way a signature can be encoded) is also provided in the `siglen` column.
9191
Use `tox -e speed` to generate this table on your own computer.
9292
On an Intel Core i7 4790K @ 4.0GHz I'm getting the following performance:
9393

@@ -176,8 +176,8 @@ On the same machine I'm getting the following performance with `gmpy2`:
176176
(there's also `gmpy` version, execute it using `tox -e speedgmpy`)
177177

178178
For comparison, a highly optimised implementation (including curve-specific
179-
assembly for some curves), like the one in OpenSSL 1.1.1d, provides following
180-
performance numbers on the same machine.
179+
assembly for some curves), like the one in OpenSSL 1.1.1d, provides the
180+
following performance numbers on the same machine.
181181
Run `openssl speed ecdsa` and `openssl speed ecdh` to reproduce it:
182182
```
183183
sign verify sign/s verify/s
@@ -247,7 +247,7 @@ OpenSSL. [pyca/cryptography](https://cryptography.io) is one example of such
247247
a wrapper. The primary use-case of this library is as a portable library for
248248
interoperability testing and as a teaching tool.
249249

250-
**This library does not protect against side channel attacks.**
250+
**This library does not protect against side-channel attacks.**
251251

252252
Do not allow attackers to measure how long it takes you to generate a keypair
253253
or sign a message. Do not allow attackers to run code on the same physical
@@ -262,7 +262,7 @@ operation with a private key will be sufficient to completely
262262
reconstruct the private key**.
263263

264264
Please also note that any Pure-python cryptographic library will be vulnerable
265-
to the same side channel attacks. This is because Python does not provide
265+
to the same side-channel attacks. This is because Python does not provide
266266
side-channel secure primitives (with the exception of
267267
[`hmac.compare_digest()`][3]), making side-channel secure programming
268268
impossible.
@@ -363,7 +363,7 @@ vk2 = VerifyingKey.from_pem(vk_pem)
363363
There are a couple of different ways to compute a signature. Fundamentally,
364364
ECDSA takes a number that represents the data being signed, and returns a
365365
pair of numbers that represent the signature. The `hashfunc=` argument to
366-
`sk.sign()` and `vk.verify()` is used to turn an arbitrary string into
366+
`sk.sign()` and `vk.verify()` is used to turn an arbitrary string into a
367367
fixed-length digest, which is then turned into a number that ECDSA can sign,
368368
and both sign and verify must use the same approach. The default value is
369369
`hashlib.sha1`, but if you use NIST256p or a longer curve, you can use

0 commit comments

Comments
 (0)