Skip to content

Commit febff0c

Browse files
committed
Adding a FIXME based on feedback from Richard Smith.
llvm-svn: 190369
1 parent 8ee40b7 commit febff0c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

clang/lib/Sema/SemaDeclAttr.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1549,6 +1549,9 @@ static void handleWeakRefAttr(Sema &S, Decl *D, const AttributeList &Attr) {
15491549
// static ((alias ("y"), weakref)).
15501550
// Should we? How to check that weakref is before or after alias?
15511551

1552+
// FIXME: it would be good for us to keep the WeakRefAttr as-written instead
1553+
// of transforming it into an AliasAttr. The WeakRefAttr never uses the
1554+
// StringRef parameter it was given anyway.
15521555
if (Attr.isArgExpr(0)) {
15531556
Expr *Arg = Attr.getArgAsExpr(0);
15541557
Arg = Arg->IgnoreParenCasts();

0 commit comments

Comments
 (0)