Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomizer produces junk lines in UniqueItems.txt #63

Open
BardurArantsson opened this issue Aug 14, 2020 · 2 comments
Open

Randomizer produces junk lines in UniqueItems.txt #63

BardurArantsson opened this issue Aug 14, 2020 · 2 comments

Comments

@BardurArantsson
Copy link

(I see that a rework is planned before v1.0, so apologies if this is already planned to be fixed by that rework. I thought it best to report it just in case.)

Some lines in UniqueItems.txt are actually just section headings, e.g.
search for 'Expansion' or 'Class Specific', where the only filled-in data fields are the 'index' and the 'eol' column.

Running the v0.5.0 randomizer erroneously fills in the prop columns on these rows too. It doesn't seem to confuse the game itself, but it could lead to some properties being (effectively) removed from the game when running with the Balanced option.

(I suspect, but haven't confirmed that the same happens to items which are disabled, e.g. the 'enabled' column = 0, see e.g. Constricting Ring.)

@Deadlock39
Copy link
Collaborator

The main randomizer rework is already complete, but this bug won't cause any issues with props being removed. The properties can be used more than once, so randomizing extra items, or things that aren't items doesn't "use up" those props.

I think I can still fix this pretty easily. It can be done at the same time the quest items are fixed.

@OldBeardedCoder
Copy link
Collaborator

Generator is smart enough not to do this. Checks the lvl column I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants