Skip to content

Commit 3034fad

Browse files
committed
优化监听器删除失败时的事件消息
1 parent 00e8701 commit 3034fad

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

internal/controller/dedicatedclblistener_controller.go

+4-8
Original file line numberDiff line numberDiff line change
@@ -149,19 +149,15 @@ func (r *DedicatedCLBListenerReconciler) cleanListener(ctx context.Context, log
149149
return nil
150150
}
151151
log = log.WithValues("listenerId", lis.Status.ListenerId, "port", lis.Spec.LbPort, "protocol", lis.Spec.Protocol)
152-
log.V(5).Info("start cleanListener")
153-
defer log.V(5).Info("end cleanListener")
154152
// 删除监听器
155153
log.V(5).Info("delete listener")
156154
listenerId, err := clb.DeleteListenerByPort(ctx, lis.Spec.LbRegion, lis.Spec.LbId, lis.Spec.LbPort, lis.Spec.Protocol)
157155
if err != nil {
158-
if serr, ok := err.(*sdkerror.TencentCloudSDKError); ok {
159-
if serr.Code == "InvalidParameter.LBIdNotFound" {
160-
r.Recorder.Event(lis, corev1.EventTypeWarning, "DeleteListener", fmt.Sprintf("lbId %s not found", lis.Spec.LbId))
161-
} else {
162-
return err
163-
}
156+
r.Recorder.Event(lis, corev1.EventTypeWarning, "DeleteListener", err.Error())
157+
if serr, ok := err.(*sdkerror.TencentCloudSDKError); ok && serr.Code == "InvalidParameter.LBIdNotFound" {
158+
log.V(5).Info("lbId not found when delete listener, ignore", "lbId", lis.Spec.LbId)
164159
} else {
160+
r.Recorder.Event(lis, corev1.EventTypeWarning, "DeleteListener", err.Error())
165161
return err
166162
}
167163
}

0 commit comments

Comments
 (0)