Skip to content

Commit 6811cc4

Browse files
ivdiazsaKastle186
andauthored
Improvements to CoreCLR Building, Debugging, and Testing Documentation (dotnet#75569)
* Quality Week 2022: The First Step to a Better Documentation. * Removed the Markdown Extension's additional development tags. * Removed redundant stuff. * Removed redundant stuff. * Removed guide testing versions to avoid confusion that they would be the only supported versions. * Addressed some Powershell comments, added a pointer to a yaml with links to other .NET sibling repos, and did a couple mini-corrections. Still got a few comments to address... * Fixed a ';:' with Powershell's syntax. * Addressed review comments: Redaction improvements, localization url's, improved code snippets, added info on individual subsets building configurations, changed COMPlus for DOTNET, and other misc improvements. * Addressed remaining comments. * Addressed some last comments regarding corerun, and the subset flags in the build scripts. Co-authored-by: Ivan Diaz <[email protected]>
1 parent cecdf89 commit 6811cc4

29 files changed

+1791
-1447
lines changed

README.md

+15-9
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,24 @@
11
# .NET Runtime
2+
23
[![Build Status](https://dnceng.visualstudio.com/public/_apis/build/status/dotnet/runtime/runtime?branchName=main)](https://dnceng.visualstudio.com/public/_build/latest?definitionId=686&branchName=main)
34
[![Help Wanted](https://img.shields.io/github/issues/dotnet/runtime/help%20wanted?style=flat-square&color=%232EA043&label=help%20wanted)](https://github.com/dotnet/runtime/labels/help%20wanted)
45
[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/dotnet/runtime)
56
[![Discord](https://img.shields.io/discord/732297728826277939?style=flat-square&label=Discord&logo=discord&logoColor=white&color=7289DA)](https://aka.ms/dotnet-discord)
67

8+
* [What is .NET?](#what-is-net)
9+
* [How can I contribute?](#how-can-i-contribute)
10+
* [Reporting security issues and security bugs](#reporting-security-issues-and-security-bugs)
11+
* [Filing issues](#filing-issues)
12+
* [Useful Links](#useful-links)
13+
* [.NET Foundation](#net-foundation)
14+
* [License](#license)
15+
716
This repo contains the code to build the .NET runtime, libraries and shared host (`dotnet`) installers for
817
all supported platforms, as well as the sources to .NET runtime and libraries.
918

1019
## What is .NET?
1120

12-
Official Starting Page: https://dotnet.microsoft.com
21+
Official Starting Page: <https://dotnet.microsoft.com>
1322

1423
* [How to use .NET](https://docs.microsoft.com/dotnet/core/get-started) (with VS, VS Code, command-line CLI)
1524
* [Install official releases](https://dotnet.microsoft.com/download)
@@ -25,23 +34,20 @@ Official Starting Page: https://dotnet.microsoft.com
2534
We welcome contributions! Many people all over the world have helped make this project better.
2635

2736
* [Contributing](CONTRIBUTING.md) explains what kinds of contributions we welcome
28-
- [Workflow Instructions](docs/workflow/README.md) explains how to build and test
37+
* [Workflow Instructions](docs/workflow/README.md) explains how to build and test
2938
* [Get Up and Running on .NET Core](docs/project/dogfooding.md) explains how to get nightly builds of the runtime and its libraries to test them in your own projects.
3039

3140
## Reporting security issues and security bugs
3241

33-
Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC) <[email protected]>. You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [Security TechCenter](https://www.microsoft.com/msrc/faqs-report-an-issue).
42+
Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC) <[email protected]>. You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [Security TechCenter](https://www.microsoft.com/msrc/faqs-report-an-issue). You can also find these instructions in this repo's [Security doc](SECURITY.md).
3443

3544
Also see info about related [Microsoft .NET Core and ASP.NET Core Bug Bounty Program](https://www.microsoft.com/msrc/bounty-dot-net-core).
3645

3746
## Filing issues
3847

3948
This repo should contain issues that are tied to the runtime, the class libraries and frameworks, the installation of the `dotnet` binary (sometimes known as the `muxer`) and installation of the .NET runtime and libraries.
4049

41-
For other issues, please use the following repos:
42-
43-
- For overall .NET SDK issues, file in the [dotnet/sdk](https://github.com/dotnet/sdk) repo
44-
- For ASP.NET issues, file in the [dotnet/aspnetcore](https://github.com/dotnet/aspnetcore) repo.
50+
For other issues, please file them to their appropriate sibling repos. Their respective links are described in the [config issue template doc](/.github/ISSUE_TEMPLATE/config.yml).
4551

4652
## Useful Links
4753

@@ -57,8 +63,8 @@ For other issues, please use the following repos:
5763

5864
There are many .NET related projects on GitHub.
5965

60-
- [.NET home repo](https://github.com/Microsoft/dotnet) - links to 100s of .NET projects, from Microsoft and the community.
61-
- [ASP.NET Core home](https://docs.microsoft.com/aspnet/core) - the best place to start learning about ASP.NET Core.
66+
* [.NET home repo](https://github.com/Microsoft/dotnet) - links to 100s of .NET projects, from Microsoft and the community.
67+
* [ASP.NET Core home](https://docs.microsoft.com/aspnet/core) - the best place to start learning about ASP.NET Core.
6268

6369
This project has adopted the code of conduct defined by the [Contributor Covenant](https://contributor-covenant.org) to clarify expected behavior in our community. For more information, see the [.NET Foundation Code of Conduct](https://www.dotnetfoundation.org/code-of-conduct).
6470

docs/workflow/Codespaces.md

+24-18
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
11
# Using Codespaces
2-
Codespaces allows you to develop in a Docker container running in the cloud. You can use an in-browser version of VS Code or the full VS Code application with the [GitHub Codespaces VS Code Extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces). This means you don't need to install dotnet/runtime's prerequisites on your current machine in order to develop in dotnet/runtime.
2+
3+
* [Create a Codespace](#create-a-codespace)
4+
* [Updating dotnet/runtime's Codespaces Configuration](#updating-dotnetruntimes-codespaces-configuration)
5+
* [Testing out your Changes](#testing-out-your-changes)
6+
7+
Codespaces allows you to develop in a Docker container running in the cloud. You can use an in-browser version of VS Code or the full VS Code application with the [GitHub Codespaces VS Code Extension](https://marketplace.visualstudio.com/items?itemName=GitHub.codespaces). This means you don't need to install any prerequisites on your current machine in order to develop in _dotnet/runtime_.
38

49
## Create a Codespace
510

6-
dotnet/runtime runs a nightly GitHub Action to build the latest code in the repo. This allows you to immediately start developing and testing after creating a codespace without having to build the whole repo. When the machine is created, it will have built the repo using the code as of 6 AM UTC that morning.
11+
The _dotnet/runtime_ repo runs a nightly GitHub Action to build the latest code in it. This allows you to immediately start developing and testing after creating a Codespace without having to build the whole repo. When the machine is created, it will have built the repo using the code as of 6 AM UTC of that morning.
712

8-
1. From https://github.com/dotnet/runtime, drop-down the `Code` button and select the `Codespaces` tab.
13+
1. From this [repository's root](https://github.com/dotnet/runtime), drop-down the _Code_ button and select the _Codespaces_ tab.
914

1015
![New codespace button](https://docs.github.com/assets/cb-138303/images/help/codespaces/new-codespace-button.png)
1116

@@ -17,29 +22,30 @@ dotnet/runtime runs a nightly GitHub Action to build the latest code in the repo
1722

1823
![Dev container configuration](./codespace-dev-container-configuration.png)
1924

20-
- For `libraries` work, pick `.devcontainer/libraries/devcontainer.json`.
21-
- For `WASM` work, pick `.devcontainer/wasm/devcontainer.json`.
25+
* For `libraries` work, pick `.devcontainer/libraries/devcontainer.json`.
26+
* For `WASM` work, pick `.devcontainer/wasm/devcontainer.json`.
2227

2328
4. Select the Machine type. For `dotnet/runtime`, it is recommended to select at least a `4-core` machine. You can also verify that a `Prebuild` is ready.
2429

25-
![Codespace machine size](./codespace-machine-size.png)
30+
![Codespace machine size](codespace-machine-size.png)
2631

27-
28-
*If these instructions are out of date, see https://docs.github.com/codespaces/developing-in-codespaces/creating-a-codespace#creating-a-codespace for instructions on how to create a new codespace.*
32+
_If these instructions are out of date, see <https://docs.github.com/codespaces/developing-in-codespaces/creating-a-codespace#creating-a-codespace> for instructions on how to create a new Codespace._
2933

3034
## Updating dotnet/runtime's Codespaces Configuration
3135

3236
The Codespaces configuration is spread across the following places:
3337

34-
1. The [.devcontainer](../../.devcontainer) folder contains folders for each "development scenario":
35-
- `libraries` - Used by developers working in `src/libraries`
36-
- `wasm` - Used by developers working on the browser-wasm workload
37-
- The `scripts` folder contains any scripts that are executed during the creation of the codespace. This has the build command that builds the entire repo for prebuilds.
38-
2. Each development scenario folder contains:
39-
- `devcontainer.json` file configures the codespace and has VS Code / Environment settings
40-
- The Dockerfile used to create the Docker image
41-
3. The GitHub Action can be configured by following the instructions at https://docs.github.com/codespaces/prebuilding-your-codespaces/configuring-prebuilds.
38+
1. The [.devcontainer](/.devcontainer) folder contains subfolders for each development scenario:
39+
* _Libraries_: Used by developers working in `src/libraries`.
40+
* _Wasm_: Used by developers working on the _browser-wasm_ workload.
41+
* _Scripts_: Contains any scripts that are executed during the creation of the codespace. This has the build command that builds the entire repo for prebuilds.
42+
2. Each development scenario folder contains the following files:
43+
* The `devcontainer.json` file that configures the codespace and has VS Code / Environment settings.
44+
* The _Dockerfile_ used to create the Docker image
45+
3. The GitHub Action can be configured by following the instructions at <https://docs.github.com/codespaces/prebuilding-your-codespaces/configuring-prebuilds>.
46+
47+
To test out changes to the `.devcontainer` files, you can follow the process in the [Applying Changes to your Configuration](https://docs.github.com/codespaces/customizing-your-codespace/configuring-codespaces-for-your-project#applying-changes-to-your-configuration) docs. This allows you to rebuild the Codespace privately before creating a PR.
4248

43-
To test out changes to the `.devcontainer` files, you can follow the process in [Applying changes to your configuration](https://docs.github.com/codespaces/customizing-your-codespace/configuring-codespaces-for-your-project#applying-changes-to-your-configuration) docs. This allows you to rebuild the Codespace privately before creating a PR.
49+
## Testing out your Changes
4450

45-
To test out your changes you can run the [Codespaces Prebuilds Action](https://github.com/dotnet/runtime/actions/workflows/codespaces/create_codespaces_prebuilds) in your fork against a branch with your changes.
51+
To test out your changes you can run the [Codespaces Prebuilds Action](https://github.com/dotnet/runtime/actions/workflows/codespaces/create_codespaces_prebuilds) in your fork against a branch with your changes.

0 commit comments

Comments
 (0)