update pureftpd::config::mysql to use the common erb template + rspec

Author: Joshua Hoblitt

manifests/config/mysql.pp

@@ -16,7 +16,54 @@
 # - implement template and variables for the mysql config file
 #
 
-class pureftpd::config::mysql inherits pureftpd::params {
+class pureftpd::config::mysql (
+  $mysqlserver                = undef,
+  $mysqlport                  = undef,
+  $mysqlsocket                = undef,
+  $mysqluser                  = undef,
+  $mysqlpassword              = undef,
+  $mysqldatabase              = undef,
+  $mysqlcrypt                 = undef,
+  $mysqltransactions          = undef,
+  $mysqlgetpw                 = undef,
+  $mysqlgetuid                = undef,
+  $mysqldefaultuid            = undef,
+  $mysqlgetgid                = undef,
+  $mysqldefaultgid            = undef,
+  $mysqlgetdir                = undef,
+  $mysqlforcetildeexpansion   = undef,
+  $mysqlgetqtafs              = undef,
+  $mysqlgetqtasz              = undef,
+  $mysqlgetratioul            = undef,
+  $mysqlgetratiodl            = undef,
+  $mysqlgetbandwidthul        = undef,
+  $mysqlgetbandwidthdl        = undef,
+) inherits pureftpd::params {
+
+  # options taken from pure-ftpd-1.0.30/configuration-file/log_mysql_p.h
+  $conf_options = [
+    'MYSQLServer',
+    'MYSQLPort',
+    'MYSQLSocket',
+    'MYSQLUser',
+    'MYSQLPassword',
+    'MYSQLDatabase',
+    'MYSQLCrypt',
+    'MYSQLTransactions',
+    'MYSQLGetPW',
+    'MYSQLGetUID',
+    'MYSQLDefaultUID',
+    'MYSQLGetGID',
+    'MYSQLDefaultGID',
+    'MYSQLGetDir',
+    'MYSQLForceTildeExpansion',
+    'MYSQLGetQTAFS',
+    'MYSQLGetQTASZ',
+    'MYSQLGetRatioUL',
+    'MYSQLGetRatioDL',
+    'MYSQLGetBandwidthUL',
+    'MYSQLGetBandwidthDL',
+  ]
 
   file { $pureftpd::params::mysql_conf_path:
     ensure  => file,

manifests/params.pp

@@ -23,7 +23,7 @@
       $ldap_conf_erb   = 'redhat/pure-ftpd.conf.erb'
       $ldap_conf_path  = "${config_dir}/pureftpd-ldap.conf"
 
-      $mysql_conf_erb  = 'redhat/pureftpd-mysql.conf.erb'
+      $mysql_conf_erb  = 'redhat/pure-ftpd.conf.erb'
       $mysql_conf_path = "${config_dir}/pureftpd-mysql.conf"
 
       $pgsql_conf_erb  = 'redhat/pure-ftpd.conf.erb'

spec/classes/config_mysql_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+
+  test_options = [
+    'MYSQLServer',
+    'MYSQLPort',
+    'MYSQLSocket',
+    'MYSQLUser',
+    'MYSQLPassword',
+    'MYSQLDatabase',
+    'MYSQLCrypt',
+    'MYSQLTransactions',
+    'MYSQLGetPW',
+    'MYSQLGetUID',
+    'MYSQLDefaultUID',
+    'MYSQLGetGID',
+    'MYSQLDefaultGID',
+    'MYSQLGetDir',
+    'MYSQLForceTildeExpansion',
+    'MYSQLGetQTAFS',
+    'MYSQLGetQTASZ',
+    'MYSQLGetRatioUL',
+    'MYSQLGetRatioDL',
+    'MYSQLGetBandwidthUL',
+    'MYSQLGetBandwidthDL',
+  ]
+
+describe 'pureftpd::config::mysql' do
+
+  shared_examples 'config' do |params, content|
+    let(:facts) {{ :osfamily=> 'RedHat' }}
+    let(:params) { params }
+
+    it do
+      should include_class('pureftpd::config::mysql') 
+      should contain_file('/etc/pure-ftpd/pureftpd-mysql.conf') \
+        .with_ensure('file') \
+        .with_content(content)
+    end
+  end
+
+  all_params  = {}
+  all_content = ''
+  value = 'xxx'
+
+  # accumutate all of the params and content strings as we test each individual
+  # option so we can use them for the next test
+  context 'one option at a time' do
+    test_options.each do |option|
+      params = {}
+      params[option.downcase.to_sym] = value
+      content = sprintf("%-19s %s\n", option, value)
+
+      all_params.merge!(params)
+      all_content += content
+
+      it_behaves_like 'config', params, content
+    end
+  end
+  
+  # test all of the known options at once this works because the ordering of
+  # options values in the output file is fixed
+  context 'all options' do
+    it_behaves_like 'config', all_params, all_content
+  end
+
+end