update pureftpd::config::pgsql to use the common erb template + rspec

Author: Joshua Hoblitt

manifests/config/pgsql.pp

@@ -12,8 +12,48 @@
 #
 # - implement template and variables for the pgsql config file
 #
+class pureftpd::config::pgsql (
+  $pgsqlserver         = undef,
+  $pgsqlport           = undef,
+  $pgsqluser           = undef,
+  $pgsqlpassword       = undef,
+  $pgsqldatabase       = undef,
+  $pgsqlcrypt          = undef,
+  $pgsqlgetpw          = undef,
+  $pgsqlgetuid         = undef,
+  $pgsqldefaultuid     = undef,
+  $pgsqlgetgid         = undef,
+  $pgsqldefaultgid     = undef,
+  $pgsqlgetdir         = undef,
+  $pgsqlgetqtafs       = undef,
+  $pgsqlgetqtasz       = undef,
+  $pgsqlgetratioul     = undef,
+  $pgsqlgetratiodl     = undef,
+  $pgsqlgetbandwidthul = undef,
+  $pgsqlgetbandwidthdl = undef,
+) inherits pureftpd::params {
 
-class pureftpd::config::pgsql inherits pureftpd::params {
+  # pure-ftpd-1.0.30/src/log_pgsql_p.h
+  $conf_options = [
+    'PGSQLServer',
+    'PGSQLPort',
+    'PGSQLUser',
+    'PGSQLPassword',
+    'PGSQLDatabase',
+    'PGSQLCrypt',
+    'PGSQLGetPW',
+    'PGSQLGetUID',
+    'PGSQLDefaultUID',
+    'PGSQLGetGID',
+    'PGSQLDefaultGID',
+    'PGSQLGetDir',
+    'PGSQLGetQTAFS',
+    'PGSQLGetQTASZ',
+    'PGSQLGetRatioUL',
+    'PGSQLGetRatioDL',
+    'PGSQLGetBandwidthUL',
+    'PGSQLGetBandwidthDL',
+  ]
 
   file { $pureftpd::params::pgsql_conf_path:
     ensure  => file,

manifests/params.pp

@@ -26,7 +26,7 @@
       $mysql_conf_erb  = 'redhat/pureftpd-mysql.conf.erb'
       $mysql_conf_path = "${config_dir}/pureftpd-mysql.conf"
 
-      $pgsql_conf_erb  = 'redhat/pureftpd-pgsql.conf.erb'
+      $pgsql_conf_erb  = 'redhat/pure-ftpd.conf.erb'
       $pgsql_conf_path = "${config_dir}/pureftpd-pgsql.conf"
     }
     default:{

spec/classes/config_pgsql_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+  test_options = [
+    'PGSQLServer',
+    'PGSQLPort',
+    'PGSQLUser',
+    'PGSQLPassword',
+    'PGSQLDatabase',
+    'PGSQLCrypt',
+    'PGSQLGetPW',
+    'PGSQLGetUID',
+    'PGSQLDefaultUID',
+    'PGSQLGetGID',
+    'PGSQLDefaultGID',
+    'PGSQLGetDir',
+    'PGSQLGetQTAFS',
+    'PGSQLGetQTASZ',
+    'PGSQLGetRatioUL',
+    'PGSQLGetRatioDL',
+    'PGSQLGetBandwidthUL',
+    'PGSQLGetBandwidthDL',
+  ]
+
+describe 'pureftpd::config::pgsql' do
+
+  shared_examples 'config' do |params, content|
+    let(:facts) {{ :osfamily=> 'RedHat' }}
+    let(:params) { params }
+
+    it do
+      should include_class('pureftpd::config::pgsql') 
+      should contain_file('/etc/pure-ftpd/pureftpd-pgsql.conf') \
+        .with_ensure('file') \
+        .with_content(content)
+    end
+  end
+
+  all_params  = {}
+  all_content = ''
+  value = 'xxx'
+
+  # accumutate all of the params and content strings as we test each individual
+  # option so we can use them for the next test
+  context 'one option at a time' do
+    test_options.each do |option|
+      params = {}
+      params[option.downcase.to_sym] = value
+      content = sprintf("%-19s %s\n", option, value)
+
+      all_params.merge!(params)
+      all_content += content
+
+      it_behaves_like 'config', params, content
+    end
+  end
+  
+  # test all of the known options at once this works because the ordering of
+  # options values in the output file is fixed
+  context 'all options' do
+    it_behaves_like 'config', all_params, all_content
+  end
+
+end