Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

Commit 3160b1e

Browse files
author
dmitriy
committed
Minor tests refactoring
1 parent a2f5c23 commit 3160b1e

File tree

3 files changed

+10
-18
lines changed

3 files changed

+10
-18
lines changed

android/TPSDropDown/.travis.yml

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ android:
1313
- extra-android-m2repository
1414

1515
before_script:
16-
# Create and start emulator
1716
- echo no | android create avd --force -n test -t android-22 --abi armeabi-v7a
1817
- emulator -avd test -no-skin -no-audio -no-window &
1918
- android-wait-for-emulator

android/TPSDropDown/testmodule/src/androidTest/java/com/gettipsi/testmodule/DropdownTests.java

+9-7
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ public void checkForCorrectViews() {
5757

5858
@Test
5959
public void checkItemsSelection() {
60-
onView(withId(R.id.dropdownId))
61-
.perform(new SetupElementsAction(items))
62-
.check(ViewAssertions.matches(DropdownMatcher.withListSize(items.size())));
60+
setupItems();
6361

6462
onView(withId(R.id.dropdownId))
6563
.perform(new SetSelectedAction(0))
@@ -85,10 +83,7 @@ public void checkItemsSelection() {
8583

8684
@Test
8785
public void checkItemsWithNameSelection() {
88-
onView(withId(R.id.dropdownId))
89-
.perform(new SetupElementsAction(items))
90-
.check(ViewAssertions.matches(DropdownMatcher.withListSize(items.size())));
91-
86+
setupItems();
9287
onView(withId(R.id.dropdownId))
9388
.perform(new SelectElementWithNameAction(items.get(0).toString()))
9489
.check(matches(withSpinnerText(items.get(0).toString())));
@@ -113,6 +108,7 @@ public void checkItemsWithNameSelection() {
113108

114109
@Test
115110
public void checkItemsClickSelection() {
111+
setupItems();
116112
String item = items.get(0).toString();
117113
onView(withId(R.id.dropdownId)).perform(click());
118114
onData(allOf(is(instanceOf(String.class)), is(item))).perform(click());
@@ -134,4 +130,10 @@ public void checkItemsClickSelection() {
134130
onView(withId(R.id.dropdownId)).check(matches(withSpinnerText(containsString(item3))));
135131
}
136132

133+
private void setupItems() {
134+
onView(withId(R.id.dropdownId))
135+
.perform(new SetupElementsAction(items))
136+
.check(ViewAssertions.matches(DropdownMatcher.withListSize(items.size())));
137+
}
138+
137139
}
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
11
package com.gettipsi.testmodule;
22

3-
import android.support.v7.app.AppCompatActivity;
43
import android.os.Bundle;
5-
6-
import com.gettipsi.tpsdropdown.Dropdown;
7-
import com.gettipsi.tpsdropdown.DropdownContainer;
8-
9-
import java.util.Arrays;
4+
import android.support.v7.app.AppCompatActivity;
105

116
public class MainActivity extends AppCompatActivity {
127

138
@Override
149
protected void onCreate(Bundle savedInstanceState) {
1510
super.onCreate(savedInstanceState);
1611
setContentView(R.layout.activity_main);
17-
18-
Dropdown dropdown = ((DropdownContainer) findViewById(R.id.dropdown)).getDropdown();
19-
dropdown.setupWithElements(Arrays.<Object>asList("One", "Two", "Three", "Four"));
20-
2112
}
2213
}

0 commit comments

Comments
 (0)