Album art does not appear to work consistently

[dominicbarnes]

🌎 Environment

• Environment: Production
• Device: Doogee S100
• OS: Android 12
• App Version & Build: 1.0.7 (10070074)
• Possible Cause: n/a

💬 Description

My album artwork is not showing up consistently, especially compared to Shuttle+. After some troubleshooting, it appears that the file format is the root issue.

When using JPEG local files (eg: albumart.jpg in the folder alongside .mp3 files), the artwork does not show. However, upon converting the file to PNG (albumart.png), it starts showing as expected.

When using Shuttle+, I can get both file formats to work correctly, it seems that S2 may be missing support for JPEG files.

UPDATE: after some more debugging, I discovered I could rename albumart.jpg to album.jpg and get the correct behavior. So it seems to be more an issue of the file name rather than the file format as I originally suspected.

🦶 Reproduction Steps

Steps to reproduce the behavior:

1. Create a directory
2. Add a music file (eg: .mp3) with no embedded images
3. Add a JPEG artwork file (eg: albumart.jpg)
4. Rescan

🤔 Expected Results

The album art should be displayed for the album

😲 Actual Results

The album art is not displayed (only the default "disc" icon appears)

Upon converting albumart.jpg (JPEG) to albumart.png (PNG), I get the expected results.

📸 Screenshots

n/a

📎 Attachments

n/a

🤝 Relationships

n/a

[dominicbarnes]

As a workaround, I am writing a script to copy + convert any albumart.jpg so that I also have an albumart.png rename all albumart.* files to album.* instead.

[dominicbarnes]

After reading the changelog, I learned that the file name also appears to matter. If I rename albumart.jpg to album.jpg, that actually works correctly.

I'm not 100% sure why albumart as a filename doesn't seem to work for JPG files (but does for PNG files), so it's now looking more to me like it's not a file format issue and more a naming issue.

[a-gss]

i've always used cover.png/jpg, sometimes it works, sometimes it doesnt. I didn't know you could name it album or albumart ; would be cool to know what regex is valid !

[a-gss]

Well, since I dove my head in it, here's the current regex pattern : (folder|cover|album).*\.(jpg|jpeg|png|webp)

albumart is not a valid string, hence your issue. woops just check on regex101 and it works.
You can look at #177 for the location in the code.