Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELP command doesnt work #31

Open
Eastborn opened this issue Nov 2, 2015 · 2 comments
Open

HELP command doesnt work #31

Eastborn opened this issue Nov 2, 2015 · 2 comments

Comments

@Eastborn
Copy link

Eastborn commented Nov 2, 2015

The HELP command doesnt work since it's response is multi lined

the assumption of

168  // Server answers with:
169  // [- One line containing the answer ]
170  // - "error id=XX msg=YY". ID is zero if command was executed successfully.

in index.js is incorrect for this command (possibly for more commands)

example with

160  reader.on("line", function(line){
161    console.log(line);
node startup.js
TS3 //Skipped because 1 of first 2 lines
Welcome to the TeamSpeak 3 ServerQuery interface, type "help" for a list of commands and "help <command>" for information on a specific command. //Skipped because 2 of first 2 lines
error id=0 msg=ok //logged in
error id=0 msg=ok //use (selecting ts instance)
Usage: channelinfo cid={channelID} //from here is what i get from the server

Displays detailed configuration information about a channel including ID,
topic, description, etc.

Example:
   channelinfo cid=1
   channel_name=Default\sChannel channel_topic=No\s[b]topic[\/b]\shere
   channel_description=Welcome ...
   error id=0 msg=ok

{ channel_description: 'Welcome', '...': '' } //result of the library
error id=0 msg=ok //End of help
error id=0 msg=ok //logout
error id=0 msg=ok //quit
@dtheb
Copy link
Contributor

dtheb commented Nov 2, 2015

True but.. why should it work?
this is a module/interface.. why would any dev need to send/read the help command in code?

afaik other commands are fine since the responses are all encoded/escaped
the "help" is not encoded for readability ..

i believe the effort to implement (fix?) this is little overkill .. you already got the query PDF

@zyberspace
Copy link
Contributor

True but.. why should it work?
this is a module/interface.. why would any dev need to send/read the help command in code?

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants