Detekt cleanup

Author: DeweyReed

app-backup/src/test/java/xyz.aprildown.timer.backup/BaseBackupViewModelTest.kt app-backup/src/test/java/xyz/aprildown/timer/app/backup/BaseBackupViewModelTest.kt

@@ -1,4 +1,4 @@
-package xyz.aprildown.timer.backup
+package xyz.aprildown.timer.app.backup
 
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.ViewModelProvider
@@ -9,7 +9,6 @@ import org.junit.Assert.assertFalse
 import org.junit.Assert.assertNull
 import org.junit.Assert.assertTrue
 import org.junit.Test
-import xyz.aprildown.timer.app.backup.BaseBackupViewModel
 
 internal abstract class BaseBackupViewModelTest {
 

app-backup/src/test/java/xyz.aprildown.timer.backup/ExportViewModelTest.kt app-backup/src/test/java/xyz/aprildown/timer/app/backup/ExportViewModelTest.kt

@@ -1,4 +1,4 @@
-package xyz.aprildown.timer.backup
+package xyz.aprildown.timer.app.backup
 
 import androidx.lifecycle.SavedStateHandle
 import kotlinx.coroutines.test.StandardTestDispatcher
@@ -17,7 +17,6 @@ import org.mockito.kotlin.mock
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.verifyNoMoreInteractions
 import org.mockito.kotlin.whenever
-import xyz.aprildown.timer.app.backup.ExportViewModel
 import xyz.aprildown.timer.domain.usecases.Fruit
 import xyz.aprildown.timer.domain.usecases.data.ExportAppData
 

app-backup/src/test/java/xyz.aprildown.timer.backup/ImportViewModelTest.kt app-backup/src/test/java/xyz/aprildown/timer/app/backup/ImportViewModelTest.kt

@@ -1,4 +1,4 @@
-package xyz.aprildown.timer.backup
+package xyz.aprildown.timer.app.backup
 
 import kotlinx.coroutines.test.StandardTestDispatcher
 import kotlinx.coroutines.test.TestScope
@@ -13,7 +13,6 @@ import org.junit.Test
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.verifyNoMoreInteractions
-import xyz.aprildown.timer.app.backup.ImportViewModel
 import xyz.aprildown.timer.domain.usecases.Fruit
 import xyz.aprildown.timer.domain.usecases.data.ImportAppData
 import xyz.aprildown.timer.domain.usecases.data.NotifyDataChanged

baselineProfile/src/main/java/io/github/deweyreed/timer/baselineprofile/StartupBenchmarks.kt

@@ -29,8 +29,8 @@ import org.junit.runner.RunWith
  * You should run the benchmarks on a physical device, not an Android emulator, because the
  * emulator doesn't represent real world performance and shares system resources with its host.
  *
- * For more information, see the [Macrobenchmark documentation](https://d.android.com/macrobenchmark#create-macrobenchmark)
- * and the [instrumentation arguments documentation](https://d.android.com/topic/performance/benchmarking/macrobenchmark-instrumentation-args).
+ * For more information, see the https://d.android.com/macrobenchmark#create-macrobenchmark
+ * and the https://d.android.com/topic/performance/benchmarking/macrobenchmark-instrumentation-args.
  **/
 @RunWith(AndroidJUnit4::class)
 @LargeTest

component-key/src/main/java/xyz/aprildown/timer/component/key/behaviour/BehaviourLayout.kt

@@ -66,7 +66,9 @@ class BehaviourLayout @JvmOverloads constructor(
             binding.layoutImage.isVisible = true
             val imageView = if (binding.layoutImage.isEmpty()) {
                 LayoutEditableBehaviourImageBinding.inflate(
-                    LayoutInflater.from(context), binding.layoutImage, true
+                    LayoutInflater.from(context),
+                    binding.layoutImage,
+                    true
                 ).root
             } else {
                 LayoutEditableBehaviourImageBinding.bind(binding.layoutImage.getChildAt(0)).root

component-key/src/main/java/xyz/aprildown/timer/component/key/behaviour/EditableBehaviourLayout.kt

@@ -134,7 +134,9 @@ class EditableBehaviourLayout(
         if (imageAction != null) {
             val imageView = if (binding.layoutImage.isEmpty()) {
                 LayoutEditableBehaviourImageBinding.inflate(
-                    LayoutInflater.from(context), binding.layoutImage, true
+                    LayoutInflater.from(context),
+                    binding.layoutImage,
+                    true
                 ).root
             } else {
                 LayoutEditableBehaviourImageBinding.bind(binding.layoutImage.getChildAt(0)).root

data/src/androidTest/java/xyz/aprildown/timer/data/repositories/SchedulerRepositoryImplTest.kt

@@ -28,7 +28,6 @@ class SchedulerRepositoryImplTest {
     private val context = ApplicationProvider.getApplicationContext<Context>()
     private val database = MachineDatabase.createInMemoryDatabase(context)
     private val timerRepository: TimerRepository = TimerRepositoryImpl(
-        context = context,
         timerDao = database.timerDao(),
         timerMapper = TimerMapper(StepMapper(StepOnlyMapper(BehaviourMapper())), TimerMoreMapper()),
         timerInfoMapper = TimerInfoMapper(),

data/src/androidTest/java/xyz/aprildown/timer/data/repositories/TimerRepositoryImplTest.kt

@@ -24,7 +24,6 @@ class TimerRepositoryImplTest {
     private val context = ApplicationProvider.getApplicationContext<Context>()
     private val database = MachineDatabase.createInMemoryDatabase(context)
     private val timerRepository: TimerRepository = TimerRepositoryImpl(
-        context = context,
         timerDao = database.timerDao(),
         timerMapper = TimerMapper(StepMapper(StepOnlyMapper(BehaviourMapper())), TimerMoreMapper()),
         timerInfoMapper = TimerInfoMapper(),

data/src/main/java/xyz/aprildown/timer/data/repositories/TimerRepositoryImpl.kt

@@ -1,8 +1,6 @@
 package xyz.aprildown.timer.data.repositories
 
-import android.content.Context
 import dagger.Reusable
-import dagger.hilt.android.qualifiers.ApplicationContext
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.map
 import xyz.aprildown.timer.data.db.TimerDao
@@ -16,7 +14,6 @@ import javax.inject.Inject
 
 @Reusable
 internal class TimerRepositoryImpl @Inject constructor(
-    @ApplicationContext context: Context,
     private val timerDao: TimerDao,
     private val timerMapper: TimerMapper,
     private val timerInfoMapper: TimerInfoMapper,

detekt-config.yml

@@ -4,7 +4,7 @@ complexity:
   CyclomaticComplexMethod:
     active: false
   LargeClass:
-    threshold: 1000
+    threshold: 2000
   LongMethod:
     active: false
   LongParameterList:
@@ -21,6 +21,11 @@ exceptions:
   TooGenericExceptionThrown:
     active: false
 
+naming:
+  FunctionNaming:
+    ignoreAnnotated:
+      - "Composable"
+
 style:
   LoopWithTooManyJumpStatements:
     maxJumpCount: 2

gradle/libs.versions.toml

@@ -13,7 +13,7 @@ kotlin = "1.9.25"
 dagger = "2.52"
 composeCompiler = "1.5.15"
 
-detekt = "1.23.6"
+detekt = "1.23.7"
 
 [plugins]
 android-application = { id = "com.android.application", version.ref = "agp" }