Skip to content

Commit a8f08fc

Browse files
authored
profiles: Make mapping in Profile optional (open-telemetry#556)
As commented in [0] and discussed in the OTel Profiling SIG meeting, there are situations where a main binary for a Profile can not be identified. For these cases mark the field optional. FYI: @brancz @petethepig @open-telemetry/profiling-maintainers [0]: open-telemetry#534 (comment)
1 parent d785e67 commit a8f08fc

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

opentelemetry/proto/profiles/v1development/pprofextended.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ message Profile {
7979
repeated Sample sample = 2;
8080
// Mapping from address ranges to the image/binary/library mapped
8181
// into that address range. mapping[0] will be the main binary.
82+
// If multiple binaries contribute to the Profile and no main
83+
// binary can be identified, mapping[0] has no special meaning.
8284
repeated Mapping mapping = 3;
8385
// Locations referenced by samples via location_indices.
8486
repeated Location location = 4;

0 commit comments

Comments
 (0)