Merge pull request #1172 from tidymodels/optim-to-sparse

EmilHvitfeldt · web-flow · commit bc27e2b8d4c6 · 2024-09-05T08:35:11.000-07:00
reduce overhead of `to_sparse_data_frame()`
diff --git a/R/sparsevctrs.R b/R/sparsevctrs.R
@@ -18,7 +18,7 @@ is_sparse_tibble <- function(x) {
 }
 
 materialize_sparse_tibble <- function(x, object, input) {
-  if ((!allow_sparse(object)) && is_sparse_tibble(x)) {
+  if (is_sparse_tibble(x) && (!allow_sparse(object))) {
     cli::cli_warn(
       "{.arg {input}} is a sparse tibble, but {.fn {class(object)[1]}} with
       engine {.code {object$engine}} doesn't accept that. Converting to 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ is_sparse_tibble <- function(x) {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`materialize_sparse_tibble <- function(x, object, input) {`
`21`		`- if ((!allow_sparse(object)) && is_sparse_tibble(x)) {`
	`21`	`+ if (is_sparse_tibble(x) && (!allow_sparse(object))) {`
`22`	`22`	`cli::cli_warn(`
`23`	`23`	`"{.arg {input}} is a sparse tibble, but {.fn {class(object)[1]}} with`
`24`	`24`	`engine {.code {object$engine}} doesn't accept that. Converting to`