Fixes for #289 abd #292

topepo · topepo · commit 1100ad34ab70 · 2020-04-30T18:45:41.000-04:00
diff --git a/R/engines.R b/R/engines.R
@@ -42,10 +42,12 @@ check_installs <- function(x) {
   if (length(x$method$libs) > 0) {
     is_inst <- map_lgl(x$method$libs, is_installed)
     if (any(!is_inst)) {
+      missing_pkg <- x$method$libs[!is_inst]
+      missing_pkg <- paste0(missing_pkg, collapse = ", ")
       rlang::abort(
         glue::glue(
           "This engine requires some package installs: ",
-          glue::glue_collapse(glue::glue("'{x}'"), sep = ", ")
+          glue::glue_collapse(glue::glue("'{missing_pkg}'"), sep = ", ")
         )
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,12 @@ check_installs <- function(x) {`
`42`	`42`	`if (length(x$method$libs) > 0) {`
`43`	`43`	`is_inst <- map_lgl(x$method$libs, is_installed)`
`44`	`44`	`if (any(!is_inst)) {`
	`45`	`+ missing_pkg <- x$method$libs[!is_inst]`
	`46`	`+ missing_pkg <- paste0(missing_pkg, collapse = ", ")`
`45`	`47`	`rlang::abort(`
`46`	`48`	`glue::glue(`
`47`	`49`	`"This engine requires some package installs: ",`
`48`		`- glue::glue_collapse(glue::glue("'{x}'"), sep = ", ")`
	`50`	`+ glue::glue_collapse(glue::glue("'{missing_pkg}'"), sep = ", ")`
`49`	`51`	`)`
`50`	`52`	`)`
`51`	`53`	`}`