From 63ba1f694438b1eb47cde292af3a03a98a25f36b Mon Sep 17 00:00:00 2001 From: cketti Date: Fri, 21 Apr 2023 17:46:55 +0200 Subject: [PATCH] Increase number of active notification to 9 This way users can know that when the number 9 is displayed in the group summary, there's more notifications than the 8 they can currently see. --- .../com/fsck/k9/notification/NotificationDataStore.kt | 2 +- .../fsck/k9/notification/NotificationDataStoreTest.kt | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt b/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt index b9f63f3bba4..f3e80d344e9 100644 --- a/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt +++ b/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt @@ -3,7 +3,7 @@ package com.fsck.k9.notification import com.fsck.k9.Account import com.fsck.k9.controller.MessageReference -internal const val MAX_NUMBER_OF_NEW_MESSAGE_NOTIFICATIONS = 8 +internal const val MAX_NUMBER_OF_NEW_MESSAGE_NOTIFICATIONS = 9 /** * Stores information about new message notifications for all accounts. diff --git a/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt b/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt index 3e1d869b074..781acaf6554 100644 --- a/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt +++ b/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt @@ -52,8 +52,9 @@ class NotificationDataStoreTest : RobolectricTest() { notificationDataStore.addNotification(account, createNotificationContent("6"), TIMESTAMP) notificationDataStore.addNotification(account, createNotificationContent("7"), TIMESTAMP) notificationDataStore.addNotification(account, createNotificationContent("8"), TIMESTAMP) + notificationDataStore.addNotification(account, createNotificationContent("9"), TIMESTAMP) - val result = notificationDataStore.addNotification(account, createNotificationContent("9"), TIMESTAMP) + val result = notificationDataStore.addNotification(account, createNotificationContent("10"), TIMESTAMP) assertNotNull(result) assertThat(result.shouldCancelNotification).isTrue() @@ -86,7 +87,8 @@ class NotificationDataStoreTest : RobolectricTest() { notificationDataStore.addNotification(account, createNotificationContent("7"), TIMESTAMP) notificationDataStore.addNotification(account, createNotificationContent("8"), TIMESTAMP) notificationDataStore.addNotification(account, createNotificationContent("9"), TIMESTAMP) - val latestContent = createNotificationContent("10") + notificationDataStore.addNotification(account, createNotificationContent("10"), TIMESTAMP) + val latestContent = createNotificationContent("11") notificationDataStore.addNotification(account, latestContent, TIMESTAMP) val result = notificationDataStore.removeNotifications(account) { listOf(latestContent.messageReference) } @@ -207,7 +209,8 @@ class NotificationDataStoreTest : RobolectricTest() { notificationDataStore.addNotification(account, createNotificationContent("6"), TIMESTAMP) notificationDataStore.addNotification(account, createNotificationContent("7"), TIMESTAMP) notificationDataStore.addNotification(account, createNotificationContent("8"), TIMESTAMP) - val latestNotificationContent = createNotificationContent("9") + notificationDataStore.addNotification(account, createNotificationContent("9"), TIMESTAMP) + val latestNotificationContent = createNotificationContent("10") notificationDataStore.addNotification(account, latestNotificationContent, TIMESTAMP) val content = createNotificationContent("1")