check if approve node has any nodes to approve before updating db

Author: Eslam-Nawara

node-registrar/pkg/db/farms.go

@@ -90,7 +90,7 @@ func (db *Database) ApproveNodes(farmID uint64, nodeIDs []uint64) error {
 		return result.Error
 	}
 
-	// Check if all nodes were found and updated
+	// Check if all nodes were found, belong to the requested farm and updated
 	if int(result.RowsAffected) != len(nodeIDs) {
 		tx.Rollback()
 		return fmt.Errorf("some nodes were not found, do not belong to farm %d, or are already approved", farmID)

node-registrar/pkg/server/handlers.go

@@ -863,7 +863,7 @@ func (s *Server) approveNodesHandler(c *gin.Context) {
 		return
 	}
 
-	// Ensure the requester owns the farm
+	// Ensure the farmer approving the nodes is the owner of the farm
 	ensureOwner(c, farm.TwinID)
 	if c.IsAborted() {
 		return
@@ -875,6 +875,11 @@ func (s *Server) approveNodesHandler(c *gin.Context) {
 		return
 	}
 
+	if len(req.NodeIDs) == 0 {
+		c.JSON(http.StatusBadRequest, gin.H{"error": "could not find any nodes to approve"})
+		return
+	}
+
 	if err := s.db.ApproveNodes(id, req.NodeIDs); err != nil {
 		c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
 		return